From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 395BAA00E6 for ; Wed, 7 Aug 2019 04:05:14 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E3BA85680; Wed, 7 Aug 2019 04:05:12 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by dpdk.org (Postfix) with ESMTP id 036EC2E8F for ; Wed, 7 Aug 2019 04:05:11 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id x771tCYP014722; Tue, 6 Aug 2019 19:05:06 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : content-type : content-transfer-encoding : mime-version; s=pfpt0818; bh=eKRO8Ox/HPhLhNCexyKYgGyrCgj2i9g6NnuKgC5yuD4=; b=fBfTBfxxxeyRxiCGsOun0v7MAzhREhmfbM3h5zPUGgxmWJ1meKnj8a8PjumaA9fuX7gR n315H4Tn14zqAxAlasEmyUr4IrBexft0t0FVQIm+TZvCH8Jun5MGJWT6IMZ10akf2k2r 5MNjxT03cJZWdTWY8sSavwifHoAZkoUP978KNjRdcPNXxqWliorjXSu07x24LbBllsmd oRP9CLvFm/iG0pf2GlFchJ6i4UGTNgjbXSvYSTl0hw+W/tyTLiiI0rtDA3axtGAi8l7z mgc08Wftr76B2tUGS078sGJ/s9n1A6DEL9XoPDda4SqncmE5cQv+vsXytvBGDNQSQDgI Rw== Received: from sc-exch02.marvell.com ([199.233.58.182]) by mx0b-0016f401.pphosted.com with ESMTP id 2u59skwahe-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Tue, 06 Aug 2019 19:04:50 -0700 Received: from SC-EXCH02.marvell.com (10.93.176.82) by SC-EXCH02.marvell.com (10.93.176.82) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Tue, 6 Aug 2019 19:04:43 -0700 Received: from NAM04-BN3-obe.outbound.protection.outlook.com (104.47.46.51) by SC-EXCH02.marvell.com (10.93.176.82) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Tue, 6 Aug 2019 19:04:43 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=T3AKWzwJL45J8F3IyPNNGmiButil2Xdx/tkPZ85VZaQMzNY4IjUI/26WpVwl4Rm5+iDLLe+uQRj2v3MAecr8Tva2waIaroHaOu7n3c4GOFoFLII2QfMgA+4Om1HbT3J8ahBgGiH9e1OmCsw6vZG+U/3D5Rv9EVXUmWJM5V4iSBjO6pU1Agi3HBq4a8Q/LnkzAAN9aPB/PHP0U0UMZnzFppsGlmujcHkTB92Brpu9SPfZ/sXAi1UvaXBoeIuK9HSPEtUKx9Uqqo4wkXUXzgIS4swGPoaQtwK4mzdsb26+ch3Cz6JZ/ewMy3fOat3gb9REisV0L0s4ze8uNv7c6gnBFA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eKRO8Ox/HPhLhNCexyKYgGyrCgj2i9g6NnuKgC5yuD4=; b=PkHm2R+q70lvTAh+urISMEcBmeWtZE4Y496uq8bv6d4H79m4x/UuKklsKPrb3Vv+CLF1kyoddYxBgVnTtEMVmbsOr1cw1mwG6UAEHPfZkLAQDERJnxtUowqVUigTqgdGqCKY/me2T+Dpfw4E1tPZ49kA9k0YpfzOTpUwJ7lorWjh/3u0uEeEtIEGIFXOC2c2D+KPuhGLCmB7R9lJMC1pChnfeVdhEtac24NoFsX0oo1flu/bOO/xv6HGXJIoTiQ6O9a16L+z0pMsDYCo+pgXVftMzjdRO3IkSChOHnF0IkjzrdV1YUM3ApYylySNA+u7RUe8GaAdp1v/PloVhHQK4Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=marvell.com;dmarc=pass action=none header.from=marvell.com;dkim=pass header.d=marvell.com;arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector2-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eKRO8Ox/HPhLhNCexyKYgGyrCgj2i9g6NnuKgC5yuD4=; b=fLw3N1WiaZR8bHyah/qiqM1kxbOg/EJUlXhsHLedUcPdEGR/GCVf6PtlaYrlb+cN6bISX+6y55smkiVvfBCiwsEXuZpHz/YGCPI6jn26gfbCgCcQvti1ifXEjsXJKNNwiC7XDWQPCpG0VW6+msdmyJboVQy6Q/4fVwfJFvlTrcU= Received: from BYAPR18MB2424.namprd18.prod.outlook.com (20.179.91.149) by BYAPR18MB2581.namprd18.prod.outlook.com (20.179.93.210) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2136.14; Wed, 7 Aug 2019 02:04:37 +0000 Received: from BYAPR18MB2424.namprd18.prod.outlook.com ([fe80::5877:72b7:40cf:2013]) by BYAPR18MB2424.namprd18.prod.outlook.com ([fe80::5877:72b7:40cf:2013%3]) with mapi id 15.20.2136.018; Wed, 7 Aug 2019 02:04:36 +0000 From: Jerin Jacob Kollanukkaran To: Stephen Hemminger , Andrew Rybchenko CC: Pavan Nikhilesh Bhagavatula , Hemant Agrawal , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [RFC 0/3] ethdev: add ptype as Rx offload Thread-Index: AdVMw63wChTg/XpARxiu4h7Vjcd54Q== Date: Wed, 7 Aug 2019 02:04:36 +0000 Message-ID: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [171.61.87.186] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 3663373c-ffc2-46a5-d513-08d71adb9921 x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(5600148)(711020)(4605104)(1401327)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7193020); SRVR:BYAPR18MB2581; x-ms-traffictypediagnostic: BYAPR18MB2581: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-forefront-prvs: 01221E3973 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(396003)(376002)(366004)(346002)(136003)(39860400002)(13464003)(52314003)(51444003)(189003)(199004)(66556008)(66946007)(66476007)(6116002)(86362001)(33656002)(64756008)(76116006)(229853002)(66446008)(2906002)(53546011)(74316002)(81166006)(305945005)(14454004)(81156014)(8676002)(7736002)(3846002)(8936002)(6506007)(186003)(110136005)(54906003)(316002)(99286004)(25786009)(4326008)(486006)(476003)(55016002)(6436002)(53936002)(68736007)(9686003)(14444005)(7696005)(6246003)(71190400001)(102836004)(478600001)(5660300002)(26005)(66066001)(71200400001)(52536014)(256004); DIR:OUT; SFP:1101; SCL:1; SRVR:BYAPR18MB2581; H:BYAPR18MB2424.namprd18.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: xAsOiAlfYjuKRtV2T5mNVNRRifMoHv0leJ/P9otbMxGLo4LmHiRyeTExBQzzB/DNAwnpsNYu/X4zRGdWOX528LLkkeBIVQTAeql0y/gGI3DNlVyiFCj/xaD9dGLv1+0z+7yrfwe5GnMjxr/xVunSmWQvP8xtnLwsl/wZ1phgGGM1xif/rc9c0Pp3e9r9M7JrxJ+PeTOXJpY+iSdtQQE5O9c2mbSC304OdJYj0vGPzd8Nk2OwD8v5Urk2FZaDGKUzj7Y2uH1Yih9Cyu5ofjQ+YM4TdpN20+T7RVNcf5YgCASosPucFgPTngFvNL+wd9krGr560FrZLyHDHNKbuKJnHN8ZiWX9tx4Fzy2TM5pwCDXXhkDGWFHn7FbI9I59Zqq6B6558Cdmd5WUqYaPHApRf7gd/rK41nEDxlmsyJMkpiA= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 3663373c-ffc2-46a5-d513-08d71adb9921 X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Aug 2019 02:04:36.4366 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: jerinj@marvell.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR18MB2581 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:5.22.84,1.0.8 definitions=2019-08-06_11:2019-08-05,2019-08-06 signatures=0 Subject: Re: [dpdk-dev] [RFC 0/3] ethdev: add ptype as Rx offload X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Stephen Hemminger > Sent: Wednesday, August 7, 2019 4:45 AM > To: Andrew Rybchenko > Cc: Pavan Nikhilesh Bhagavatula ; Hemant > Agrawal ; Jerin Jacob Kollanukkaran > ; dev@dpdk.org > Subject: [EXT] Re: [dpdk-dev] [RFC 0/3] ethdev: add ptype as Rx offload >=20 > On Tue, 6 Aug 2019 12:06:35 +0300 > Andrew Rybchenko wrote: >=20 > > On 8/6/19 11:47 AM, Pavan Nikhilesh Bhagavatula wrote: > > > > > >> -----Original Message----- > > >> From: Hemant Agrawal > > >> Sent: Tuesday, August 6, 2019 1:49 PM > > >> To: Pavan Nikhilesh Bhagavatula ; Jerin > > >> Jacob Kollanukkaran > > >> Cc: dev@dpdk.org > > >> Subject: RE: [dpdk-dev] [RFC 0/3] ethdev: add ptype as Rx offload > > >>> Add PTYPE to DEV_RX_OFFLOAD_* flags. > > >>> > > >>> Currently, most of the NICs already support PTYPE parsing and > > >>> update > > >> the > > >>> mbuf->packet_type through an internal lookup table, but there is > > >>> mbuf->no > > >> way to > > >>> disable the lookup if the application is not intrested in ptypes > > >> returned by > > >>> `rte_eth_dev_get_supported_ptypes`. > > >>> > > >> [Hemant] it will also mean introducing another check in datapath, > > >> if the application has asked for PTYPE offload - copy the results > > >> to mbuf- > > >>> packet_type otherwise don't do it. > > > I think that having the check would give better performance than > > > loading ptype table to L1 doing a lookup and copying it to mbuf when= the > application doesn't need it. > > > > Anyway, if PMD decides that it is better to always provide packet type > > information - there is no harm. Basically if the offload is not > > requested it makes packet_type undefined in mbuf. > > > > >> Your second patch is incomplete in the sense that it only adds the > > >> capability. But it does not disable the lookups? > > > It is upto the maintainer of the PMD to disable the lookup in data > > > path. If there is a scope of optimization then they could do it. Ther= e is no > harm in exposing PTYPE even RX_OFFLOAD_PTYPE is not enabled. > > > I was hesitant to touch data path as it would be impossible to verify > performance effect on all NICs. > > > > I think it is the right way to approach it especially taking > > transition into account. > > >=20 > With hardline API policy, this has to fail on compile for old application= s. Not specific to this API change. That's is the propriety any new symbol add= ition to the code base. Planning to make this API change available from v19.11 LTS. > You can't magically assume that applications using ptype will set new fea= ture. When OFFLOAD flags got introduced, we decided to disable all offloads by de= fault. So, need to add positive logic here to enable offload instead of enable som= ething by Default and disable if required to get have synergy with other offloads. Will update the release note as usual to document the change.=20 Since there is NO ABI change, IMO, we don't need deprecation notice.