From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by dpdk.org (Postfix) with ESMTP id 6B0041B13A for ; Fri, 26 Apr 2019 10:00:44 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x3Q7j9XQ010657; Fri, 26 Apr 2019 01:00:43 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0818; bh=SNLIhZU6ZyrTw2mDhRk0bMRoRumjLFWY9xKpBLYb4Yo=; b=gew8t/E55PzuKbsT7jBY6OYlKGtvs2io4/kRRskz3vKWb56+WVPEdHm0caMmdB8OiNIe s1SbOwZczgqSQCgXwC7xvnfuf9E3pOxcAB86oPXwSrO5NAuDnNcK2V6zrBi6b5LIRRVr N1zyB/BSBMELOQ3Ky+XkOwEOJQ1D8QsHCryVKdyLM1IrFYQmAheiGMYNQiOQBYG8GSyG eYy4m25NXtHJJBVkdIzM4qpAyZ3nZl81ho/wbomkS/ymikk8fTQ1NJ+Gzitp3Qc48fHx mfEbrkpucwPiEKCISNUXzZMkQlUBphyqKD6pqaBxIbjx8IKZ19tcA2kYtzjy2YKC7qBW kQ== Received: from sc-exch02.marvell.com ([199.233.58.182]) by mx0a-0016f401.pphosted.com with ESMTP id 2s3p6nhn7e-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Fri, 26 Apr 2019 01:00:43 -0700 Received: from SC-EXCH03.marvell.com (10.93.176.83) by SC-EXCH02.marvell.com (10.93.176.82) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Fri, 26 Apr 2019 01:00:42 -0700 Received: from NAM03-CO1-obe.outbound.protection.outlook.com (104.47.40.55) by SC-EXCH03.marvell.com (10.93.176.83) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Fri, 26 Apr 2019 01:00:42 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SNLIhZU6ZyrTw2mDhRk0bMRoRumjLFWY9xKpBLYb4Yo=; b=TOFqfU6wSp1ntEVz6xQS9no0zJANpX+4TW0RRoDaqivmQRXhx9SEyTZUN4+MQ1p/gdHPHZTG0vXdPazqgt1PQJ19Xbs7A86o3MmKjlghayt6ympBEFycrMFJJkmLexSPbcZVm+fDPs5u1EO8MYfrhUA6ayNwOf4c6A8md3nhT1g= Received: from BYAPR18MB2424.namprd18.prod.outlook.com (20.179.91.149) by BYAPR18MB2661.namprd18.prod.outlook.com (20.179.94.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1835.12; Fri, 26 Apr 2019 08:00:40 +0000 Received: from BYAPR18MB2424.namprd18.prod.outlook.com ([fe80::6dd3:c056:b23b:ab4e]) by BYAPR18MB2424.namprd18.prod.outlook.com ([fe80::6dd3:c056:b23b:ab4e%7]) with mapi id 15.20.1835.010; Fri, 26 Apr 2019 08:00:40 +0000 From: Jerin Jacob Kollanukkaran To: Abhinandan Gujjar , "jerin.jacob@caviumnetworks.com" , "dev@dpdk.org" CC: "narender.vangati@intel.com" , "john.mcnamara@intel.com" Thread-Topic: [dpdk-dev] [PATCH] eventdev: fix control flow issues Thread-Index: AQHU+0bdpVVhH8v1OUGu1aokL3sUgKZOFDMw Date: Fri, 26 Apr 2019 08:00:40 +0000 Message-ID: References: <1556123678-80860-1-git-send-email-abhinandan.gujjar@intel.com> In-Reply-To: <1556123678-80860-1-git-send-email-abhinandan.gujjar@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [116.68.105.17] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 1331bf46-e3b5-4497-affb-08d6ca1d468d x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(5600141)(711020)(4605104)(2017052603328)(7193020); SRVR:BYAPR18MB2661; x-ms-traffictypediagnostic: BYAPR18MB2661: x-microsoft-antispam-prvs: x-forefront-prvs: 001968DD50 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(346002)(39860400002)(366004)(396003)(136003)(376002)(13464003)(199004)(189003)(81156014)(66556008)(66946007)(2501003)(11346002)(97736004)(66476007)(26005)(86362001)(2201001)(6246003)(8676002)(229853002)(66066001)(186003)(68736007)(446003)(4744005)(64756008)(2906002)(73956011)(81166006)(76116006)(476003)(6436002)(486006)(8936002)(256004)(52536014)(6506007)(55016002)(71200400001)(9686003)(478600001)(55236004)(99286004)(66446008)(53936002)(76176011)(54906003)(5660300002)(25786009)(305945005)(14454004)(7736002)(74316002)(4326008)(3846002)(102836004)(6116002)(316002)(7696005)(53546011)(33656002)(110136005)(71190400001); DIR:OUT; SFP:1101; SCL:1; SRVR:BYAPR18MB2661; H:BYAPR18MB2424.namprd18.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: Po+2zj+AgpvPJrom7KFls1hLTki5yhVq/R0BrH2FAZKEQVO9z2AwBsbhghoQQJ29WIDPn/n+PdK5TAym4VpXAMeR6izfIehug63YMv0OKpz6Uv4O2m7lubAyGcyLHP07jdUJxeHQQDc00OFheC8t33dtRGBgANzr3WRDBRINxdOF6J/czDCOIXXL4QXziIKuuTxcHMhJWAHzpNTj3weh9J3hTybqc4X4cobCKKgVzChlI4tgIhfyl7YRTtAOuQbCkWsTQ9iYEIuQPNyYbCuryqx5FDxW1HBUFyZJ9tvWj1qq6khVwmzxZty35sV5VtffKrpLWW1iCyh29YTZSFveeNby9tlA4ODVoOR5pC9wKwTZ69V1ynExxpIY9mqmNSTu3/9aTIjy+DYh3xnlFV7OOeb07ltKcnhvOhYi8dBKNvs= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 1331bf46-e3b5-4497-affb-08d6ca1d468d X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Apr 2019 08:00:40.4255 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR18MB2661 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2019-04-26_05:, , signatures=0 Subject: Re: [dpdk-dev] [PATCH] eventdev: fix control flow issues X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Apr 2019 08:00:45 -0000 > -----Original Message----- > From: dev On Behalf Of Abhinandan Gujjar > Sent: Wednesday, April 24, 2019 10:05 PM > To: jerin.jacob@caviumnetworks.com; dev@dpdk.org > Cc: narender.vangati@intel.com; abhinandan.gujjar@intel.com; > john.mcnamara@intel.com > Subject: [dpdk-dev] [PATCH] eventdev: fix control flow issues >=20 > This patch fixes null pointer dereference and control flow issues reporte= d in > event crypto adapter by coverity >=20 > Coverity issue: 279439 Dereference null return value Coverity issue: 2794= 46 > Logically dead code Coverity issue: 279450 Logically dead code Coverity i= ssue: > 279462 Logically dead code > Fixes: 7901eac3409 ("eventdev: add crypto adapter implementation") Cc: stable@dpdk.org >=20 > Signed-off-by: Abhinandan Gujjar Acked-by: Jerin Jacob From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 8A2B4A05D3 for ; Fri, 26 Apr 2019 10:00:47 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 64AF01B5F3; Fri, 26 Apr 2019 10:00:46 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by dpdk.org (Postfix) with ESMTP id 6B0041B13A for ; Fri, 26 Apr 2019 10:00:44 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x3Q7j9XQ010657; Fri, 26 Apr 2019 01:00:43 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0818; bh=SNLIhZU6ZyrTw2mDhRk0bMRoRumjLFWY9xKpBLYb4Yo=; b=gew8t/E55PzuKbsT7jBY6OYlKGtvs2io4/kRRskz3vKWb56+WVPEdHm0caMmdB8OiNIe s1SbOwZczgqSQCgXwC7xvnfuf9E3pOxcAB86oPXwSrO5NAuDnNcK2V6zrBi6b5LIRRVr N1zyB/BSBMELOQ3Ky+XkOwEOJQ1D8QsHCryVKdyLM1IrFYQmAheiGMYNQiOQBYG8GSyG eYy4m25NXtHJJBVkdIzM4qpAyZ3nZl81ho/wbomkS/ymikk8fTQ1NJ+Gzitp3Qc48fHx mfEbrkpucwPiEKCISNUXzZMkQlUBphyqKD6pqaBxIbjx8IKZ19tcA2kYtzjy2YKC7qBW kQ== Received: from sc-exch02.marvell.com ([199.233.58.182]) by mx0a-0016f401.pphosted.com with ESMTP id 2s3p6nhn7e-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Fri, 26 Apr 2019 01:00:43 -0700 Received: from SC-EXCH03.marvell.com (10.93.176.83) by SC-EXCH02.marvell.com (10.93.176.82) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Fri, 26 Apr 2019 01:00:42 -0700 Received: from NAM03-CO1-obe.outbound.protection.outlook.com (104.47.40.55) by SC-EXCH03.marvell.com (10.93.176.83) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Fri, 26 Apr 2019 01:00:42 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SNLIhZU6ZyrTw2mDhRk0bMRoRumjLFWY9xKpBLYb4Yo=; b=TOFqfU6wSp1ntEVz6xQS9no0zJANpX+4TW0RRoDaqivmQRXhx9SEyTZUN4+MQ1p/gdHPHZTG0vXdPazqgt1PQJ19Xbs7A86o3MmKjlghayt6ympBEFycrMFJJkmLexSPbcZVm+fDPs5u1EO8MYfrhUA6ayNwOf4c6A8md3nhT1g= Received: from BYAPR18MB2424.namprd18.prod.outlook.com (20.179.91.149) by BYAPR18MB2661.namprd18.prod.outlook.com (20.179.94.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1835.12; Fri, 26 Apr 2019 08:00:40 +0000 Received: from BYAPR18MB2424.namprd18.prod.outlook.com ([fe80::6dd3:c056:b23b:ab4e]) by BYAPR18MB2424.namprd18.prod.outlook.com ([fe80::6dd3:c056:b23b:ab4e%7]) with mapi id 15.20.1835.010; Fri, 26 Apr 2019 08:00:40 +0000 From: Jerin Jacob Kollanukkaran To: Abhinandan Gujjar , "jerin.jacob@caviumnetworks.com" , "dev@dpdk.org" CC: "narender.vangati@intel.com" , "john.mcnamara@intel.com" Thread-Topic: [dpdk-dev] [PATCH] eventdev: fix control flow issues Thread-Index: AQHU+0bdpVVhH8v1OUGu1aokL3sUgKZOFDMw Date: Fri, 26 Apr 2019 08:00:40 +0000 Message-ID: References: <1556123678-80860-1-git-send-email-abhinandan.gujjar@intel.com> In-Reply-To: <1556123678-80860-1-git-send-email-abhinandan.gujjar@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [116.68.105.17] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 1331bf46-e3b5-4497-affb-08d6ca1d468d x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(5600141)(711020)(4605104)(2017052603328)(7193020); SRVR:BYAPR18MB2661; x-ms-traffictypediagnostic: BYAPR18MB2661: x-microsoft-antispam-prvs: x-forefront-prvs: 001968DD50 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(346002)(39860400002)(366004)(396003)(136003)(376002)(13464003)(199004)(189003)(81156014)(66556008)(66946007)(2501003)(11346002)(97736004)(66476007)(26005)(86362001)(2201001)(6246003)(8676002)(229853002)(66066001)(186003)(68736007)(446003)(4744005)(64756008)(2906002)(73956011)(81166006)(76116006)(476003)(6436002)(486006)(8936002)(256004)(52536014)(6506007)(55016002)(71200400001)(9686003)(478600001)(55236004)(99286004)(66446008)(53936002)(76176011)(54906003)(5660300002)(25786009)(305945005)(14454004)(7736002)(74316002)(4326008)(3846002)(102836004)(6116002)(316002)(7696005)(53546011)(33656002)(110136005)(71190400001); DIR:OUT; SFP:1101; SCL:1; SRVR:BYAPR18MB2661; H:BYAPR18MB2424.namprd18.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: Po+2zj+AgpvPJrom7KFls1hLTki5yhVq/R0BrH2FAZKEQVO9z2AwBsbhghoQQJ29WIDPn/n+PdK5TAym4VpXAMeR6izfIehug63YMv0OKpz6Uv4O2m7lubAyGcyLHP07jdUJxeHQQDc00OFheC8t33dtRGBgANzr3WRDBRINxdOF6J/czDCOIXXL4QXziIKuuTxcHMhJWAHzpNTj3weh9J3hTybqc4X4cobCKKgVzChlI4tgIhfyl7YRTtAOuQbCkWsTQ9iYEIuQPNyYbCuryqx5FDxW1HBUFyZJ9tvWj1qq6khVwmzxZty35sV5VtffKrpLWW1iCyh29YTZSFveeNby9tlA4ODVoOR5pC9wKwTZ69V1ynExxpIY9mqmNSTu3/9aTIjy+DYh3xnlFV7OOeb07ltKcnhvOhYi8dBKNvs= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 1331bf46-e3b5-4497-affb-08d6ca1d468d X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Apr 2019 08:00:40.4255 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR18MB2661 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2019-04-26_05:, , signatures=0 Subject: Re: [dpdk-dev] [PATCH] eventdev: fix control flow issues X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190426080040.nC4ecoDi5PgLAx1nFen6qdxtupV_nriJlm44pyxPtLk@z> > -----Original Message----- > From: dev On Behalf Of Abhinandan Gujjar > Sent: Wednesday, April 24, 2019 10:05 PM > To: jerin.jacob@caviumnetworks.com; dev@dpdk.org > Cc: narender.vangati@intel.com; abhinandan.gujjar@intel.com; > john.mcnamara@intel.com > Subject: [dpdk-dev] [PATCH] eventdev: fix control flow issues >=20 > This patch fixes null pointer dereference and control flow issues reporte= d in > event crypto adapter by coverity >=20 > Coverity issue: 279439 Dereference null return value Coverity issue: 2794= 46 > Logically dead code Coverity issue: 279450 Logically dead code Coverity i= ssue: > 279462 Logically dead code > Fixes: 7901eac3409 ("eventdev: add crypto adapter implementation") Cc: stable@dpdk.org >=20 > Signed-off-by: Abhinandan Gujjar Acked-by: Jerin Jacob