From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by dpdk.org (Postfix) with ESMTP id 5D5E42BA2 for ; Tue, 30 Apr 2019 19:08:51 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x3UH4vOe023339; Tue, 30 Apr 2019 10:08:50 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0818; bh=k35M4jUSycs7LGz2c/Kk7C8LgYlyrUh4EbSpb2iLyPA=; b=PvTmwoJJ4y1rjATPAwvcujUrJL/CYtjvuRMvZSheE+SbWzDvSYAjROsNV//st9Y3JQlB gcUhLEhZ/UZSyqW3qbJbEiPN851Bc6XjgfPSPd1iI+nkVBzxxYyB+J3+PVkwFTKaRADj 1/qgSQU6LDalP0G1+NYK730/FAVMuB/oBb5ND5G+52oKFOYvoay0zQQ965oWCw3cbO+C FWEtvB0LnDAYVQ7wVOhLJON6aSSR6JOe9JEuLDLqrIBUCkau30oJG8o9JRKtuxXIt0y+ WOV9dkDDaLIw/zFMrXUWuie+IMb/Sx/eV2gPYu3TxxZna27p42oovDOS8d9IPQLpxgAr nA== Received: from sc-exch02.marvell.com ([199.233.58.182]) by mx0a-0016f401.pphosted.com with ESMTP id 2s6jbcswkn-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Tue, 30 Apr 2019 10:08:50 -0700 Received: from SC-EXCH03.marvell.com (10.93.176.83) by SC-EXCH02.marvell.com (10.93.176.82) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Tue, 30 Apr 2019 10:08:49 -0700 Received: from NAM02-BL2-obe.outbound.protection.outlook.com (104.47.38.53) by SC-EXCH03.marvell.com (10.93.176.83) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Tue, 30 Apr 2019 10:08:49 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=k35M4jUSycs7LGz2c/Kk7C8LgYlyrUh4EbSpb2iLyPA=; b=CsrNJP/x3hMucz4YsD1LhfyN8IodrQDhhYqFBXG8/svPIvy9FrQH1go/kJc/AOi9aN0XrxS6vnTUX6HeRWfkXfZ2teRZQ7JSKOLODwzRmLf4OF/a/LnONuiF+KVwmLNxLAY/wIn0QGNnapqFz6FFfWeBDWn9x8EVjblbj2voMo0= Received: from BYAPR18MB2424.namprd18.prod.outlook.com (20.179.91.149) by BYAPR18MB2582.namprd18.prod.outlook.com (20.179.93.211) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1835.15; Tue, 30 Apr 2019 17:08:44 +0000 Received: from BYAPR18MB2424.namprd18.prod.outlook.com ([fe80::6dd3:c056:b23b:ab4e]) by BYAPR18MB2424.namprd18.prod.outlook.com ([fe80::6dd3:c056:b23b:ab4e%7]) with mapi id 15.20.1835.018; Tue, 30 Apr 2019 17:08:44 +0000 From: Jerin Jacob Kollanukkaran To: "Mcnamara, John" , "Gujjar, Abhinandan S" , "dev@dpdk.org" , "Jerin Jacob Kollanukkaran" , "thomas@monjalon.net" CC: "Vangati, Narender" Thread-Topic: [dpdk-dev] [PATCH] eventdev: fix control flow issues Thread-Index: AQHU+0bdpVVhH8v1OUGu1aokL3sUgKZOFDMwgAZnuoCAAHuzoA== Date: Tue, 30 Apr 2019 17:08:44 +0000 Message-ID: References: <1556123678-80860-1-git-send-email-abhinandan.gujjar@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [106.208.46.39] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 3ad1fbcf-f463-4e87-3087-08d6cd8e80be x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600141)(711020)(4605104)(2017052603328)(7193020); SRVR:BYAPR18MB2582; x-ms-traffictypediagnostic: BYAPR18MB2582: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:3173; x-forefront-prvs: 00235A1EEF x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(39860400002)(366004)(346002)(396003)(376002)(136003)(13464003)(189003)(199004)(26005)(486006)(71200400001)(6116002)(81166006)(3846002)(476003)(33656002)(8936002)(305945005)(7736002)(78486014)(6246003)(81156014)(52536014)(25786009)(53546011)(446003)(64756008)(6506007)(6436002)(66446008)(8676002)(76116006)(102836004)(55016002)(66946007)(66476007)(66556008)(73956011)(316002)(11346002)(110136005)(74316002)(71190400001)(76176011)(4744005)(229853002)(2906002)(4326008)(186003)(99286004)(9686003)(5660300002)(14454004)(97736004)(14444005)(256004)(86362001)(2501003)(7696005)(66066001)(478600001)(68736007)(53936002); DIR:OUT; SFP:1101; SCL:1; SRVR:BYAPR18MB2582; H:BYAPR18MB2424.namprd18.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: qs3Y4ar6D/EBMWCWbzXPmTBz8fzUbx0LG6sPFMFkqZ57idLJMRNci6vtCIvBuI+uHX7gpWNLhgYW93ZIRFggeAbTeju/QjWgPT9q4491rNH1ryd2CVlgE8Lje7n6wZBbaV810BUr3ozPnMlZPqs3c+1j51URhQ6kRAdiF5LrvmSRNSFcRhTeEpL+3mK1Wf/HMgPfLbpcG14cKTB48daW9nmOaDGe+q+4p3Nnjm1Y4BfD7jm8ONE+T1N9NyysHveQozPKbpzEG8XGlwUjDg0o/TbcKK1ayyy8oph+9ESUWWWHlsvck8vFM2ybYf6Lb0EeN1BxhR2M90bkjffd0kSUmiGZ9zcXhxC4fM7xDKp4iw3k9wsas7eE3Xu2+T2UBc8d7OF1B18jQyrHuQjRzLIVcnziSjT1OVLRLpj+0i0FXN4= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 3ad1fbcf-f463-4e87-3087-08d6cd8e80be X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Apr 2019 17:08:44.7000 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR18MB2582 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2019-04-30_08:, , signatures=0 Subject: Re: [dpdk-dev] [PATCH] eventdev: fix control flow issues X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 Apr 2019 17:08:51 -0000 > -----Original Message----- > From: Mcnamara, John > Sent: Tuesday, April 30, 2019 3:14 PM > To: Jerin Jacob Kollanukkaran ; Gujjar, Abhinandan S > ; jerin.jacob@caviumnetworks.com; > dev@dpdk.org > Cc: Vangati, Narender > Subject: [EXT] RE: [dpdk-dev] [PATCH] eventdev: fix control flow issues > > > Coverity issue: 279439 Dereference null return value Coverity issue: > > > 279446 Logically dead code Coverity issue: 279450 Logically dead code > > Coverity issue: > > > 279462 Logically dead code > > > Fixes: 7901eac3409 ("eventdev: add crypto adapter implementation") > > > > Cc: stable@dpdk.org > > > > > > > > Signed-off-by: Abhinandan Gujjar > > > > Acked-by: Jerin Jacob >=20 > Hi Jerin, >=20 > Can you apply this patch for RC3. It potentially fixes 4 coverity defcts. Thomas, Could you merge this patch to avoid creating pull request for one patch. >=20 > Thanks, >=20 > John >=20 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id F1181A0679 for ; Tue, 30 Apr 2019 19:08:53 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D46134C95; Tue, 30 Apr 2019 19:08:52 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by dpdk.org (Postfix) with ESMTP id 5D5E42BA2 for ; Tue, 30 Apr 2019 19:08:51 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x3UH4vOe023339; Tue, 30 Apr 2019 10:08:50 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0818; bh=k35M4jUSycs7LGz2c/Kk7C8LgYlyrUh4EbSpb2iLyPA=; b=PvTmwoJJ4y1rjATPAwvcujUrJL/CYtjvuRMvZSheE+SbWzDvSYAjROsNV//st9Y3JQlB gcUhLEhZ/UZSyqW3qbJbEiPN851Bc6XjgfPSPd1iI+nkVBzxxYyB+J3+PVkwFTKaRADj 1/qgSQU6LDalP0G1+NYK730/FAVMuB/oBb5ND5G+52oKFOYvoay0zQQ965oWCw3cbO+C FWEtvB0LnDAYVQ7wVOhLJON6aSSR6JOe9JEuLDLqrIBUCkau30oJG8o9JRKtuxXIt0y+ WOV9dkDDaLIw/zFMrXUWuie+IMb/Sx/eV2gPYu3TxxZna27p42oovDOS8d9IPQLpxgAr nA== Received: from sc-exch02.marvell.com ([199.233.58.182]) by mx0a-0016f401.pphosted.com with ESMTP id 2s6jbcswkn-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Tue, 30 Apr 2019 10:08:50 -0700 Received: from SC-EXCH03.marvell.com (10.93.176.83) by SC-EXCH02.marvell.com (10.93.176.82) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Tue, 30 Apr 2019 10:08:49 -0700 Received: from NAM02-BL2-obe.outbound.protection.outlook.com (104.47.38.53) by SC-EXCH03.marvell.com (10.93.176.83) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Tue, 30 Apr 2019 10:08:49 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=k35M4jUSycs7LGz2c/Kk7C8LgYlyrUh4EbSpb2iLyPA=; b=CsrNJP/x3hMucz4YsD1LhfyN8IodrQDhhYqFBXG8/svPIvy9FrQH1go/kJc/AOi9aN0XrxS6vnTUX6HeRWfkXfZ2teRZQ7JSKOLODwzRmLf4OF/a/LnONuiF+KVwmLNxLAY/wIn0QGNnapqFz6FFfWeBDWn9x8EVjblbj2voMo0= Received: from BYAPR18MB2424.namprd18.prod.outlook.com (20.179.91.149) by BYAPR18MB2582.namprd18.prod.outlook.com (20.179.93.211) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1835.15; Tue, 30 Apr 2019 17:08:44 +0000 Received: from BYAPR18MB2424.namprd18.prod.outlook.com ([fe80::6dd3:c056:b23b:ab4e]) by BYAPR18MB2424.namprd18.prod.outlook.com ([fe80::6dd3:c056:b23b:ab4e%7]) with mapi id 15.20.1835.018; Tue, 30 Apr 2019 17:08:44 +0000 From: Jerin Jacob Kollanukkaran To: "Mcnamara, John" , "Gujjar, Abhinandan S" , "dev@dpdk.org" , "Jerin Jacob Kollanukkaran" , "thomas@monjalon.net" CC: "Vangati, Narender" Thread-Topic: [dpdk-dev] [PATCH] eventdev: fix control flow issues Thread-Index: AQHU+0bdpVVhH8v1OUGu1aokL3sUgKZOFDMwgAZnuoCAAHuzoA== Date: Tue, 30 Apr 2019 17:08:44 +0000 Message-ID: References: <1556123678-80860-1-git-send-email-abhinandan.gujjar@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [106.208.46.39] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 3ad1fbcf-f463-4e87-3087-08d6cd8e80be x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600141)(711020)(4605104)(2017052603328)(7193020); SRVR:BYAPR18MB2582; x-ms-traffictypediagnostic: BYAPR18MB2582: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:3173; x-forefront-prvs: 00235A1EEF x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(39860400002)(366004)(346002)(396003)(376002)(136003)(13464003)(189003)(199004)(26005)(486006)(71200400001)(6116002)(81166006)(3846002)(476003)(33656002)(8936002)(305945005)(7736002)(78486014)(6246003)(81156014)(52536014)(25786009)(53546011)(446003)(64756008)(6506007)(6436002)(66446008)(8676002)(76116006)(102836004)(55016002)(66946007)(66476007)(66556008)(73956011)(316002)(11346002)(110136005)(74316002)(71190400001)(76176011)(4744005)(229853002)(2906002)(4326008)(186003)(99286004)(9686003)(5660300002)(14454004)(97736004)(14444005)(256004)(86362001)(2501003)(7696005)(66066001)(478600001)(68736007)(53936002); DIR:OUT; SFP:1101; SCL:1; SRVR:BYAPR18MB2582; H:BYAPR18MB2424.namprd18.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: qs3Y4ar6D/EBMWCWbzXPmTBz8fzUbx0LG6sPFMFkqZ57idLJMRNci6vtCIvBuI+uHX7gpWNLhgYW93ZIRFggeAbTeju/QjWgPT9q4491rNH1ryd2CVlgE8Lje7n6wZBbaV810BUr3ozPnMlZPqs3c+1j51URhQ6kRAdiF5LrvmSRNSFcRhTeEpL+3mK1Wf/HMgPfLbpcG14cKTB48daW9nmOaDGe+q+4p3Nnjm1Y4BfD7jm8ONE+T1N9NyysHveQozPKbpzEG8XGlwUjDg0o/TbcKK1ayyy8oph+9ESUWWWHlsvck8vFM2ybYf6Lb0EeN1BxhR2M90bkjffd0kSUmiGZ9zcXhxC4fM7xDKp4iw3k9wsas7eE3Xu2+T2UBc8d7OF1B18jQyrHuQjRzLIVcnziSjT1OVLRLpj+0i0FXN4= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 3ad1fbcf-f463-4e87-3087-08d6cd8e80be X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Apr 2019 17:08:44.7000 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR18MB2582 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2019-04-30_08:, , signatures=0 Subject: Re: [dpdk-dev] [PATCH] eventdev: fix control flow issues X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190430170844.NA_xYgWanmFbxOw4RRO3pVIJfJStBADbQjE1I9-UDUc@z> > -----Original Message----- > From: Mcnamara, John > Sent: Tuesday, April 30, 2019 3:14 PM > To: Jerin Jacob Kollanukkaran ; Gujjar, Abhinandan S > ; jerin.jacob@caviumnetworks.com; > dev@dpdk.org > Cc: Vangati, Narender > Subject: [EXT] RE: [dpdk-dev] [PATCH] eventdev: fix control flow issues > > > Coverity issue: 279439 Dereference null return value Coverity issue: > > > 279446 Logically dead code Coverity issue: 279450 Logically dead code > > Coverity issue: > > > 279462 Logically dead code > > > Fixes: 7901eac3409 ("eventdev: add crypto adapter implementation") > > > > Cc: stable@dpdk.org > > > > > > > > Signed-off-by: Abhinandan Gujjar > > > > Acked-by: Jerin Jacob >=20 > Hi Jerin, >=20 > Can you apply this patch for RC3. It potentially fixes 4 coverity defcts. Thomas, Could you merge this patch to avoid creating pull request for one patch. >=20 > Thanks, >=20 > John >=20