Re: [dpdk-dev] [PATCH 34/44] event/octeontx2: allow adapters to resize inflight buffers

[Jerin Jacob Kollanukkaran <jerinj@marvell.com>]

> -----Original Message-----
> From: pbhagavatula@marvell.com <pbhagavatula@marvell.com>
> Sent: Sunday, June 2, 2019 12:24 AM
> To: Jerin Jacob Kollanukkaran <jerinj@marvell.com>; Pavan Nikhilesh
> Bhagavatula <pbhagavatula@marvell.com>
> Cc: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH 34/44] event/octeontx2: allow adapters to resize
> inflight buffers
> 
> From: Pavan Nikhilesh <pbhagavatula@marvell.com>
> 
> Add internal SSO functions to allow event adapters to resize SSO buffers that are
> used to hold in-flight events in DRAM.
> 
> Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
> ---
>  drivers/event/octeontx2/Makefile           |  1 +
>  drivers/event/octeontx2/meson.build        |  1 +
>  drivers/event/octeontx2/otx2_evdev.c       | 31 ++++++++++++++++++++++
>  drivers/event/octeontx2/otx2_evdev.h       |  5 ++++
>  drivers/event/octeontx2/otx2_evdev_adptr.c | 19 +++++++++++++
>  drivers/event/octeontx2/otx2_tim_evdev.c   |  5 ++++
>  6 files changed, 62 insertions(+)
>  create mode 100644 drivers/event/octeontx2/otx2_evdev_adptr.c
> 
> diff --git a/drivers/event/octeontx2/Makefile
> b/drivers/event/octeontx2/Makefile
> index 2290622dd..6f8d9fe2f 100644
> --- a/drivers/event/octeontx2/Makefile
> +++ b/drivers/event/octeontx2/Makefile
> @@ -33,6 +33,7 @@ LIBABIVER := 1
>  SRCS-$(CONFIG_RTE_LIBRTE_PMD_OCTEONTX2_EVENTDEV) +=
> otx2_worker_dual.c
>  SRCS-$(CONFIG_RTE_LIBRTE_PMD_OCTEONTX2_EVENTDEV) += otx2_worker.c
>  SRCS-$(CONFIG_RTE_LIBRTE_PMD_OCTEONTX2_EVENTDEV) += otx2_evdev.c
> +SRCS-$(CONFIG_RTE_LIBRTE_PMD_OCTEONTX2_EVENTDEV) +=
> otx2_evdev_adptr.c
>  SRCS-$(CONFIG_RTE_LIBRTE_PMD_OCTEONTX2_EVENTDEV) +=
> otx2_tim_evdev.c
>  SRCS-$(CONFIG_RTE_LIBRTE_PMD_OCTEONTX2_EVENTDEV) +=
> otx2_evdev_selftest.c
>  SRCS-$(CONFIG_RTE_LIBRTE_PMD_OCTEONTX2_EVENTDEV) +=
> otx2_evdev_irq.c diff --git a/drivers/event/octeontx2/meson.build
> b/drivers/event/octeontx2/meson.build
> index ad7f2e084..c709b5e69 100644
> --- a/drivers/event/octeontx2/meson.build
> +++ b/drivers/event/octeontx2/meson.build
> @@ -5,6 +5,7 @@
>  sources = files('otx2_worker.c',
>  		'otx2_worker_dual.c',
>  		'otx2_evdev.c',
> +		'otx2_evdev_adptr.c',
>  		'otx2_evdev_irq.c',
>  		'otx2_evdev_selftest.c',
>  		'otx2_tim_evdev.c',
> diff --git a/drivers/event/octeontx2/otx2_evdev.c
> b/drivers/event/octeontx2/otx2_evdev.c
> index 86b9fee97..534ac4a6b 100644
> --- a/drivers/event/octeontx2/otx2_evdev.c
> +++ b/drivers/event/octeontx2/otx2_evdev.c
> @@ -529,6 +529,9 @@ sso_xaq_allocate(struct otx2_sso_evdev *dev)
>  	xaq_cnt = dev->nb_event_queues * OTX2_SSO_XAQ_CACHE_CNT;
>  	if (dev->xae_cnt)
>  		xaq_cnt += dev->xae_cnt / dev->xae_waes;
> +	else if (dev->adptr_xae_cnt)
> +		xaq_cnt += (dev->adptr_xae_cnt / dev->xae_waes) +
> +			(OTX2_SSO_XAQ_SLACK * dev->nb_event_queues);
>  	else
>  		xaq_cnt += (dev->iue / dev->xae_waes) +
>  			(OTX2_SSO_XAQ_SLACK * dev->nb_event_queues); @@
> -1025,6 +1028,34 @@ sso_cleanup(struct rte_eventdev *event_dev, uint8_t
> enable)
>  	otx2_mbox_process(dev->mbox);
>  }
> 
> +int
> +sso_xae_reconfigure(struct rte_eventdev *event_dev) {
> +	struct otx2_sso_evdev *dev = sso_pmd_priv(event_dev);
> +	struct rte_mempool *prev_xaq_pool;
> +	int rc = 0;
> +
> +	if (event_dev->data->dev_started)
> +		sso_cleanup(event_dev, 0);
> +
> +	prev_xaq_pool = dev->xaq_pool;
> +	dev->xaq_pool = NULL;
> +	sso_xaq_allocate(dev);
> +	rc = sso_ggrp_alloc_xaq(dev);
> +	if (rc < 0) {
> +		otx2_err("failed to alloc xaq to ggrp %d", rc);

s/failed/Failed to maintain the consistency across the driver.