DPDK patches and discussions
 help / color / mirror / Atom feed
From: Jerin Jacob Kollanukkaran <jerinj@marvell.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [EXT] [PATCH] net/octeontx: use logtype_init for failed probe
Date: Fri, 19 Jul 2019 03:37:26 +0000	[thread overview]
Message-ID: <BYAPR18MB2424382DC2A8450216CD2D74C8CB0@BYAPR18MB2424.namprd18.prod.outlook.com> (raw)
In-Reply-To: <20190716114730.4b928469@hermes.lan>



> -----Original Message-----
> From: Stephen Hemminger <stephen@networkplumber.org>
> Sent: Wednesday, July 17, 2019 12:18 AM
> To: Jerin Jacob Kollanukkaran <jerinj@marvell.com>
> Cc: dev@dpdk.org
> Subject: [EXT] [PATCH] net/octeontx: use logtype_init for failed probe

> All log messages should use driver logtype. RTE_LOGTYPE_PMD is planned to
> be deprecated in the future.
> 
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---

Please fix

$ ./devtools/check-git-log.sh
Wrong headline format:
        net/octeontx: use logtype_init for failed probe
		
		

>  drivers/net/octeontx/octeontx_ethdev.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/octeontx/octeontx_ethdev.c
> b/drivers/net/octeontx/octeontx_ethdev.c
> index 1b853399dfe4..27eed47bb0cb 100644
> --- a/drivers/net/octeontx/octeontx_ethdev.c
> +++ b/drivers/net/octeontx/octeontx_ethdev.c
> @@ -1175,7 +1175,7 @@ octeontx_probe(struct rte_vdev_device *dev)
>  	    strlen(rte_vdev_device_args(dev)) == 0) {
>  		eth_dev = rte_eth_dev_attach_secondary(dev_name);
>  		if (!eth_dev) {
> -			RTE_LOG(ERR, PMD, "Failed to probe %s\n",
> dev_name);
> +			PMD_INIT_LOG(ERR, "Failed to probe %s",
> dev_name);
>  			return -1;
>  		}
>  		/* TODO: request info from primary to set up Rx and Tx */
> --
> 2.20.1


  reply	other threads:[~2019-07-19  3:37 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-16 18:47 [dpdk-dev] " Stephen Hemminger
2019-07-19  3:37 ` Jerin Jacob Kollanukkaran [this message]
2019-07-19 16:59   ` [dpdk-dev] [EXT] " Stephen Hemminger
2019-07-22  8:05     ` Jerin Jacob Kollanukkaran

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BYAPR18MB2424382DC2A8450216CD2D74C8CB0@BYAPR18MB2424.namprd18.prod.outlook.com \
    --to=jerinj@marvell.com \
    --cc=dev@dpdk.org \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).