From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 37C10A04A4; Wed, 27 May 2020 11:28:56 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id BBB351D58A; Wed, 27 May 2020 11:28:55 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by dpdk.org (Postfix) with ESMTP id F14481D57C; Wed, 27 May 2020 11:28:53 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 04R9HOcY017209; Wed, 27 May 2020 02:28:52 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : content-type : content-transfer-encoding : mime-version; s=pfpt0818; bh=h9T0RRKPvSuvjgL/8jh9t/Sumh7JaGQp3Rj0P6mriXY=; b=plkX4xtNNI2M80qj8DvibU3gEZ28vMG7xCf2j1A8PKRpScbkLTJkyj8UD/4kJozyphvP qKNc7jV56GwALEiRBwRNzCWfvNWQRwrFmCbtFHHE4BtujmafASr3Ho5FBwXYldRvFLRF yTwKoxRf87AOheR7XKdm1/PXvcNLibONQRdxaU4LFRWRTrKaeRaXwL9Von8B/ElOvV5T tsWK2ESQVhc/1J9+4lefSIJmX8uveBH6oVCzxIz0JskntJKFjSejxiehCbXEUocpyD7j 6mLxUcBk5n8onbe9FW1FkRjdjx4tbWkEGfJ33UgXq/Zzb6L+MYbOpoNylkZRzLShzZJP fg== Received: from sc-exch03.marvell.com ([199.233.58.183]) by mx0b-0016f401.pphosted.com with ESMTP id 3173bnvgbp-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Wed, 27 May 2020 02:28:52 -0700 Received: from DC5-EXCH01.marvell.com (10.69.176.38) by SC-EXCH03.marvell.com (10.93.176.83) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 27 May 2020 02:28:50 -0700 Received: from SC-EXCH03.marvell.com (10.93.176.83) by DC5-EXCH01.marvell.com (10.69.176.38) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 27 May 2020 02:28:50 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.102) by SC-EXCH03.marvell.com (10.93.176.83) with Microsoft SMTP Server (TLS) id 15.0.1497.2 via Frontend Transport; Wed, 27 May 2020 02:28:49 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dnukqRmbRCHQPsEKTYQi/anT+HgCp8DgQDpCy28TEBb0Q7XccEpJLSpdq2/TedXnPBZQ5dxdMQuPwIYDpaiMvgC8zS2tM7ifgFPSVaJW9Bb96Q5jz6w9sHs1HJCKwoolWOMXqeGB0Mh9e7kZudJjqnUFt23T37wMnI30DLlXmI4TMSLScb7oPt544ir5/b3u8GQPvYQdWvUPqatRVR7DWSP22Jcbayo3YfXjpe1qFvwSgirGwdYxFBOhq1UhAqlMhQLQZA1cn3XvzCK5w7bAOKgHa84PfKbtzqjrqpiI0XmL4LZB37R/3XJTms2Cn6LiKz5cV54P25a6Rh/Pm+wV3w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=h9T0RRKPvSuvjgL/8jh9t/Sumh7JaGQp3Rj0P6mriXY=; b=egmNk6NZEPpqq/mZU2VZ1lZR9U1cSr94BIzSVjMEy+H62bqg304jnivP8jnIL00MP48gPZeS+sQ0ZKH5CfVDDqbM5fPLA6EYDpBzaPMQwTFDZVsivl9iC3I25HwkUVRLakWRl/K2SxdFzY/eisA+A8BEFlL5xf1PCDdyuwJ55mjKYKpf2yiml/plIv+KoymnWxJLzS/vS8gSdvLeyawp9Yg28hvNeyF+tRx/pYQNbXkFMeK2nj+wVpS5CAToc3j7/LJPaRsJDFBVNtvq8tyUCsoTGywOl2cVXTB0Vo4u6H9wcBCoKZsza/z2+T4xCFNuGqeBO9PfqzBtLSNKUCQ1og== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=h9T0RRKPvSuvjgL/8jh9t/Sumh7JaGQp3Rj0P6mriXY=; b=c9Is/mFkC/qPbS1zjt5izCKgyGk5UoEDShz6cMQGD4H9w2BQNI1mIRA0XqnUPY8R3YnNtp5IUEvFGpZVxUcFX7oQjnI83pBxNo+/hLJjlYX5cmlI3Rh4cHExN6oEf6OeWFoGZXhEH93tNLPgcWn2XVlJqZemn3dNh0IJrhuBoyE= Received: from BYAPR18MB2424.namprd18.prod.outlook.com (2603:10b6:a03:130::21) by BYAPR18MB2437.namprd18.prod.outlook.com (2603:10b6:a03:13c::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3021.24; Wed, 27 May 2020 09:28:48 +0000 Received: from BYAPR18MB2424.namprd18.prod.outlook.com ([fe80::659e:abff:6625:aafe]) by BYAPR18MB2424.namprd18.prod.outlook.com ([fe80::659e:abff:6625:aafe%3]) with mapi id 15.20.3021.030; Wed, 27 May 2020 09:28:48 +0000 From: Jerin Kollanukkaran To: dpdk-dev , Thomas Monjalon , "david.marchand@redhat.com" , "Yigit, Ferruh" , Maxime Coquelin , "cristian.dumitrescu@intel.com" , "akhil.goyal@nxp.com" , "rasland@mellanox.com" , "xiaolong.ye@intel.com" , "ajit.khaparde@broadcom.com" , "arybchenko@solarflare.com" , "Burakov, Anatoly" CC: "techboard@dpdk.org" Thread-Topic: Suggestion to improve the code review Thread-Index: AdY0CQjTprYkbH8URKyXgGNjOzP7JA== Date: Wed, 27 May 2020 09:28:47 +0000 Message-ID: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dpdk.org; dkim=none (message not signed) header.d=none;dpdk.org; dmarc=none action=none header.from=marvell.com; x-originating-ip: [122.181.200.207] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: f13ee102-f4dd-464a-cfc2-08d802205c15 x-ms-traffictypediagnostic: BYAPR18MB2437: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8273; x-forefront-prvs: 04163EF38A x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Wf/LMClMFLh57QDh0oU85mHQwt+L7Emq9wDm1SQMdyem/8fN+2stmSEIeFE/1uGSRKdrAeScnxsedmMgMT416UFvuezFiHhcKVi5HpTvNQjsElQdMJDq+U340k3fvZgQQMKK3PWuyt27LIu970Pt1cZYGwdT6eIS4APw1dJgmB56nRX9y7QoLA3pU5/4TjNq9VhQEDNySER0MoFvIUvzzbQFK9iG2dGmZsqFJ4m+DE2xn8M2GOlcp5HjOePXxnB/6j1xNtOBzDSwMyof0SqZDJ9JIATVjwSWJA0f2VFs2S+bv6AztWCJRXAo6cA85Svo6z7qPY+MqBMZ3npfrpoKS6t5W8LJsRLnQLKcfbjwRif1eRhsxomeNqX8l6tpnZ3lvmwJ82tXKITvcXu6xGyG/gvzJRitmUbHkfryURgD0NG101MM03DosF8Z2sQJlBun x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR18MB2424.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(366004)(39850400004)(396003)(346002)(376002)(136003)(9686003)(71200400001)(4326008)(5660300002)(55016002)(6506007)(110136005)(66556008)(86362001)(66946007)(52536014)(66476007)(966005)(26005)(33656002)(76116006)(7696005)(186003)(8936002)(478600001)(316002)(66446008)(64756008)(7416002)(8676002)(83380400001)(2906002)(921003); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: 8s5THFwtFWcQexLiWRLS4ihLnc5nipCj6qTtEt8ieW0Ktj3nQPGOTCPfjcZSLMzvWtz5wzWr4IN76HAFP2kEm+nxARP4yf4BYmNEJRBMHej1GuZwJfvFFgrC6YeOkuQ6fjGTCsjJbQOlQczJIW2h8Bt/eLHbHLuoJyV9YlUzW28uT5hjYpywLcY5Qcd5OGsCZ/7qNeqsC+EJ5PYtMD1jFxiV3PBd9RFzctHy2Q8XMgQ4QS4zZwVkuYHdm5cHRVkeXM3gikkqr2TzDYBNrugzWpLxORM3aqzbLuZAyFJxWDSEIm4Q8rP7dWEOMeaqiN3TeYzOhXaDpQTQvTFvWSFbMzpYxWeJlZyzFM0ucejQXUqGGBjfF2RIuireukkTzlSbJnFvfN48ezbWCbIgdYxV6CJgkL/+Ray3R0tE98aruRM30yC80OSLIF88Am84mW7+Dnp0xiWLrxrRIZmTCU0AIhrSHkJ7BkpUqbsO81cmpdt04KIkLQyvCNEP5Pb2w+wB x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: f13ee102-f4dd-464a-cfc2-08d802205c15 X-MS-Exchange-CrossTenant-originalarrivaltime: 27 May 2020 09:28:47.8958 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: fia3fZUZrgjEKASKax02JmQTWvCx7myN+OyHxzWlnV9lNqK1S2S9DLVuGwnBHoiu5I8Fg+leUPr/YH44Q7G3yA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR18MB2437 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.216, 18.0.687 definitions=2020-05-27_03:2020-05-26, 2020-05-27 signatures=0 Subject: [dpdk-dev] Suggestion to improve the code review X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" I think, original discussion[1] on this topic got lost in GitHub vs current= workflow. I would like to propose GitHub "CODEOWNERS"[2] _LIKE_ scheme for DPDK workf= low. Current scheme: - When we submit a patch to ml, someone(Tree maintainer[3]) needs to manual= ly delegate the patch to Tree maintainer in patchwork. - Tree maintainer is not responsible for the review of the patch but only r= esponsible for merging _after_ the review. That brings the obvious question on review = responsibility.=20 Proposed scheme: - In order to improve review ownership, IMO, it is better the CI tools dele= gate the patch to the actual maintainer(who is responsible for specific code in = MAINTAINERS file) - I believe, it provides a sense of ownership, avoids last-minute surprise = on review responsibility and improve review traceability. Implementation of the proposed scheme: GitHub provides a bot for CODEOWNERS integration, Similar alternative is po= ssible with patchwork with "auto delegation scheme" using the flowing methods: a) https://patchwork.readthedocs.io/en/latest/usage/delegation/ b) https://patchwork.readthedocs.io/en/latest/usage/headers/ I think, option (a) would be relatively easy to change without introducing = the new tools. Thoughts? [1] http://mails.dpdk.org/archives/dev/2020-May/168740.html [2] https://github.com/zephyrproject-rtos/zephyr/blob/master/CODEOWNERS [3] https://patchwork.dpdk.org/project/dpdk/