From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 5AA79A05D3 for ; Thu, 23 May 2019 15:10:46 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2C3635689; Thu, 23 May 2019 15:10:45 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by dpdk.org (Postfix) with ESMTP id DFA294F91 for ; Thu, 23 May 2019 15:10:42 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x4ND7DSl003752; Thu, 23 May 2019 06:10:42 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0818; bh=7r+52TX3mwL9rar4hoPC5Id2mDuTGHJdP9oKPdaGB0I=; b=UtBR2mmFfTNk+hH7ARb7fdJS0zl6fQFUfHrlnH9kA250wD4l/i7kZ3QW2ZJ9FaGEd7b7 EKWbbvM3roMX5wOGV+xzSNtrdJ0L7KZ8ZZi2duMPNxHXh5IdXeH7zrQlHMkZtKT81J5P XvidYohQ8LNx5OtRw9sM4TZpCOpkLnwTuYanWwtZXvZAZYpHVteNsTSoV7KBl+DU4WWL UA8qQe1j8A2CJNghZab7FhsJEr+ikXN1VM3YIrVEqdt5QxWAFO3h8qqfwLAS9rxc8/S6 ukzOxkVrE9j2IGnCtVFwN1Ffhy0cxK7HtR8QjP2qzTUA16ENgXLdr8RGQhLdLhHH3rB9 dQ== Received: from sc-exch01.marvell.com ([199.233.58.181]) by mx0a-0016f401.pphosted.com with ESMTP id 2snv44r0qe-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Thu, 23 May 2019 06:10:41 -0700 Received: from SC-EXCH04.marvell.com (10.93.176.84) by SC-EXCH01.marvell.com (10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Thu, 23 May 2019 06:10:41 -0700 Received: from NAM03-CO1-obe.outbound.protection.outlook.com (104.47.40.59) by SC-EXCH04.marvell.com (10.93.176.84) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Thu, 23 May 2019 06:10:41 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector2-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7r+52TX3mwL9rar4hoPC5Id2mDuTGHJdP9oKPdaGB0I=; b=pdY4LneSNwtSDZ1K1tEqMepB2MfNndCjlwrDJ99g8wQRCuTmdbQkiHKjA1/+QM3qCkKqY7CyHpj6ZXP5w1zCcWrj7oOhmCZnN9h6aV1WOdpIumH+JvbicB+WnpVYTKdA38P+r+qJaFA6bWnQDWuSdyahhWMhfPtic4CE5P/iYIw= Received: from BYAPR18MB2424.namprd18.prod.outlook.com (20.179.91.149) by BYAPR18MB2421.namprd18.prod.outlook.com (20.179.91.146) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1922.17; Thu, 23 May 2019 13:10:39 +0000 Received: from BYAPR18MB2424.namprd18.prod.outlook.com ([fe80::1ce4:557d:eeb8:843c]) by BYAPR18MB2424.namprd18.prod.outlook.com ([fe80::1ce4:557d:eeb8:843c%7]) with mapi id 15.20.1922.018; Thu, 23 May 2019 13:10:39 +0000 From: Jerin Jacob Kollanukkaran To: "Zhang, Qi Z" , Thomas Monjalon , "Ananyev, Konstantin" CC: "Ergin, Mesut A" , "Xing, Beilei" , "dev@dpdk.org" , "Yigit, Ferruh" , Andrew Rybchenko Thread-Topic: [dpdk-dev] [PATCH 2/3] net/i40e: add runtime option to disable vector rx Thread-Index: AQHVEKtFdHa+v0QcxEWTGNAPFFNJNqZ4r38g Date: Thu, 23 May 2019 13:10:39 +0000 Message-ID: References: <1557980885-183777-1-git-send-email-mesut.a.ergin@intel.com> <3615B82CA151CF42A86EDDD9846A8B38C7A872FE@ORSMSX112.amr.corp.intel.com> <2601191342CEEE43887BDE71AB9772580161636EF4@irsmsx105.ger.corp.intel.com> <3457411.zOjnD88UkL@xps> <039ED4275CED7440929022BC67E7061153385FDE@SHSMSX103.ccr.corp.intel.com> In-Reply-To: <039ED4275CED7440929022BC67E7061153385FDE@SHSMSX103.ccr.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [106.201.57.97] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: cab95fc8-1727-4abd-c0cc-08d6df800d6f x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(5600141)(711020)(4605104)(2017052603328)(7193020); SRVR:BYAPR18MB2421; x-ms-traffictypediagnostic: BYAPR18MB2421: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-forefront-prvs: 00462943DE x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(39860400002)(346002)(366004)(376002)(136003)(396003)(189003)(199004)(13464003)(316002)(6116002)(3846002)(478600001)(14454004)(486006)(476003)(68736007)(6436002)(102836004)(186003)(26005)(74316002)(2906002)(66066001)(33656002)(446003)(11346002)(7696005)(5660300002)(76176011)(6506007)(53546011)(55236004)(71190400001)(71200400001)(73956011)(66946007)(66446008)(64756008)(66556008)(66476007)(76116006)(229853002)(14444005)(256004)(52536014)(305945005)(7736002)(99286004)(55016002)(4326008)(9686003)(86362001)(110136005)(6246003)(54906003)(8676002)(81156014)(81166006)(8936002)(25786009)(53936002)(83323001); DIR:OUT; SFP:1101; SCL:1; SRVR:BYAPR18MB2421; H:BYAPR18MB2424.namprd18.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: EcMKcKpR0AfXd3vUrc7yPtNAXW5XRE40PPPBjhmcCTCTV8KSBDz6Io8KgaVGIyeu9iDcp9lwYKA7z0+wEakp9frAN/8YIpH4AcipfkonGKuGVNvwULFcHvsyPJpb2Mmz5/mO1XMU//Kk43AD3Dwm7hukoIjLqq+LhdlyNT7y1F7aq7wI2a57jlrYToxlxysjOpJYy0v5WigrXtX0s03VYEee5XQkJjD3GZhof/mhDm5Hi1efHjZ9W7372U17pGAhpdhBtO3S7FooujfyCSDDro4ZViyK8bWDxLheTR/oah6ip2jt7dQbgsJygVu3eGLSWn0Mbz0rxmRZRE9iZnqJUw7rJmRj5eF1nYXopqCteXanaoFoahynSleQZKMv+YLwfNw1LaQAg6xfjS0nJbdv+Vnfk6DD5O04Zyq/jiEkaYo= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: cab95fc8-1727-4abd-c0cc-08d6df800d6f X-MS-Exchange-CrossTenant-originalarrivaltime: 23 May 2019 13:10:39.2190 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: jerinj@marvell.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR18MB2421 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2019-05-23_11:, , signatures=0 Subject: Re: [dpdk-dev] [PATCH 2/3] net/i40e: add runtime option to disable vector rx X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: dev On Behalf Of Zhang, Qi Z > Sent: Wednesday, May 22, 2019 8:03 PM > To: Thomas Monjalon ; Ananyev, Konstantin > > Cc: Ergin, Mesut A ; Xing, Beilei > ; dev@dpdk.org; Yigit, Ferruh > ; Andrew Rybchenko > > Subject: Re: [dpdk-dev] [PATCH 2/3] net/i40e: add runtime option to disab= le > vector rx >=20 > > -----Original Message----- > > From: Thomas Monjalon [mailto:thomas@monjalon.net] > > Sent: Wednesday, May 22, 2019 10:05 PM > > To: Ananyev, Konstantin > > Cc: Ergin, Mesut A ; Xing, Beilei > > ; Zhang, Qi Z ; > > dev@dpdk.org; Yigit, Ferruh ; Andrew Rybchenko > > > > Subject: Re: [dpdk-dev] [PATCH 2/3] net/i40e: add runtime option to > > disable vector rx > > > > Hi, > > > > 22/05/2019 13:01, Ananyev, Konstantin: > > > > As far as I can see, passing FDIR configuration via the rte_eth_con= f > struct: > > > > struct rte_fdir_conf fdir_conf; /**< FDIR configuration. > > > > DEPRECATED */ was deprecated. I suspect in favor of the late > > > > binding design mentioned, but again, I don't know the history on > > > > that. IMO, this > > made devargs a better choice. > > > > > > Ok, then it looks like there is a flaw in ethdev level API that needs= to be > fixed: > > > We deprecated old way to request FD usage without introducing new > one. > > > CC-ing to ethdev maintainers - > > > Guys is there a new way to request FD enablement, instead of > > > deprecated > > fdir_config? > > > Seems like not, unless I missed something obvious. > > > If not, then we probably need either to re-deprecate fdir_config, or > > > introduce > > some new method. > > > My first thought would be to add new DEV_RX_OFFLOAD_* flag(s). > > > Does it make sense? > > > > Sorry,I have not read the full thread so I may be out of topic. > > Please be aware that the flow director API is deprecated in favor of > > the more generic rte_flow API. > > >=20 > What we need is a software mark when a flow is hit, it is stored in mbuf-= >fdir > (there is another discussion to change the name "fdir" to a more generic > one) For intel driver, vector rx Path does not support software mark, so > currently we use rte_eth_conf-> rte_fdir_conf->mode to prevent vector > path be selected when fdir is required. > actually this is not make very sense, vector path is only necessary to be > disabled when software mark is required, but not for general fdir Now sin= ce > it will be removed, it's a good chance to improve this, a new offload fla= g such > as DEV_RX_OFFLOAD_FLOW_MARK looks like what we needed.. +1 to a new offload flag. >=20 > Regards > Qi >=20