From: Jerin Jacob Kollanukkaran <jerinj@marvell.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [EXT] [PATCH] net/octeontx: use logtype_init for failed probe
Date: Mon, 22 Jul 2019 08:05:49 +0000 [thread overview]
Message-ID: <BYAPR18MB24246CB588047300FC1D9FC9C8C40@BYAPR18MB2424.namprd18.prod.outlook.com> (raw)
In-Reply-To: <20190719095906.7e7b1473@hermes.lan>
> -----Original Message-----
> From: Stephen Hemminger <stephen@networkplumber.org>
> Sent: Friday, July 19, 2019 10:29 PM
> To: Jerin Jacob Kollanukkaran <jerinj@marvell.com>
> Cc: dev@dpdk.org
> Subject: Re: [EXT] [PATCH] net/octeontx: use logtype_init for failed probe
>
> On Fri, 19 Jul 2019 03:37:26 +0000
> Jerin Jacob Kollanukkaran <jerinj@marvell.com> wrote:
>
> > > -----Original Message-----
> > > From: Stephen Hemminger <stephen@networkplumber.org>
> > > Sent: Wednesday, July 17, 2019 12:18 AM
> > > To: Jerin Jacob Kollanukkaran <jerinj@marvell.com>
> > > Cc: dev@dpdk.org
> > > Subject: [EXT] [PATCH] net/octeontx: use logtype_init for failed
> > > probe
> >
> > > All log messages should use driver logtype. RTE_LOGTYPE_PMD is
> > > planned to be deprecated in the future.
> > >
> > > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> > > ---
> >
> > Please fix
> >
> > $ ./devtools/check-git-log.sh
> > Wrong headline format:
> > net/octeontx: use logtype_init for failed probe
> >
Changed the git commit to:
net/octeontx: use driver logtype
Applied to dpdk-next-net-mrvl/master. Thanks
>
> OK but
>
> That rule in check-git-log is still ridiculous because it rejects perfectly good
> commit subjects. The intention is good "stop automated bots" but the
> implementation rejects too many good patches.
prev parent reply other threads:[~2019-07-22 8:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-16 18:47 [dpdk-dev] " Stephen Hemminger
2019-07-19 3:37 ` [dpdk-dev] [EXT] " Jerin Jacob Kollanukkaran
2019-07-19 16:59 ` Stephen Hemminger
2019-07-22 8:05 ` Jerin Jacob Kollanukkaran [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BYAPR18MB24246CB588047300FC1D9FC9C8C40@BYAPR18MB2424.namprd18.prod.outlook.com \
--to=jerinj@marvell.com \
--cc=dev@dpdk.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).