From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 31D73A0096 for ; Thu, 6 Jun 2019 12:35:49 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 056F61B9A7; Thu, 6 Jun 2019 12:35:49 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by dpdk.org (Postfix) with ESMTP id 6C51E1DA4 for ; Thu, 6 Jun 2019 12:35:47 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x56AUcxQ016141; Thu, 6 Jun 2019 03:35:45 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0818; bh=o0FOp/S4bmhBGFMvN2HnS9aFEnWH+JduPlGoXnYF9wg=; b=WIFel/7y6Y+6hX8APCxAKkAw256IlBaAzumUt7PJ14xzsRWKBRppdXQsXYvEFzjwo9nx tfqpGfBaU750aWUEM9yYjZ9vr4TmsgO7TIGvZC8AbsIprSqj25Fvfe6Bl1FUi8B8bYog GrDbklINoe6X9bjavmFOUvG+iKdK7FQev62ifSRvu1jDo36lWuwUS0v0wjWFOZv8U7Fs XuepC9UT89P5fzPnlqA2Jl+nYhRIeNhsQqBa33sFeV+DskBTd4YYr5UjZfWhkZup3Q4L mebhMLl0eUm+3H1lVrkPoMzH+m6LjS3EEuI+czYEDxfirx6aTyJbWoDLOdhWg9Mb5+7I sg== Received: from sc-exch01.marvell.com ([199.233.58.181]) by mx0a-0016f401.pphosted.com with ESMTP id 2sxwgnrv7h-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Thu, 06 Jun 2019 03:35:45 -0700 Received: from SC-EXCH02.marvell.com (10.93.176.82) by SC-EXCH01.marvell.com (10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Thu, 6 Jun 2019 03:35:45 -0700 Received: from NAM05-CO1-obe.outbound.protection.outlook.com (104.47.48.56) by SC-EXCH02.marvell.com (10.93.176.82) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Thu, 6 Jun 2019 03:35:44 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector2-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=o0FOp/S4bmhBGFMvN2HnS9aFEnWH+JduPlGoXnYF9wg=; b=ww+v6CJU0bPyXs1QZQnWzuKyavVlPaiKPCsT+yWs+Y4WeXuOeLxpIUIkxIuxME1ec6qgbiiGYRPJkhiOAX4LGchIY5/z3/02WkjvSzeu92Tj5d95a5qNZz3ECnTTqmWq6tdN+RW7hSJtjUFDVDNhI79t5LGy+FkGyntcjB35yvw= Received: from BYAPR18MB2424.namprd18.prod.outlook.com (20.179.91.149) by BYAPR18MB2822.namprd18.prod.outlook.com (20.179.57.214) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1965.12; Thu, 6 Jun 2019 10:35:42 +0000 Received: from BYAPR18MB2424.namprd18.prod.outlook.com ([fe80::1ce4:557d:eeb8:843c]) by BYAPR18MB2424.namprd18.prod.outlook.com ([fe80::1ce4:557d:eeb8:843c%7]) with mapi id 15.20.1965.011; Thu, 6 Jun 2019 10:35:42 +0000 From: Jerin Jacob Kollanukkaran To: Yongseok Koh , "shahafs@mellanox.com" , "thomas@monjalon.net" , "ferruh.yigit@intel.com" , "arybchenko@solarflare.com" , "adrien.mazarguil@6wind.com" , "olivier.matz@6wind.com" CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] [RFC 2/3] ethdev: add flow modify mark action Thread-Index: AQHVGl5MhlO84OVXMkeafQZIVkYitKaOcGqQ Date: Thu, 6 Jun 2019 10:35:42 +0000 Message-ID: References: <20190603213231.27020-1-yskoh@mellanox.com> <20190603213231.27020-2-yskoh@mellanox.com> In-Reply-To: <20190603213231.27020-2-yskoh@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [14.140.231.66] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: a563363d-2268-46c5-03cb-08d6ea6ab9d1 x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(2017052603328)(7193020); SRVR:BYAPR18MB2822; x-ms-traffictypediagnostic: BYAPR18MB2822: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:3044; x-forefront-prvs: 00603B7EEF x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(366004)(39860400002)(396003)(346002)(376002)(136003)(13464003)(189003)(199004)(4326008)(66556008)(66446008)(66476007)(71190400001)(64756008)(71200400001)(8936002)(478600001)(110136005)(446003)(25786009)(7736002)(66066001)(76116006)(73956011)(14454004)(53546011)(186003)(81156014)(81166006)(8676002)(99286004)(11346002)(26005)(476003)(6246003)(256004)(53936002)(486006)(55016002)(7696005)(229853002)(5660300002)(316002)(74316002)(6506007)(33656002)(52536014)(6116002)(3846002)(66946007)(68736007)(2501003)(305945005)(6436002)(102836004)(9686003)(86362001)(2201001)(76176011)(2906002)(55236004); DIR:OUT; SFP:1101; SCL:1; SRVR:BYAPR18MB2822; H:BYAPR18MB2424.namprd18.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: akzFl1Ha2pTTjzx1FMGn0mbthuiOMGsTCi6ugyUSkrSMnhBzUFDF7NpXL9/mFxO9+medRLpV/h5qgddPa4gBwzjjWrUEDB0iyqEvMtvOqCu/XIOIa2mCg7P5W5WfLrdwiEIxiC/YMHK6/zYvyZ2G2/LB0bWh6yO7CbmPp/8KWCGMLrQnGyB3lPgUdKeqS9Ed4cL/hyBPHp0XCw1hizDf2iHdSwJuCh2aeKZLjdw5oN1Snp6X6z3xUn2/SK/zHcEIABk7njNatpsNwFOn2aYpDkEtM0IOUQaS0pPvn9fs86XoF3R6ucpCbYcsQ3EhSUBtplTmBlpV9VGpI5BsanC9xkjY4SflUdhpcdZz7A9fzHXEQ1uBNx6i9Nuw0GTAMjD9J5nLT4ccFLc5Ten3DmAhaKbnHP4HcR6nk5iTRLb+jOA= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: a563363d-2268-46c5-03cb-08d6ea6ab9d1 X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Jun 2019 10:35:42.2950 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: jerinj@marvell.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR18MB2822 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2019-06-06_09:, , signatures=0 Subject: Re: [dpdk-dev] [RFC 2/3] ethdev: add flow modify mark action X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: dev On Behalf Of Yongseok Koh > Sent: Tuesday, June 4, 2019 3:03 AM > To: shahafs@mellanox.com; thomas@monjalon.net; ferruh.yigit@intel.com; > arybchenko@solarflare.com; adrien.mazarguil@6wind.com; > olivier.matz@6wind.com > Cc: dev@dpdk.org > Subject: [dpdk-dev] [RFC 2/3] ethdev: add flow modify mark action >=20 > Mark ID can be modified when supporting multiple tables. Partial bit > alteration is supported to preserve some bit-fields set by previous match= . >=20 > Signed-off-by: Yongseok Koh > --- > doc/guides/prog_guide/rte_flow.rst | 21 +++++++++++++++++++++ > lib/librte_ethdev/rte_flow.h | 24 ++++++++++++++++++++++++ > 2 files changed, 45 insertions(+) >=20 > diff --git a/doc/guides/prog_guide/rte_flow.rst > b/doc/guides/prog_guide/rte_flow.rst > index 016cd90e52..2907edfff4 100644 > --- a/doc/guides/prog_guide/rte_flow.rst > +++ b/doc/guides/prog_guide/rte_flow.rst > @@ -1463,6 +1463,27 @@ depends on the underlying implementation. It is > returned in the > | ``id`` | integer value to return with packets | > +--------+--------------------------------------+ >=20 > +Action: ``MODIFY_MARK`` > +^^^^^^^^^^^^^^^^^^^^^^^ > + > +Alter partial bits of mark ID set by ``MARK`` action. > + > +``mask`` indicates which bits are modified. For bits which have never > +been set by ``MARK`` or ``MODIFY_MARK``, unpredictable value will be > +seen depending on driver implementation. > + > +.. _table_rte_flow_action_modify_mark: > + > +.. table:: MODIFY_MARK > + > + +----------+--------------------------------------+ > + | Field | Value | > + +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D+=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D+ > + | ``id`` | integer value to return with packets | > + +----------+--------------------------------------+ > + | ``mask`` | bit-mask applies to "id" | > + +----------+--------------------------------------+ > + > Action: ``FLAG`` > ^^^^^^^^^^^^^^^^ >=20 > diff --git a/lib/librte_ethdev/rte_flow.h b/lib/librte_ethdev/rte_flow.h = index > cda8628183..d811f8a06e 100644 > --- a/lib/librte_ethdev/rte_flow.h > +++ b/lib/librte_ethdev/rte_flow.h > @@ -1316,6 +1316,13 @@ enum rte_flow_action_type { > */ > RTE_FLOW_ACTION_TYPE_MARK, >=20 > + /** > + * Alter partial bits of mark ID set by > RTE_FLOW_ACTION_TYPE_MARK. > + * > + * See struct rte_flow_action_modify_mark. > + */ > + RTE_FLOW_ACTION_TYPE_MODIFY_MARK, > + I think, we need to define the case where application calls MODIFY_MARK fir= st on given pattern before MARK I think, either we can=20 # Introduce an error number for that? # Treat first MODIFY_MARK as MARK Just to understand, in this absence of this new action, an application need= s to destroy the given pattern with associated existing MARK action and add the same pattern with updated value as MARK action? Right?