From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 35201A00E6 for ; Thu, 8 Aug 2019 12:23:26 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 12AD41BACA; Thu, 8 Aug 2019 12:23:26 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by dpdk.org (Postfix) with ESMTP id AB93E1B9D9 for ; Thu, 8 Aug 2019 12:23:24 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id x78AJVDY001735; Thu, 8 Aug 2019 03:23:24 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0818; bh=qNmODZFCG1PqOaGKZs7z5IUtHu/SjdEpKyHAwJij1dc=; b=kyEAQKDOK93evltFkc+yWTMxf/qvFUM2E4bHkBvcbHm+McwxEAixvHYq8JDTr5Qyfp3I rsVtbyeDUBIDdeMaSXO/oebYJWr0fvQ8yq8d9rcBJqLHFNnogKdaRYBvjAiqa3CuAA4p 4Pe9eG1OYehjmH0VZqY34Fz3ekd4x8hn1wf2n+WicxCAd/BUhE/zO+Zxmj9Tif3QeS9K fbtgnlclrkWGK+15bIq1rClwqjD/xiBhyp1fPZXSa0/2eVzZuvcZWPNxNncGl6VcFRHs O2BCVs/XW6tkQbBZA9v07TGLVLIe11yIhheK3QbJ5TH+GJv+3c9Sfc5IK1mJPqy+xmOJ ng== Received: from sc-exch03.marvell.com ([199.233.58.183]) by mx0b-0016f401.pphosted.com with ESMTP id 2u59sm34rm-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Thu, 08 Aug 2019 03:23:24 -0700 Received: from SC-EXCH04.marvell.com (10.93.176.84) by SC-EXCH03.marvell.com (10.93.176.83) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Thu, 8 Aug 2019 03:23:22 -0700 Received: from NAM04-CO1-obe.outbound.protection.outlook.com (104.47.45.53) by SC-EXCH04.marvell.com (10.93.176.84) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Thu, 8 Aug 2019 03:23:22 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IfcPqJ/rFzs/rq4kOnlgadZ1fGkTeYM1DoYjBW1wUgqJCohIVuOHdXuqNfSF5PYprXhsua6LN32l055Ui3A1uHmyxKghPaO2a1PgEnsQGLz3Kvlq0y0lfLFBph8Se/qLUW13qnMkpKZH/WKw0zN+hwjSSdMSEm6nuvokW48vw0bP2uS4KcjnacPzLo9mODTfJrtiS64kjjNLKje2SuMmUwUAsmrEGs3O9tA8IoYl6uOPDY7AJDU7FgFxit8fqxU2vyNApH7WxFuIbQmcbvQykrgcTckCkryoNFzYdLslL5Q3GhLQBbrGWYxJO2nowhzpVJa34K6sA+/V/p+boxal6w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qNmODZFCG1PqOaGKZs7z5IUtHu/SjdEpKyHAwJij1dc=; b=nHZp5jF6x4BObqZsWavvLoTKb/0qnB/28xtG2aRfLi+69Gp8sMpol72BM8J3oNYYPs6Ae1Apmp2upVaca3uPHpurAK1LnPVBtEBxBUSSCRkOv1CDZcRAaCdZVtV5Yce7GTQmzv6pJnyCx4RRJCsDm+W+VEdUsgJwqUxeZwqZZkKwXiu/2lhlzyjifNbgGFNrhSsuuL5nK2yJRjsbSCdrrLMlifkv6g2ZUogbMvqfQOsZ96c0C9CNWLvuQxr2xxotQ9cJrmUXPYsvNfO4JKzYguSLM53L9gBofgELyGOAaAUKrXyY1XBcdIeuCe0LehUaiBdSSiLfeETil8BJ68UvaA== ARC-Authentication-Results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=marvell.com;dmarc=pass action=none header.from=marvell.com;dkim=pass header.d=marvell.com;arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector2-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qNmODZFCG1PqOaGKZs7z5IUtHu/SjdEpKyHAwJij1dc=; b=max5pPTxyzF2BbCz2ex4Wpsp1+abXyWLqbeIMQSe6G5KVIT+flVA8YvGLU8T3N/CoPH/xrqoO9fOqR3qO2ke3Fzn5r8VN7uI2p6n9r6nWOh9oox6wWAPhysH83puUepgtkE9HsXbiEiRjtd0Yx4Zp7OCC+gKMurffco3J620vIQ= Received: from BYAPR18MB2424.namprd18.prod.outlook.com (20.179.91.149) by BYAPR18MB2965.namprd18.prod.outlook.com (20.179.59.209) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2136.16; Thu, 8 Aug 2019 10:23:16 +0000 Received: from BYAPR18MB2424.namprd18.prod.outlook.com ([fe80::5877:72b7:40cf:2013]) by BYAPR18MB2424.namprd18.prod.outlook.com ([fe80::5877:72b7:40cf:2013%3]) with mapi id 15.20.2157.015; Thu, 8 Aug 2019 10:23:16 +0000 From: Jerin Jacob Kollanukkaran To: "Ananyev, Konstantin" , "Pavan Nikhilesh Bhagavatula" , "stephen@networkplumber.org" , "arybchenko@solarflare.com" , "hemant.agrawal@nxp.com" , "thomas@monjalon.net" , "Yigit, Ferruh" , "Richardson, Bruce" , Neil Horman , "Mcnamara, John" , "Kovacevic, Marko" CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] [patch v3] doc: announce API change in ethdev offload flags Thread-Index: AQHVTcr3n9J0wDDahEu40jmCmktW06bxAfswgAAE+QCAAAHmgA== Date: Thu, 8 Aug 2019 10:23:16 +0000 Message-ID: References: <20190808081752.516-1-pbhagavatula@marvell.com> <20190808085859.796-1-pbhagavatula@marvell.com> <2601191342CEEE43887BDE71AB9772580168A63989@irsmsx105.ger.corp.intel.com> <2601191342CEEE43887BDE71AB9772580168A639E4@irsmsx105.ger.corp.intel.com> In-Reply-To: <2601191342CEEE43887BDE71AB9772580168A639E4@irsmsx105.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [171.61.87.186] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: f9a94046-a46a-4472-7ea9-08d71bea6d73 x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(2017052603328)(7193020); SRVR:BYAPR18MB2965; x-ms-traffictypediagnostic: BYAPR18MB2965: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-forefront-prvs: 012349AD1C x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(396003)(346002)(366004)(39860400002)(136003)(376002)(13464003)(199004)(189003)(76116006)(76176011)(53936002)(8936002)(53546011)(6506007)(6436002)(99286004)(316002)(110136005)(9686003)(66066001)(305945005)(229853002)(55016002)(7736002)(81166006)(6246003)(81156014)(2906002)(66946007)(2201001)(64756008)(66446008)(66556008)(66476007)(33656002)(3846002)(6116002)(446003)(11346002)(2501003)(7696005)(476003)(26005)(7416002)(52536014)(71200400001)(71190400001)(86362001)(5660300002)(25786009)(186003)(4326008)(478600001)(14454004)(14444005)(256004)(486006)(74316002)(102836004)(921003)(1121003); DIR:OUT; SFP:1101; SCL:1; SRVR:BYAPR18MB2965; H:BYAPR18MB2424.namprd18.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: 9MqqyGW+KQXTZ/lRdipnrXpChE3BYOoSNIYx8TY+l+6QUB3foBnDE8aGBsGj28+pj9Ww9EKoCuIvcLkIZqYNNh9l65fIoGjbbdu5RifxPpt1qeN2dLWKrzoJVW9VojMR7+7nZt1tEXG49Gpvcr6lOsjWxQJ6VzyTnZYuiRL2To+yS1fUMeuH++Lkkb+q9CozpXr49ukeBE41ZiOr3IG7KnslnX4wyZaOa1gLBuW2Kw30AhRpaIxO70N7ny7NAuuInVWgHufzdq2p/gYF8rXiE3wib6YIwNhYx2iFZWWdVQsRYRVTrqPJ7m+X2lD4T8Uql9YN6nOtEcWYHsSAH0aHICjJcnj9hs/OwBCtGWgwG/NfoUAHP+uGxgXHnRQbj0uqgV5fu9DDtCNqV6NgKUrXxhEif1MzOJNnZv0QLN/Two8= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: f9a94046-a46a-4472-7ea9-08d71bea6d73 X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Aug 2019 10:23:16.7378 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 41FhQgQpEFACeZwGXVbsixwkelf7zJaG8peygwvcpQbepo1G4iFkR9IT0hB43Idp2LX+4+9+MTvrM4DFJ35DTQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR18MB2965 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:5.22.84,1.0.8 definitions=2019-08-08_05:2019-08-07,2019-08-08 signatures=0 Subject: Re: [dpdk-dev] [patch v3] doc: announce API change in ethdev offload flags X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Ananyev, Konstantin > Sent: Thursday, August 8, 2019 3:39 PM > To: Jerin Jacob Kollanukkaran ; Pavan Nikhilesh > Bhagavatula ; stephen@networkplumber.org; > arybchenko@solarflare.com; hemant.agrawal@nxp.com; > thomas@monjalon.net; Yigit, Ferruh ; Richardson, > Bruce ; Neil Horman > ; Mcnamara, John ; > Kovacevic, Marko > Cc: dev@dpdk.org > Subject: [EXT] RE: [dpdk-dev] [patch v3] doc: announce API change in ethd= ev > offload flags >=20 > External Email >=20 > ---------------------------------------------------------------------- > Hi Jerin, Hi Konstantin, >=20 > > > > > > Hi guys, > > > > > > > > > > > From: Pavan Nikhilesh > > > > > > > > Add new offload flags ``DEV_RX_OFFLOAD_PTYPE``, > > > ``DEV_RX_OFFLOAD_RSS`` > > > > and ``DEV_RX_OFFLOAD_FLOW_MARK``. > > > > > > > > Signed-off-by: Pavan Nikhilesh > > > > Acked-by: Andrew Rybchenko > > > > Acked-by: Jerin Jacob > > > > --- > > > > v3 Changes: > > > > - DEV_RX_OFFLOAD_RSS -> DEV_RX_OFFLOAD_RSS_HASH (anndrew). > > > > > > > > v2 Changes: > > > > - Reword for clarity. > > > > > > > > doc/guides/rel_notes/deprecation.rst | 13 +++++++++++++ > > > > 1 file changed, 13 insertions(+) > > > > > > > > diff --git a/doc/guides/rel_notes/deprecation.rst > > > > b/doc/guides/rel_notes/deprecation.rst > > > > index 37b8592b6..056c5709f 100644 > > > > --- a/doc/guides/rel_notes/deprecation.rst > > > > +++ b/doc/guides/rel_notes/deprecation.rst > > > > @@ -78,3 +78,16 @@ Deprecation Notices > > > > to set new power environment if power environment was already > > > initialized. > > > > In this case the function will return -1 unless the environment > > > > is unset > > > first > > > > (using ``rte_power_unset_env``). Other function usage scenarios > > > > will not > > > change. > > > > + > > > > +* ethdev: New offload flags ``DEV_RX_OFFLOAD_PTYPE``, > > > > +``DEV_RX_OFFLOAD_RSS_HASH`` > > > > + and ``DEV_RX_OFFLOAD_FLOW_MARK`` will be added in 19.11. > > > > > > One question about DEV_RX_OFFLOAD_PTYPE: > > > Does it mean that new ol_flags value (PKT_RX_PTYPE) will be > > > introduced to indicate that mbuf.packet_type value is set? > > > Or PMD will have to set mbuf.packet_type to zero, when > > > DEV_RX_OFFLOAD_PTYPE was not enabled by user? > > > > I was thinking when DEV_RX_OFFLOAD_PTYPE is set > > - mbuf.packet_type will be valid and mbuf.packet_type will have parsed > packet type. > > If not set > > - mbuf.packet_type can be anything application should not use > mbuf.packet_type field. >=20 > But in that case, we do need a new value for ol_flags, PKT_RX_PTYPE or so= , > right? Since application has two knobs rte_eth_dev_get_supported_ptypes() and=20 DEV_RX_OFFLOAD_PTYPE. We may not need to new ol_flags for this change. Righ= t? i.e if application sets the DEV_RX_OFFLOAD_PTYPE, The application will get the parsed ptypes by the driver(=3D rte_eth_dev_get_supported_ptypes())= . So there is no scope ambiguity. Right? >=20 > > > > This will avoid writes 0 to mbuf.packet_type and packet_type parsing if > offload is not set. > > > > > > > If so, what is the advantage? > > > Again in that case, would it be more plausible to introduce something= like: > > > rte_eth_dev_set_supported_ptypes(uint16_t port_id, uint32_t > > > ptype_mask); instead of DEV_RX_OFFLOAD_PTYPE? > > > > Any scheme is fine where we can skip the write 0 to mbuf.packet_type > > and packet_type parsing If application is NOT interested in packet_type= . > > > > > Konstantin > > > > > > > + This will allow application to enable or disable PMDs from > > > > + updating ``rte_mbuf`` fields ``rte_mbuf::packet_type``, > > > > + ``rte_mbuf::hash::rss`` and ``rte_mbuf::hash::fdir`` respectivel= y. > > > > + This scheme will allow PMDs to avoid writes to ``rte_mbuf`` > > > > + fields on Rx and thereby improve Rx performance if application > wishes do so. > > > > + In 19.11 PMDs will still update the fields even when the > > > > + offloads are not enabled. > > > > + The exact semantics of the flags will be worked out later > > > > + either by making them negative offloads to avoid application > > > > + change or positive offload to align with existing offload flag > semantics. > > > > -- > > > > 2.17.1