From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E4A60A00E6 for ; Thu, 8 Aug 2019 12:01:03 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 78D951B998; Thu, 8 Aug 2019 12:01:03 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by dpdk.org (Postfix) with ESMTP id A98891B970 for ; Thu, 8 Aug 2019 12:01:01 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id x789uja0031497; Thu, 8 Aug 2019 03:01:01 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0818; bh=DRcDndCnko3gdS22QMpEKpM9vfk6wg4BQRyjqjHnBWo=; b=en287pTYb36onwf182V2CuN0xIAq6VU2QUeKbtmC2babQuUHwWxcoyBrVtKJE0KGyIew t3iMs7nC6qp0vgcsNknUEf7eE3Big4WvlyEpru+5tY5MxbGOHE8qfQu6BmcWq3Z7EfTD IESWcSjDlSwQbc1IESnmaM0alY66sx5A6oHnfNRa5gf0ARbXn2QtODc6SrzR2bqNvSpr /Mqw8JNSZetsHUGI4/QfG00dhxpHIr/X52NCjIdioLpPp9HpTbG5KX5oTxjcYc0gES3V xSap7N5rmIZZOLNBXm4p1e9OxlDiobQPcW/jApGszvlT3QG90nCbNbMpFhhK5sEpL2kO WQ== Received: from sc-exch04.marvell.com ([199.233.58.184]) by mx0b-0016f401.pphosted.com with ESMTP id 2u59sm32kn-5 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Thu, 08 Aug 2019 03:01:00 -0700 Received: from SC-EXCH01.marvell.com (10.93.176.81) by SC-EXCH04.marvell.com (10.93.176.84) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Thu, 8 Aug 2019 03:00:59 -0700 Received: from NAM05-BY2-obe.outbound.protection.outlook.com (104.47.50.53) by SC-EXCH01.marvell.com (10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Thu, 8 Aug 2019 03:00:59 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eRwSYU+CGA4UzfDBGVI7vOBDdrHDFf1/fZ3Fm5fk3erEMCqmQb3j34tKmh4hCWjtbD/teg7bvYBcq2E1rKq4Rdz2mf+dW8HBmapP5R0v3vLOSNXTxPtl9ZkVi5jgFC5y3klCjoJLs9vKjS0oJG1kqxWjcHaLeu+cxiOLUf/NaWRnnTIDArQ5/JpLSCDFvoRZ5MDHKmmnp3K/26WJJAeWSh5D4bhshnm99gwQd3faqVSt5SPxW1HcYHsc9ubTjbdAaxicwpnNiQrYlF6Y6h1G0BMO8qMKzhRgQzqKcOq4ptdPKrhk4kpxP2rg1uhTiyZQ9NI2K1+8mweW7ZgrshMbJA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DRcDndCnko3gdS22QMpEKpM9vfk6wg4BQRyjqjHnBWo=; b=mowgJ4nXZPgD56/jOwDVD9OdmebKHfKL9p4L2zzCq3rrWSkGQvMbLo/cDBxLZKN427I4Ne5iRl3Wiqhd+KNI2U69R2ygdNJtSXBbT8y8BSJhJTDY2l+uLYhz+L+Mdht4pTjcaSNtWpruJpB+80xfoWoPLzCpwqu6PNwpSb22dcVLAi3eCw64Be4TsNSpHvhSP+4e/BRIxNVOu6zYCmTs7GjUS8hZpenM82UGkYLwZSNtKxIwVjDFbm0WeNFN1CiIx/bj7cpgD8zC50xu4ZTbx4+e+9gTTbBogePeir+VBtOWNJuM9TBKwkX/6pQXy1zaf0L8JhcUYexqDx3PUIG2cg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector2-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DRcDndCnko3gdS22QMpEKpM9vfk6wg4BQRyjqjHnBWo=; b=elb/tq9RM+LZGO0r9t8de8pi+A+3lEpHAnR7qOHjqYXGVTpLbVzTwbosIbJE29+H2LyUXj6Sj+oaUTbixrBYwUGkuMADuMthqxN7e1CHkvxcuRqQ8yXzXLJrE96ObNbTTzGMp/beVupi2oZdEd2t+G0QWwrXO6iScFE6NGrWFgc= Received: from BYAPR18MB2424.namprd18.prod.outlook.com (20.179.91.149) by BYAPR18MB2407.namprd18.prod.outlook.com (20.179.91.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2157.13; Thu, 8 Aug 2019 10:00:55 +0000 Received: from BYAPR18MB2424.namprd18.prod.outlook.com ([fe80::5877:72b7:40cf:2013]) by BYAPR18MB2424.namprd18.prod.outlook.com ([fe80::5877:72b7:40cf:2013%3]) with mapi id 15.20.2157.015; Thu, 8 Aug 2019 10:00:55 +0000 From: Jerin Jacob Kollanukkaran To: "Ananyev, Konstantin" , "Pavan Nikhilesh Bhagavatula" , "stephen@networkplumber.org" , "arybchenko@solarflare.com" , "hemant.agrawal@nxp.com" , "thomas@monjalon.net" , "Yigit, Ferruh" , "Richardson, Bruce" , Neil Horman , "Mcnamara, John" , "Kovacevic, Marko" CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] [patch v3] doc: announce API change in ethdev offload flags Thread-Index: AQHVTcr3n9J0wDDahEu40jmCmktW06bxAfsw Date: Thu, 8 Aug 2019 10:00:55 +0000 Message-ID: References: <20190808081752.516-1-pbhagavatula@marvell.com> <20190808085859.796-1-pbhagavatula@marvell.com> <2601191342CEEE43887BDE71AB9772580168A63989@irsmsx105.ger.corp.intel.com> In-Reply-To: <2601191342CEEE43887BDE71AB9772580168A63989@irsmsx105.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [171.61.87.186] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: f01982e3-0951-47b6-e6db-08d71be74e08 x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(5600148)(711020)(4605104)(1401327)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7193020); SRVR:BYAPR18MB2407; x-ms-traffictypediagnostic: BYAPR18MB2407: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-forefront-prvs: 012349AD1C x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(346002)(366004)(39860400002)(136003)(396003)(376002)(189003)(199004)(13464003)(71190400001)(71200400001)(86362001)(14444005)(256004)(9686003)(6246003)(8936002)(478600001)(33656002)(55016002)(6116002)(486006)(3846002)(26005)(99286004)(81156014)(81166006)(14454004)(102836004)(186003)(476003)(446003)(76176011)(7696005)(11346002)(25786009)(6506007)(4326008)(53546011)(305945005)(66556008)(6436002)(7736002)(64756008)(66476007)(66446008)(7416002)(53936002)(5660300002)(66066001)(2501003)(74316002)(66946007)(110136005)(76116006)(2201001)(52536014)(2906002)(316002)(229853002)(921003)(1121003); DIR:OUT; SFP:1101; SCL:1; SRVR:BYAPR18MB2407; H:BYAPR18MB2424.namprd18.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: BqUD0UvzoXOoL+yPSdldD17nAv2mOJCthJbnfT5132d8jic9mRzC2RS8yeLhHY4dd8DFK2JzD1dxgchWcvqleIVx7LBUn7O3QNAklo3WAcMRPok5y8WR1r5wHqsS+Tqt1JOt8SXq48QoYRMBMt//Qi3TBt8SWbJf4A08N1N/bnXkw9cOF6j1dHeuvSk73RZcgb/BG28otuxKyWgOq+rdjBD6H6RTUuN5ztBhGsTf4REcKKLxJgTlqqBGc6soRg+Tvx3dpTOhgpRtZ6Ehmxf++6nbjqOwf7hTg1qu1nfh5E6/GhI4U0vyBV6A+12JV+GtXcNiWb9bLoyVmVcCUTZsOk/qJk5IBXOJ0J8FPJ9c8S5TnLZshAUl+OK4p7RiB7OIke/fvIWDNhcan0bXn3NGhL4Ox9cfaR9lEsT0C6N4Ws0= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: f01982e3-0951-47b6-e6db-08d71be74e08 X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Aug 2019 10:00:55.5546 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 8DL/50Bw5F28hpRe73+n5cbYJtpnAc1esxUwqVqi/5HG9nuSsyLKLh1WDi09qI4gg4r8hK9/QquCjkbCSD3bcw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR18MB2407 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:5.22.84,1.0.8 definitions=2019-08-08_05:2019-08-07,2019-08-08 signatures=0 Subject: Re: [dpdk-dev] [patch v3] doc: announce API change in ethdev offload flags X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Ananyev, Konstantin > Sent: Thursday, August 8, 2019 2:53 PM > To: Pavan Nikhilesh Bhagavatula ; Jerin Jacob > Kollanukkaran ; stephen@networkplumber.org; > arybchenko@solarflare.com; hemant.agrawal@nxp.com; > thomas@monjalon.net; Yigit, Ferruh ; Richardson, > Bruce ; Neil Horman > ; Mcnamara, John ; > Kovacevic, Marko > Cc: dev@dpdk.org > Subject: [EXT] RE: [dpdk-dev] [patch v3] doc: announce API change in ethd= ev > offload flags >=20 > External Email >=20 > ---------------------------------------------------------------------- >=20 > Hi guys, >=20 > > > > From: Pavan Nikhilesh > > > > Add new offload flags ``DEV_RX_OFFLOAD_PTYPE``, > ``DEV_RX_OFFLOAD_RSS`` > > and ``DEV_RX_OFFLOAD_FLOW_MARK``. > > > > Signed-off-by: Pavan Nikhilesh > > Acked-by: Andrew Rybchenko > > Acked-by: Jerin Jacob > > --- > > v3 Changes: > > - DEV_RX_OFFLOAD_RSS -> DEV_RX_OFFLOAD_RSS_HASH (anndrew). > > > > v2 Changes: > > - Reword for clarity. > > > > doc/guides/rel_notes/deprecation.rst | 13 +++++++++++++ > > 1 file changed, 13 insertions(+) > > > > diff --git a/doc/guides/rel_notes/deprecation.rst > > b/doc/guides/rel_notes/deprecation.rst > > index 37b8592b6..056c5709f 100644 > > --- a/doc/guides/rel_notes/deprecation.rst > > +++ b/doc/guides/rel_notes/deprecation.rst > > @@ -78,3 +78,16 @@ Deprecation Notices > > to set new power environment if power environment was already > initialized. > > In this case the function will return -1 unless the environment is u= nset > first > > (using ``rte_power_unset_env``). Other function usage scenarios will= not > change. > > + > > +* ethdev: New offload flags ``DEV_RX_OFFLOAD_PTYPE``, > > +``DEV_RX_OFFLOAD_RSS_HASH`` > > + and ``DEV_RX_OFFLOAD_FLOW_MARK`` will be added in 19.11. >=20 > One question about DEV_RX_OFFLOAD_PTYPE: > Does it mean that new ol_flags value (PKT_RX_PTYPE) will be introduced to > indicate that mbuf.packet_type value is set? > Or PMD will have to set mbuf.packet_type to zero, when > DEV_RX_OFFLOAD_PTYPE was not enabled by user? I was thinking when DEV_RX_OFFLOAD_PTYPE is set - mbuf.packet_type will be valid and mbuf.packet_type will have parsed pack= et type. If not set - mbuf.packet_type can be anything application should not use mbuf.packet_t= ype field. This will avoid writes 0 to mbuf.packet_type and packet_type parsing if off= load is not set. > If so, what is the advantage? > Again in that case, would it be more plausible to introduce something lik= e: > rte_eth_dev_set_supported_ptypes(uint16_t port_id, uint32_t > ptype_mask); instead of DEV_RX_OFFLOAD_PTYPE? Any scheme is fine where we can skip the write 0 to mbuf.packet_type and p= acket_type parsing If application is NOT interested in packet_type. > Konstantin >=20 > > + This will allow application to enable or disable PMDs from updating > > + ``rte_mbuf`` fields ``rte_mbuf::packet_type``, > > + ``rte_mbuf::hash::rss`` and ``rte_mbuf::hash::fdir`` respectively. > > + This scheme will allow PMDs to avoid writes to ``rte_mbuf`` fields > > + on Rx and thereby improve Rx performance if application wishes do so= . > > + In 19.11 PMDs will still update the fields even when the offloads > > + are not enabled. > > + The exact semantics of the flags will be worked out later either by > > + making them negative offloads to avoid application change or > > + positive offload to align with existing offload flag semantics. > > -- > > 2.17.1