From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C3E4CA2E1B for ; Wed, 4 Sep 2019 15:30:50 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9A1631BEE6; Wed, 4 Sep 2019 15:30:50 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by dpdk.org (Postfix) with ESMTP id 1957A1B99D; Wed, 4 Sep 2019 15:30:48 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id x84DUm1M030764; Wed, 4 Sep 2019 06:30:48 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0818; bh=P0v4okShyS62HmY+nzWq84OTD3Q5j9lsa32ke458kdg=; b=p1p4ijR9G50x236pny931jj+/Bo1SZFPT8jgqDG3wJmNsOdO41+0Lk1zlCPLlbStg5BS OZR0d1d6Bh/Y+PNtx5WbaF9sqTh2aj/3ERw+y5WzsInoVkMi8SA/wEnIwGTa/i+cnLCA BSuNw1d1SJyEazenShiI5kkt0cv/yT03oU/nMI1k85wS3/DfG5JNALHMNX+5YmYS4S9R FRZqVN6NsyEoNcsJofAEMTmwSc3dBb/2IAsv3UXOumDEe6cfc6iu1enkdsAqyJnbVl0o W3Inhef+OOB3UtQ8TUV8xGlb5tp8u1gnAK3waZevQ5WL/ZS79iTIQznYt6iJ7/2Vs6ii 2g== Received: from sc-exch04.marvell.com ([199.233.58.184]) by mx0a-0016f401.pphosted.com with ESMTP id 2uqp8peu6t-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Wed, 04 Sep 2019 06:30:48 -0700 Received: from SC-EXCH03.marvell.com (10.93.176.83) by SC-EXCH04.marvell.com (10.93.176.84) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Wed, 4 Sep 2019 06:30:46 -0700 Received: from NAM05-DM3-obe.outbound.protection.outlook.com (104.47.49.57) by SC-EXCH03.marvell.com (10.93.176.83) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Wed, 4 Sep 2019 06:30:46 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MDtCzoLrL6jNhpYfan+u7kmjKZ/IZCNkbqEX89mqLoOVoKAZg0RDau9WtZtP8gtYuHKHLTI/EhcGUB8OMLnu+aTB/HhrWkXzY7hPXccXbeEu943Qoe3snL4WdvGp6wspWxy85XbiANjxkDPxQCulzdW6XKVmxY9PRFQPw2jhbPNtHanfXF2S1DkcVuvNVug3AWFdZh2VL6pxCvH4bzcvdQ+3znlUS3vKJL3TOxQIvbt9LHr3ZeH8gGKMhGZpw0dgu0rSpA+sXYlV+ILdK5t81qIoZzA82GF0ph7s9cCmDi4lVgemLdQHZxzhqhgk0ubfvftHWTnBgZvbnYbNDuOMfg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=P0v4okShyS62HmY+nzWq84OTD3Q5j9lsa32ke458kdg=; b=h3MSIJmPtDGmu+iT2P2itLuUyGeVFekOC8K7SievNPUWV6lU47LTOU9cIVOAqhpGreWpeVqaa9AOaxRmrUtCyS0yqgoaLqMc3w8nnnQ3TAqo4gVTpf7NhbsYaCljRe55I+sL+apw0BPaoKcGFvrIHlev9uKwlKcxQXJuSyhbLL8ByOBaV1EhbfmiVcnxURgNWw8k3AI55B4pJgf9E8BQXxiOKuiDORzNZqxgs5gZs0w3We17KTZ5zl+CODUBQDKIMaQhzuEjiVXgFtd8TKAr7aYQf3zAGrL79/2a+vp8s+Qz5C3YtG+dKaTf/9NOfkECd23CuL9vLHSE/G3RQUsKvQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector2-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=P0v4okShyS62HmY+nzWq84OTD3Q5j9lsa32ke458kdg=; b=QZM922g/IfZFOEDOJFgsAFdelpY1UygMJfXmwfiAtZRhGblh6Mgt4BbN+d8iQYUSjxNzl7r0/u3kpiyZI8Kr1sC4W6Sxjf2n6ipRyWhnHMLdZwgOcyGckcvv+eHBT6EmZxpk4T25wEZxlbnaPlkS1DJW5ndEogd+EHOxZXNFv8s= Received: from BYAPR18MB2424.namprd18.prod.outlook.com (20.179.91.149) by BYAPR18MB3047.namprd18.prod.outlook.com (20.179.60.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2241.14; Wed, 4 Sep 2019 13:30:41 +0000 Received: from BYAPR18MB2424.namprd18.prod.outlook.com ([fe80::1d8b:430f:c74a:33]) by BYAPR18MB2424.namprd18.prod.outlook.com ([fe80::1d8b:430f:c74a:33%6]) with mapi id 15.20.2241.014; Wed, 4 Sep 2019 13:30:41 +0000 From: Jerin Jacob Kollanukkaran To: Shahed Shaikh , "dev@dpdk.org" CC: Rasesh Mody , "ferruh.yigit@intel.com" , GR-Everest-DPDK-Dev , "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH 1/2] net/qede: fix ovs-dpdk failure when using odd number of queues on 100Gb mode Thread-Index: AQHVYxT5Ucc4yMLtikSYEcR+paahTqcbg1OA Date: Wed, 4 Sep 2019 13:30:41 +0000 Message-ID: References: <20190904113046.2213-1-shshaikh@marvell.com> In-Reply-To: <20190904113046.2213-1-shshaikh@marvell.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [122.181.204.84] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 9a6a5fac-7f36-4671-189c-08d7313c1527 x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600166)(711020)(4605104)(1401327)(2017052603328)(7193020); SRVR:BYAPR18MB3047; x-ms-traffictypediagnostic: BYAPR18MB3047: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7219; x-forefront-prvs: 0150F3F97D x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(396003)(346002)(376002)(39860400002)(136003)(366004)(13464003)(189003)(199004)(71200400001)(71190400001)(66476007)(25786009)(4326008)(256004)(14444005)(478600001)(14454004)(6246003)(66446008)(66556008)(64756008)(76116006)(66946007)(476003)(11346002)(86362001)(446003)(229853002)(486006)(33656002)(76176011)(81156014)(102836004)(8936002)(81166006)(7736002)(53546011)(6506007)(74316002)(305945005)(6116002)(3846002)(2501003)(26005)(186003)(316002)(5660300002)(110136005)(52536014)(54906003)(7696005)(99286004)(55016002)(9686003)(66066001)(6436002)(53936002)(2906002); DIR:OUT; SFP:1101; SCL:1; SRVR:BYAPR18MB3047; H:BYAPR18MB2424.namprd18.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: 6ENAD9aLKdtts0lnpcYp3KqgLpk6hqur+Su9OIGXp1di9Yudxvzseqqn2mYXxTV7h31n/rbqOl/4zvQg4BeZfyyXaN17J6MGqNL/M2KerALdInyAb3iSsX7hpoK+C4aPdp4jy9f7XQ9suRUvM+UjXaPvauTHcqEHjC6SisSU1NYrjM4Nbr6G5EzFKJ872tZMVnsuhJ3eHvZJgsfJcbtp3Yb99/nICJ6FlENdo1KGfcU4jQ3Ke49sqQuoYRi4iYj68Z2+qGShwflGUrlfx5erPmJaY/PRo3spB575q+8OlFWifGYxNFhZUWCV1PW6H9YkqberWgM/2aULK3/FMGBMtDuKxnlbl4gPDBK2l9i82MEZMUNxdh7b/99uG0LWBo29+xSBwY+KsDe0MzxGW5GdW/rBd2av0suSv7CfoD2s8jM= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 9a6a5fac-7f36-4671-189c-08d7313c1527 X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Sep 2019 13:30:41.6688 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: etLhX2D0HY8XODAS3RtCTNQtJgho2DGtYp+8hYykoQAuZTyJF8s+1FJacMKUxhH4dkZ+X2raJqaONRjRVWsUKA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR18MB3047 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.70,1.0.8 definitions=2019-09-04_04:2019-09-03,2019-09-04 signatures=0 Subject: Re: [dpdk-dev] [PATCH 1/2] net/qede: fix ovs-dpdk failure when using odd number of queues on 100Gb mode X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: dev On Behalf Of Shahed Shaikh > Sent: Wednesday, September 4, 2019 5:01 PM > To: dev@dpdk.org > Cc: Rasesh Mody ; ferruh.yigit@intel.com; GR- > Everest-DPDK-Dev ; stable@dpdk.org > Subject: [dpdk-dev] [PATCH 1/2] net/qede: fix ovs-dpdk failure when using > odd number of queues on 100Gb mode >=20 > As per HW design of 100Gb mode, device internally uses 2 engines > (eng0 and eng1), and both engines need to be configured symmetrically. > Based on this requirement, driver design chose an approach to allow user = to > allocate only even number of queues and split those queues on both engine= s > equally. >=20 > This approach puts a limitation on number of queues to be allocated - i.e= . > user can't configure odd number of queues on 100Gb mode. > OVS configures DPDK port with 1 rxq and 1 txq, which causes initializatio= n of > qede port to fail. >=20 > This patch changes the implementation of queue allocation method for > 100Gb devices by removing above mentioned limitation and allowing user to > configure odd number of queues. >=20 > Key changes in this patch - > - Allocate requested queue count on both engines, so that > actual hardware queue count will be double of what user requested. > - Create a pair of queues from both engines and provide it to > rte_ethdev queue structure. So ethdev will see only one queue for > underlying queue pair created for hw engine pair. > - Rx and Tx methods from ethdev will provide that queue pair > object and PMD will internally split Rx and Tx packet processing acros= s > both engines in separately installed Rx and Tx handlers. > - Consolidate statistics of both HW queues while reporting to applicatio= n. > - Report engine wise queue statistics in xstats flow. > e.g. - rx_q._xxxxxxx Multiple logical changes in one patch. Please split the patch to more logical ones for easy review. >=20 > Fixes: 2af14ca79c0a ("net/qede: support 100G") > Cc: stable@dpdk.org >=20 > Signed-off-by: Shahed Shaikh