From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7DF09A046B for ; Mon, 22 Jul 2019 16:20:12 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 962751BE0D; Mon, 22 Jul 2019 16:20:11 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by dpdk.org (Postfix) with ESMTP id 4809C1BE0A for ; Mon, 22 Jul 2019 16:20:10 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id x6MEFdaQ014699; Mon, 22 Jul 2019 07:20:05 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0818; bh=4P6DZeV12QMptzv/3gxssEHGdWeQdc3ZNrMBRzNNgIk=; b=nxqfOwKm1wt9YT3Y+74dsJ+ozcL6+kILC9VtNo8NVa28eglGexY4EBKPpAcCn8Ht00dg DohAwKREC6cb5EX6N7jJ5gkdgXymwTuxePmnQQAUMUkgTlCrw9n+roHhT7mf4KeRm3Xl ebN6PQkY+HddD6LymqvqMnG6h8YL9pJg/y7dbcJ5xj+Z5sxHD6DdhJnm9DBmNdM/erHA hSMwebpwgdp4OeN5UPkw0cIyZ2pzONgSoB32Ug2DiyvS54y3WypuH4/DFWXS0dd/jpEl IrrX2VBV6hANlaCcXTMzqXhyPrgo8O7WDdILFDV28J9ySIYA2yOsWLoh3GZ8Vdv7SMAQ xQ== Received: from sc-exch04.marvell.com ([199.233.58.184]) by mx0b-0016f401.pphosted.com with ESMTP id 2tv2fj6qgk-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Mon, 22 Jul 2019 07:20:05 -0700 Received: from SC-EXCH01.marvell.com (10.93.176.81) by SC-EXCH04.marvell.com (10.93.176.84) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Mon, 22 Jul 2019 07:20:04 -0700 Received: from NAM04-BN3-obe.outbound.protection.outlook.com (104.47.46.51) by SC-EXCH01.marvell.com (10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Mon, 22 Jul 2019 07:20:03 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nClRxkX2zg7APr/6mvoU1Jdm3AJwuYCcMB5I1qhk4JmvS0kZT055A0/afAGAkMQOJP28WAZFNht6BkkGrp6QnEZigA4VbO/i7oc3HUBATQXWIg2sbHVXTkFHQn2G/Bk61zkuj+Y1oSo4Ca1YTxEteYMouDXTaSm8QeuBHrAsFtSTT+6iARV4AuAmcyx4OO1ugh0Wse4CGvZ4K3vMKOFgG3rA8bonirzCi2x80jOK0/8+aCBTjOjfnHWsm3fzk5iHwkVXj5Y5zrvEeo7e8Hcoktpq8cKCMkQtsDnU4V6yos9SgP6PBE+dJsF7QCgXhcP5Usn8auM/H8f9CLrtDxtxsw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4P6DZeV12QMptzv/3gxssEHGdWeQdc3ZNrMBRzNNgIk=; b=dLmSZ7zyEPJz0czCNXJhEYhp45TFy5bxxZgZgDGkYsh26UU8C3b3hvESF/D47PUvGBXNCJ+PzqRuAG7isBZG04ymRVg6oLF6ovklqQr4zCt16175xs48fpDSJU1ZikhTpMmiH7x42E0VgpUA3lEkm5mZGi6C/JxSJwvcrCOQYYAtb5IFevr0gLPMpNJipeUbnwz5pE9freORFInee56sXI5z8E+mU55OIMOo84ixRySnhY8WYKGHDJWXk+WdJEhJNej6S8Gog8sGP74nQAkkfchVbDjRel+xWpGrhX87zgQYc4EMPsqS/819+S+7CFIowFEPSNdY48Wo4CI5SCtIug== ARC-Authentication-Results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=marvell.com;dmarc=pass action=none header.from=marvell.com;dkim=pass header.d=marvell.com;arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector2-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4P6DZeV12QMptzv/3gxssEHGdWeQdc3ZNrMBRzNNgIk=; b=hqBvhUQO4UOn9r21/O91+nxY8MvscQcaTJzeyu3pZ4js1fW28KY7ARgD9bKvkmeP/+bNep2Vz9vITSuSE8AtCPt+7LKrH7OEsYVKBb7HK4oDqq43emXJ3EO4oOa94f7G/cmePvnkhclq9uBeDG7Ra2BSaIEEmmqJMq4U2k3G41A= Received: from BYAPR18MB2424.namprd18.prod.outlook.com (20.179.91.149) by BYAPR18MB2518.namprd18.prod.outlook.com (20.179.93.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2094.17; Mon, 22 Jul 2019 14:19:58 +0000 Received: from BYAPR18MB2424.namprd18.prod.outlook.com ([fe80::2d42:12b6:aa2e:2862]) by BYAPR18MB2424.namprd18.prod.outlook.com ([fe80::2d42:12b6:aa2e:2862%4]) with mapi id 15.20.2094.013; Mon, 22 Jul 2019 14:19:58 +0000 From: Jerin Jacob Kollanukkaran To: Phil Yang , "dev@dpdk.org" CC: "thomas@monjalon.net" , "gage.eads@intel.com" , "hemant.agrawal@nxp.com" , "Honnappa.Nagarahalli@arm.com" , "gavin.hu@arm.com" , "nd@arm.com" Thread-Topic: [EXT] [PATCH v5 1/3] eal/arm64: add 128-bit atomic compare exchange Thread-Index: AQHVQI5Nr1CrhxT+kEmAFLrO8EDofabWrsDg Date: Mon, 22 Jul 2019 14:19:57 +0000 Message-ID: References: <1561257671-10316-1-git-send-email-phil.yang@arm.com> <1563800774-2710-1-git-send-email-phil.yang@arm.com> In-Reply-To: <1563800774-2710-1-git-send-email-phil.yang@arm.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [106.200.248.176] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 122af2fc-c2a8-4dde-ab86-08d70eafad14 x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(2017052603328)(7193020); SRVR:BYAPR18MB2518; x-ms-traffictypediagnostic: BYAPR18MB2518: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2958; x-forefront-prvs: 01068D0A20 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(396003)(376002)(366004)(346002)(39860400002)(136003)(13464003)(189003)(199004)(6436002)(53936002)(2501003)(55016002)(486006)(9686003)(66066001)(2906002)(33656002)(6116002)(3846002)(8936002)(68736007)(76176011)(7696005)(25786009)(6506007)(53546011)(102836004)(478600001)(66476007)(81156014)(81166006)(11346002)(446003)(26005)(66556008)(14454004)(186003)(74316002)(99286004)(316002)(4326008)(305945005)(64756008)(7736002)(76116006)(71200400001)(71190400001)(5660300002)(256004)(86362001)(110136005)(66946007)(54906003)(52536014)(66446008)(476003)(8676002)(229853002)(6246003); DIR:OUT; SFP:1101; SCL:1; SRVR:BYAPR18MB2518; H:BYAPR18MB2424.namprd18.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: 2KJudwPcI5Hzj46PiUHVNr6XQUHjFbIGvukdNOHvGqLVS+UZ0FiS1znHQ7pCr2Xcj55986dI61eehRaGOtvxfzzggrdRJtGSUTg7r6dT9KptauE4VV6kA/lcGYxvOxQwSxMHy2+078Ms3XHHNIyoo2Bj+7kwSL8QDjTIWnKt65dCkq4ZD5W9EtKgbFwxPPA4VV60eXQbsxFghkvkRPulin5cIldWKCnOuc9JAYlXW3AAVLS6kmbLs30GGU9YsT8axpLuzAjiIjaxAIV60emIle2oWpS647xBvfG9Uh7wUY7/L5T4TF61sfy1UcdwUO6ofu/N+TRMKM0a2vWqznLmW2ZMjttNf7c46VzhutttDHXYayHXTJXoKYPl1Orq/uF1lmOPl9t8WlGPloBsSjcJ88XM5aT+55279xDrVszuOgE= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 122af2fc-c2a8-4dde-ab86-08d70eafad14 X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Jul 2019 14:19:57.9754 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: jerinj@marvell.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR18MB2518 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:5.22.84,1.0.8 definitions=2019-07-22_10:2019-07-22,2019-07-22 signatures=0 Subject: Re: [dpdk-dev] [EXT] [PATCH v5 1/3] eal/arm64: add 128-bit atomic compare exchange X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" It looks good. Some minor comments. > -----Original Message----- > From: Phil Yang > Sent: Monday, July 22, 2019 6:36 PM > To: dev@dpdk.org > Cc: thomas@monjalon.net; Jerin Jacob Kollanukkaran ; > gage.eads@intel.com; hemant.agrawal@nxp.com; > Honnappa.Nagarahalli@arm.com; gavin.hu@arm.com; nd@arm.com > Subject: [EXT] [PATCH v5 1/3] eal/arm64: add 128-bit atomic compare > exchange > ---------------------------------------------------------------------- > Add 128-bit atomic compare exchange on aarch64. >=20 > Suggested-by: Jerin Jacob > Signed-off-by: Phil Yang > Tested-by: Honnappa Nagarahalli > Reviewed-by: Honnappa Nagarahalli >=20 > diff --git a/config/common_base b/config/common_base index > 8ef75c2..16dea5a 100644 > --- a/config/common_base > +++ b/config/common_base > @@ -1067,3 +1067,8 @@ CONFIG_RTE_APP_CRYPTO_PERF=3Dy # Compile the > eventdev application # CONFIG_RTE_APP_EVENTDEV=3Dy > + > +# > +# Compile ARM LSE ATOMIC instructions > +# > +CONFIG_RTE_ARM_FEATURE_ATOMICS=3Dn Move this config after "Compile Environment Abstraction Layer" section. Now it is at end of file. Better to group the configs. > diff --git a/config/defconfig_arm64-octeontx2-linuxapp-gcc > b/config/defconfig_arm64-octeontx2-linuxapp-gcc > index f20da24..a6508e8 100644 > --- a/config/defconfig_arm64-octeontx2-linuxapp-gcc > +++ b/config/defconfig_arm64-octeontx2-linuxapp-gcc > @@ -19,3 +19,6 @@ CONFIG_RTE_EAL_IGB_UIO=3Dn >=20 > # Max supported NIX LFs > CONFIG_RTE_MAX_VFIO_GROUPS=3D128 > + > +# arm64 LSE ATOMIC support > +CONFIG_RTE_ARM_FEATURE_ATOMICS=3Dy Move this config after CONFIG_RTE_MAX_LCORE=3D24 > diff --git a/config/defconfig_arm64-thunderx2-linuxapp-gcc > b/config/defconfig_arm64-thunderx2-linuxapp-gcc > index cc5c64b..17b6dec 100644 > --- a/config/defconfig_arm64-thunderx2-linuxapp-gcc > +++ b/config/defconfig_arm64-thunderx2-linuxapp-gcc > @@ -6,6 +6,7 @@ >=20 > CONFIG_RTE_MACHINE=3D"thunderx2" >=20 > +CONFIG_RTE_ARM_FEATURE_ATOMICS=3Dy > CONFIG_RTE_CACHE_LINE_SIZE=3D64 > CONFIG_RTE_MAX_NUMA_NODES=3D2 > CONFIG_RTE_MAX_LCORE=3D256 Move the new config here