From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 24873A034F; Sun, 21 Mar 2021 11:30:14 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D00E240042; Sun, 21 Mar 2021 11:30:13 +0100 (CET) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id DB9CA40041 for ; Sun, 21 Mar 2021 11:30:11 +0100 (CET) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 12LAQ4Bv031170; Sun, 21 Mar 2021 03:30:08 -0700 Received: from nam12-mw2-obe.outbound.protection.outlook.com (mail-mw2nam12lp2048.outbound.protection.outlook.com [104.47.66.48]) by mx0b-0016f401.pphosted.com with ESMTP id 37dgjnsx2u-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sun, 21 Mar 2021 03:30:08 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GyNTqsB4aD9SIgGH5htg72qFq0t3dl4gGbx25rCEqtsMMsCa7lI8NH/5Y5xXoKLstf1V9ILbPFcMNBELTdl9XXXlDrZoFyXvEknbIAWFOgkxmzTV2m8AEJAPrH69JCcXZIKNiZtXnO1ZSPfGBqkW+MUw4LSNoyiPO1zVSDjOKh2Gt5KWCZDjd0kdxXlKzNTOrbMqp9vpuF+isegZAspBk+7lKj0WPBzma0pT2iXdS6KhFgXCBW/5i7K9E1jlYssBT3WKCv9SWTX5SZz6CmVat0Vp9YeOeWLxs7jaPPOH1MdOsfm957IrwP1VtUK9S2bcljGXsuFZ6YSnYKVak/qK1w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qkhP3DrpmgS8SNgYwdxzG5bfiA2RRN3wYPOIEUbml2I=; b=mky/XC3qlBpPk9P9VSweax1KgQVAyUXOlpUfuD31tTnw9oYGZ85b6REzH7wVG3vdCDvE5EegfdmKf97E5M8ryT9rKH2D87yuUePhy/vtiYHAIVjvM6t3Hze7KzboBAC9AxVQeNmX4IoB2+XnkjOK9Y7wHfMXfkKQdzpTv5+CNoamS8mMk59GnYtvdIxsAZg81zpeUlVPcBjnQEFsll7TImwJ4FGiKK19aI9p34cr+jjbQb1wDB6M1MNo3RlewouralVMpFncMSe0ELZX30dbgNvooajmetUE7EzC2x2EbG1mFkr1OWJPhkFq8sCB3plT5Yddc8ZjkHAV0qRkMYcgbg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qkhP3DrpmgS8SNgYwdxzG5bfiA2RRN3wYPOIEUbml2I=; b=ZsnegbFlJ0rX0yh4G84CHYif0ExRdia+b+T3RWD5mfEYLEl8e1dTQTib9WgSY91/+flpf6PzJP4weiLsFAJrDXMojsHDub4YFcvC89F/tKPmEo6pVmH5lUxcoM31KaR4E5HaAJBW0FecCqWUoiaElq87bGX+HFj5Qe/rzWp7vKk= Received: from BYAPR18MB2424.namprd18.prod.outlook.com (2603:10b6:a03:130::21) by BY5PR18MB3300.namprd18.prod.outlook.com (2603:10b6:a03:1a8::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3955.18; Sun, 21 Mar 2021 10:30:04 +0000 Received: from BYAPR18MB2424.namprd18.prod.outlook.com ([fe80::859c:b5eb:8b6e:bb59]) by BYAPR18MB2424.namprd18.prod.outlook.com ([fe80::859c:b5eb:8b6e:bb59%5]) with mapi id 15.20.3955.025; Sun, 21 Mar 2021 10:30:04 +0000 From: Jerin Jacob Kollanukkaran To: Timothy McDaniel , "dev@dpdk.org" CC: "harry.van.haaren@intel.com" , "mdr@ashroe.eu" , "nhorman@tuxdriver.com" , "nikhil.rao@intel.com" , "erik.g.carrillo@intel.com" , "abhinandan.gujjar@intel.com" , Pavan Nikhilesh Bhagavatula , "hemant.agrawal@nxp.com" , "mattias.ronnblom@ericsson.com" , "peter.mccarthy@intel.com" Thread-Topic: [EXT] [PATCH 02/25] event/dlb2: add DLB v2.5 probe-time hardware init Thread-Index: AQHXGrKDVa+o/7Lr4E2bu4Hj9S22rKqOQhpQ Date: Sun, 21 Mar 2021 10:30:04 +0000 Message-ID: References: <20210316221857.2254-1-timothy.mcdaniel@intel.com> <20210316221857.2254-3-timothy.mcdaniel@intel.com> In-Reply-To: <20210316221857.2254-3-timothy.mcdaniel@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=marvell.com; x-originating-ip: [122.167.123.15] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: b12952b4-d84c-4f96-ed6c-08d8ec544aae x-ms-traffictypediagnostic: BY5PR18MB3300: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:854; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: qbaGNAaOIVg3JAaHTJsjnBkGnWzz47v35Ql8wCKusORGYvI5xCuJzKewtIt1z+y22N/nQHG7rao0SmM1F8OzcWnNAjRtMJXfApvzEHpqCqrpXaj71Nh7ymuCl35otkYww/jLE3BI6itFGtd2uY0bVIhn4Gifb2QPlt8iGIxh4MUBz7va7xMbja64BiSsotLhBVNWQOgjw4b2uJjPjKhph6ttYmlGVv5tE6dnJoJ6kg7fg+b6gjyYdC4uQaoUThkHeqirU/KjPCVZl3gcMSsK0iHkrLSodpbGA6KaCc5HmXa3lDbPNHWJm2+FwGHKiiuS+MeU8+Rv8cAZs1Kk0+/6Kbl/U+vXGw50iqrLcF7UbtkzJuU5T3pQzje+4N44bluNOZueA+b1BTVB6q00koUEG/GrG4eJOllKxGuijYRfHkdckzoIBiiM7J0arahMvvOfgXYxQsPfboWZmGu4nQz+rYgYRSs9iSlJu9bYHDve5huh96O+AH9E9uBOmUXYNuo50Tm391WmGW+R7zIXGPKYMUjWaff9MGXXgyXYT+PMkmN/BbQ6GrijDX+iA7giUd2MQ65m+yi0vdUbgT38HmGA32YLuRrp0mJcnUsjs3ADk1DIjUGBMOISESt03wqzkq8epvVDbJi4kKr5rv9pDT6+XYmf5Um/WkW9MhNFQqR1R1o= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR18MB2424.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(136003)(39850400004)(346002)(376002)(396003)(5660300002)(53546011)(6506007)(110136005)(33656002)(54906003)(52536014)(316002)(4326008)(38100700001)(9686003)(55016002)(2906002)(7416002)(66446008)(86362001)(66556008)(64756008)(76116006)(66946007)(83380400001)(8676002)(66476007)(7696005)(26005)(186003)(71200400001)(478600001)(8936002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?EfO0vvjEOwROZ4HSm0BZAAWiFKKvfEirPSLBzt5fT3JI34kajmlXTyz5NzPJ?= =?us-ascii?Q?LYPJfCoSUhaqhrrdZVVTr4zuqMOhrr6l8ztTfYKs3K4ZCP/aH/unpcWnzcHA?= =?us-ascii?Q?MduqaaUFpI/LLayI4ELPUV08YGJgx6HxcbPrtrJQouYAcHFQDsmg7dvNOmtX?= =?us-ascii?Q?2cbSPpGMIGS1Rk5fHxj+4Ng8Ql1iPB1wlIOt4kNG0ADKIJnD4L3BfImY3dRH?= =?us-ascii?Q?K4FhdF+gtOrVvhpDUJsA2wJrbbDJ2qOyiHeiwAgid/CpmLm7q7YwkN27X6lS?= =?us-ascii?Q?7eHTLIxuNyFzrI7h39bUEj4cG9TqMFZANqogRCpu/5900TKVNxxMMBoBPhDx?= =?us-ascii?Q?4pJwpbspJhFrZEAVgdy6v3RAEN866O7pwun/YBO/TXZxo3olcjW0HB/fdCK1?= =?us-ascii?Q?05w+d4VRTiXrwqq8nkrXlNO9e0dHS5TgFlP+wW7VvOp6oLDo+8fLyGcz4NFY?= =?us-ascii?Q?NadwfJMDLrGpkAqAd+Btya4puL16/bvWQOnVBDs3Xh+g6pPmUS12C9KvKteQ?= =?us-ascii?Q?ijbr6EoAExa6MXmS92XDdnWx/1Qp3/F9rve8JOvdAb194KP1LWc4xE90Bbcv?= =?us-ascii?Q?thRlwhtjUEgualNoBIlCrGi2W1hFAbbqz1npkMSiHBb4kdkenlfP2XCv9hTe?= =?us-ascii?Q?bFCJPz0ivKDPM2kdRB0V6gAiTTth4JP3YgCa8edBvY3vo4eTqwZwT6DetTXJ?= =?us-ascii?Q?LASCmAUQedKNArsndau6WfYXloPd/VHosS/xutsf1jh7HXXwmPGlq3izl5Z8?= =?us-ascii?Q?Suf58/3tRUtjpAR7tXWHEdg74/o3W5loPqxvBS7uwTZ3hErIQbgzEEJeqsCt?= =?us-ascii?Q?pte7CbnwAJeKDO4ILC859BAAOH608mkcW/S+4HUMyynNLbsCbq+CMKcTfEQX?= =?us-ascii?Q?63UGyDWaI3ycMxuoUDITHF3qFqtp/WApuKzrvOV54G+pLnmPRCPiwGrW/oqY?= =?us-ascii?Q?3EavGRO5smAcKDMoqAsfrI1HUqskuBddXzXbnLJ00nndKOJLxrsN2iwjkzoy?= =?us-ascii?Q?Mkydx27TB6IkwQJtKBX73OHooyCe3+bmcSS1aizgOjifSKixxG/2wAZNfM9Z?= =?us-ascii?Q?YNF3E8SgHAyU3locaXMJWgtv3EJm0fnhkHXIxDGxbjxJLac9UWkq5BxoC6ZF?= =?us-ascii?Q?qduB60VfF/npDwe/5+CpyihT6l+ltLYIvWK+Q9aKsKzOjJ3EUqKva/qri3Pf?= =?us-ascii?Q?+fJZ4z2A8dtsFFK5BBdYrol9wdylUgRzTk+ebsf6DVbH5LueQ+q3BPfaQWpU?= =?us-ascii?Q?dGd+hl2aqQpHLn78zixecujxB02HvjItp80V/UV+Do/nCeymEJ/yAAr99KZj?= =?us-ascii?Q?eDSrOWhm/ILgWa2HPbKBhL95?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR18MB2424.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b12952b4-d84c-4f96-ed6c-08d8ec544aae X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Mar 2021 10:30:04.6141 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Dk131sb8iXhZPdgmHgthWu7pkLvo+IqRwDHLRixZue+D136m3ImrImSGJk0DS0lCi1aLHoNqgF9G7/kTLh/U1A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR18MB3300 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.369, 18.0.761 definitions=2021-03-20_13:2021-03-19, 2021-03-20 signatures=0 Subject: Re: [dpdk-dev] [EXT] [PATCH 02/25] event/dlb2: add DLB v2.5 probe-time hardware init X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Timothy McDaniel > Sent: Wednesday, March 17, 2021 3:49 AM > To: dev@dpdk.org > Cc: Jerin Jacob Kollanukkaran ; > harry.van.haaren@intel.com; mdr@ashroe.eu; nhorman@tuxdriver.com; > nikhil.rao@intel.com; erik.g.carrillo@intel.com; abhinandan.gujjar@intel.= com; > Pavan Nikhilesh Bhagavatula ; > hemant.agrawal@nxp.com; mattias.ronnblom@ericsson.com; > peter.mccarthy@intel.com > Subject: [EXT] [PATCH 02/25] event/dlb2: add DLB v2.5 probe-time hardware > init Please simplify subject in all the patches like event/dlb2: add v2.5 HW init =20 =20 > ---------------------------------------------------------------------- > This commit adds support for DLB v2.5 probe-time hardware init, > and sets up a framework for incorporating the remaining > changes required to support DLB v2.5. >=20 > DLB v2.0 and DLB v2.5 are similar in many respects, but their > register offsets and definitions are different. As a result of these, > differences, the low level hardware functions must take the devicei s/devicei/device > version into consideration. This requires that the hardware version be > passed to many of the low level functions, so that the PMD can > take the appropriate action based on the device version. >=20 > To ease the transition and keep the individual patches small, three > temporary files are added in this commit. These files have "new" > in their names. The files with "new" contain changes specific to a > consolidated PMD that supports both DLB v2.0 and DLB 2.5. Their sister > files of the same name (minus "new") contain the old DLB v2.0 specific > code. The intent is to remove code from the original files as that code > is ported to the combined DLB 2.0/2.5 PMD model and added to the "new" > files in a series of commits. At end of the patch series, the old files > will be empty and the "new" files will have the logic needed > to implement a single PMD that supports both DLB v2.0 and DLB v2.5. > At that time, the original DLB v2.0 specific files will be deleted, > and the "new" files will be renamed and replace them. >=20 > Signed-off-by: Timothy McDaniel > --- > drivers/event/dlb2/dlb2_priv.h | 5 + > drivers/event/dlb2/meson.build | 1 + > .../event/dlb2/pf/base/dlb2_hw_types_new.h | 362 ++ > drivers/event/dlb2/pf/base/dlb2_mbox.h | 1 - > drivers/event/dlb2/pf/base/dlb2_osdep.h | 4 + > drivers/event/dlb2/pf/base/dlb2_regs_new.h | 4412 +++++++++++++++++ > drivers/event/dlb2/pf/base/dlb2_resource.c | 180 +- > drivers/event/dlb2/pf/base/dlb2_resource.h | 36 - > .../event/dlb2/pf/base/dlb2_resource_new.c | 271 + > .../event/dlb2/pf/base/dlb2_resource_new.h | 73 + > drivers/event/dlb2/pf/dlb2_main.c | 41 +- > drivers/event/dlb2/pf/dlb2_main.h | 4 + > drivers/event/dlb2/pf/dlb2_pf.c | 6 +- > 13 files changed, 5165 insertions(+), 231 deletions(-) > create mode 100644 drivers/event/dlb2/pf/base/dlb2_hw_types_new.h > create mode 100644 drivers/event/dlb2/pf/base/dlb2_regs_new.h > create mode 100644 drivers/event/dlb2/pf/base/dlb2_resource_new.c > create mode 100644 drivers/event/dlb2/pf/base/dlb2_resource_new.h >=20 > +#ifdef FPGA Don't do this. Either detect the FPGA presence or make it devargs > +#define DLB2_HZ 2000000 > +#else > +#define DLB2_HZ 800000000 > +#endif > + > + > +/* TEMPORARY inclusion of both headers for merge */ Please make sure to remove this comments in sub sequent patches. > b/drivers/event/dlb2/pf/dlb2_main.h > index f3bee71fb..01a24e8a4 100644 > --- a/drivers/event/dlb2/pf/dlb2_main.h > +++ b/drivers/event/dlb2/pf/dlb2_main.h > @@ -15,7 +15,11 @@ > #define PAGE_SIZE (sysconf(_SC_PAGESIZE)) Please use DPDK APIs for this. > #endif