From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id CE3CDA0471 for ; Thu, 18 Jul 2019 15:31:29 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A5DD01DBE; Thu, 18 Jul 2019 15:31:29 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by dpdk.org (Postfix) with ESMTP id 3DDE61C01 for ; Thu, 18 Jul 2019 15:31:28 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id x6IDUfXT019573 for ; Thu, 18 Jul 2019 06:31:26 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0818; bh=+Y3JwtMvO1Bd5/LxyS2U8iqJSRc4U11BYw5+RDSKAAI=; b=kCHTDQvR26AZrSbn8hnLhxcbh85Kue6P/WkYM9RE79yxrMza2lDfVr+Mm+mQIzxz3oLT 0rvbG6prJ494ArIqtncA/t53unfE6mPDzPMU6FxtA9L6wZMfxkPpjzgBsLzvxO8kQFFU GjFYjYmo+RsN9qr3h6pMqp3ePupzHiY0xYGZ2l7TKx7LXL7i8ie/LPw+6awi6H9dV9VS j3f1NoJHMlajWHbehfv6mHNsyCzzCi4v3YIthEvHq95fK1bKPJOvCnIIws/bi5USJ3H/ FtHYboi2z4nFrR4MHAtehZbVg7ssbtrXyrBlhMjQRp726RQb2TV5cZLg437GPv3Nwa+X zQ== Received: from sc-exch03.marvell.com ([199.233.58.183]) by mx0a-0016f401.pphosted.com with ESMTP id 2ts07vmuxd-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT) for ; Thu, 18 Jul 2019 06:31:26 -0700 Received: from SC-EXCH03.marvell.com (10.93.176.83) by SC-EXCH03.marvell.com (10.93.176.83) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Thu, 18 Jul 2019 06:31:25 -0700 Received: from NAM03-CO1-obe.outbound.protection.outlook.com (104.47.40.56) by SC-EXCH03.marvell.com (10.93.176.83) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Thu, 18 Jul 2019 06:31:25 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MAHaX7Rglh1QK56V7EMOt/gXTNQQMrm7ae81dO6upEOBp//wNl/R/n4Z6S8qpZyvLftkV4wBfzdhnyI4kb4D0y5FFns69wnlX5sN3IFiJ6Yxg1DzzPzTzHh2eXngRmKyYo8q1qxuKUigN3S7wjMmGUOhDCuLfGVnzHh9evfh8XmcqFHpurDpPKbRkj0pWLIQbM87gV3hHYVhEI14MfRTC+mPqJp0OH0+UajuVOZX1K2ZFwLSZG5ONlKCiHFSaU1HWbKrcR0Yb5KWP3hKXqwGSBkXGmsi2qzZYxRu3bj1VGXAaFJ9jfD9mudEXxYMp3NrTgWi4Ud7t0cqyoC6rTaFhg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+Y3JwtMvO1Bd5/LxyS2U8iqJSRc4U11BYw5+RDSKAAI=; b=Thr4rg/hDd6z9whBlUsPnvfc1EJq+whw0boxpzq4xQyRZGS6JeDMYyE1yNgtC1YBPesHrYz92bxpeajEwHGZjxze9wI1vXb92YOx64GrLd0b6BfA09LzXCXEwGUyi2jJDuuw+GUmoha3nWxhQB5YugvhAcswN24Pt6V2mrST2Q2E0EZKPnopsTB3wMl+JnZVTKtDJegTtVGBLVnEV62frMAEGKiB+/GMm2WLPxXGIMqwnGEST76h7BlGc5tXiVo8WiMDe7SmSerUwwJKS9/mXEIHhTLTyo/HbskvsQfSWcJnczjL9pJ8AjLvYGuBTra082eqeEV+iErCXsrBU/J9CQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=marvell.com;dmarc=pass action=none header.from=marvell.com;dkim=pass header.d=marvell.com;arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector2-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+Y3JwtMvO1Bd5/LxyS2U8iqJSRc4U11BYw5+RDSKAAI=; b=oAq7kAjJ4MmM1+uAAYRxQeZjgnx98pGWPryj+yOu+oP4QXPLxg1CIRyY6fC1HWnPyWBA0KBqTHMCduXxa6XHbvcBXf+9qKKt/YBvySzGrJhyChyLqPZTVsp5nnvLrd9xf0D+/Snel7BZ8+icz6vy6cixgoifSmpwdBB5laldIxw= Received: from BYAPR18MB2424.namprd18.prod.outlook.com (20.179.91.149) by BYAPR18MB2584.namprd18.prod.outlook.com (20.179.93.213) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2073.14; Thu, 18 Jul 2019 13:31:22 +0000 Received: from BYAPR18MB2424.namprd18.prod.outlook.com ([fe80::2d42:12b6:aa2e:2862]) by BYAPR18MB2424.namprd18.prod.outlook.com ([fe80::2d42:12b6:aa2e:2862%4]) with mapi id 15.20.2073.012; Thu, 18 Jul 2019 13:31:22 +0000 From: Jerin Jacob Kollanukkaran To: Nithin Kumar Dabilpuram , Nithin Kumar Dabilpuram , Kiran Kumar Kokkilagadda CC: "dev@dpdk.org" Thread-Topic: [PATCH] net/octeontx2: add build check on fast path fields Thread-Index: AQHVPWoelYEKmu81fUCCeCuvCDTNJ6bQXlew Date: Thu, 18 Jul 2019 13:31:22 +0000 Message-ID: References: <20190718130931.99036-1-ndabilpuram@marvell.com> In-Reply-To: <20190718130931.99036-1-ndabilpuram@marvell.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [106.200.248.176] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 8ebcc10d-91b3-4e3f-f69b-08d70b8439c9 x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(2017052603328)(7193020); SRVR:BYAPR18MB2584; x-ms-traffictypediagnostic: BYAPR18MB2584: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4714; x-forefront-prvs: 01026E1310 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(39860400002)(396003)(346002)(136003)(376002)(366004)(199004)(189003)(13464003)(6636002)(25786009)(2906002)(33656002)(74316002)(478600001)(86362001)(66476007)(3846002)(9686003)(6436002)(6116002)(55016002)(4326008)(6246003)(476003)(229853002)(71190400001)(71200400001)(76176011)(5660300002)(6506007)(53546011)(446003)(186003)(305945005)(7696005)(11346002)(256004)(26005)(68736007)(7736002)(8936002)(316002)(66066001)(110136005)(102836004)(99286004)(8676002)(64756008)(81166006)(486006)(53936002)(81156014)(66946007)(76116006)(52536014)(14454004)(66446008)(66556008); DIR:OUT; SFP:1101; SCL:1; SRVR:BYAPR18MB2584; H:BYAPR18MB2424.namprd18.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: M7EAbScOWsRBJViRSG+8s4A8xNsqYRU3H7uQWAqnqdEODxz9nPCq1BAOyxnb2CW2+4TDi+l0E6VdYEOQVpIjDlV2EMndHqFYaTLY+LY9m6A4ak1RVZEYUPxN9JWeNGmOoyL6hZJ+x1I77HrBASGxwube0RJnztUozRjeNxS4qcmD4L+r1wMCDDDxXg0WY3zy8P7JvusGRYa0SXCnFSE5IPEB5GHi1Z6v3Xys9T30/XNj15rWIPcJ+TVU4WC3GBykQvc1oP31LaDXyJ5sC2VIVW7shZNrjrE33ACJ7LzqLa3nqF88ZgGlAomVtvAtQnOpKptb9YVYh1LMmnWddopx9P7tRPvCeOS4qe1itALr1BQtyEsEiVB1QC5fPCnhXc0kB4kGi0IoZogVvMx4gx5yuClptYKQ+v5ibsyQWFF+U2I= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 8ebcc10d-91b3-4e3f-f69b-08d70b8439c9 X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Jul 2019 13:31:22.8031 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: jerinj@marvell.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR18MB2584 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:5.22.84,1.0.8 definitions=2019-07-18_06:2019-07-18,2019-07-18 signatures=0 Subject: Re: [dpdk-dev] [PATCH] net/octeontx2: add build check on fast path fields X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Nithin Dabilpuram > Sent: Thursday, July 18, 2019 6:40 PM > To: Jerin Jacob Kollanukkaran ; Nithin Kumar > Dabilpuram ; Kiran Kumar Kokkilagadda > > Cc: dev@dpdk.org > Subject: [PATCH] net/octeontx2: add build check on fast path fields >=20 > Add build bug on on fast path used fields that are dependent on their > positions and values. >=20 > Fixes: 920717e4d8ba ("net/octeontx2: add device start operation") Please point Fixes changes where we can add the fast path code. > Cc: ndabilpuram@marvell.com This Cc can be removed as you are the author. >=20 > Signed-off-by: Nithin Dabilpuram > --- > drivers/net/octeontx2/otx2_ethdev.c | 18 ++++++++++++++++++ > 1 file changed, 18 insertions(+) >=20 > diff --git a/drivers/net/octeontx2/otx2_ethdev.c > b/drivers/net/octeontx2/otx2_ethdev.c > index fcb1869..77bf9aa 100644 > --- a/drivers/net/octeontx2/otx2_ethdev.c > +++ b/drivers/net/octeontx2/otx2_ethdev.c > @@ -586,6 +586,24 @@ nix_tx_offload_flags(struct rte_eth_dev *eth_dev) > RTE_BUILD_BUG_ON(PKT_TX_TCP_CKSUM !=3D (1ULL << 52)); > RTE_BUILD_BUG_ON(PKT_TX_SCTP_CKSUM !=3D (2ULL << 52)); > RTE_BUILD_BUG_ON(PKT_TX_UDP_CKSUM !=3D (3ULL << 52)); > + RTE_BUILD_BUG_ON(PKT_TX_IP_CKSUM !=3D (1ULL << 54)); > + RTE_BUILD_BUG_ON(PKT_TX_IPV4 !=3D (1ULL << 55)); > + RTE_BUILD_BUG_ON(PKT_TX_OUTER_IP_CKSUM !=3D (1ULL << 58)); > + RTE_BUILD_BUG_ON(PKT_TX_OUTER_IPV4 !=3D (1ULL << 59)); > + RTE_BUILD_BUG_ON(PKT_TX_OUTER_IPV6 !=3D (1ULL << 60)); > + RTE_BUILD_BUG_ON(PKT_TX_OUTER_UDP_CKSUM !=3D (1ULL << > 41)); > + RTE_BUILD_BUG_ON(RTE_MBUF_L2_LEN_BITS !=3D 7); > + RTE_BUILD_BUG_ON(RTE_MBUF_L3_LEN_BITS !=3D 9); > + RTE_BUILD_BUG_ON(RTE_MBUF_OUTL2_LEN_BITS !=3D 7); > + RTE_BUILD_BUG_ON(RTE_MBUF_OUTL3_LEN_BITS !=3D 9); > + RTE_BUILD_BUG_ON(offsetof(struct rte_mbuf, data_off) !=3D > + offsetof(struct rte_mbuf, buf_iova) + 8); > + RTE_BUILD_BUG_ON(offsetof(struct rte_mbuf, ol_flags) !=3D > + offsetof(struct rte_mbuf, buf_iova) + 16); > + RTE_BUILD_BUG_ON(offsetof(struct rte_mbuf, pkt_len) !=3D > + offsetof(struct rte_mbuf, ol_flags) + 12); > + RTE_BUILD_BUG_ON(offsetof(struct rte_mbuf, tx_offload) !=3D > + offsetof(struct rte_mbuf, pool) + 2 * sizeof(void *)); >=20 > if (conf & DEV_TX_OFFLOAD_VLAN_INSERT || > conf & DEV_TX_OFFLOAD_QINQ_INSERT) > -- > 2.8.4