* [dpdk-dev] [PATCH] doc: announce lcore_config symbol removal
@ 2019-07-31 11:06 David Marchand
2019-07-31 13:48 ` Stephen Hemminger
` (3 more replies)
0 siblings, 4 replies; 7+ messages in thread
From: David Marchand @ 2019-07-31 11:06 UTC (permalink / raw)
To: dev; +Cc: thomas, stephen, bruce.richardson
New accessors have been introduced to provide the hidden information.
This symbol can now be kept internal.
Signed-off-by: David Marchand <david.marchand@redhat.com>
---
doc/guides/rel_notes/deprecation.rst | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
index 37b8592..b18de70 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -23,6 +23,10 @@ Deprecation Notices
* eal: The function ``rte_eal_remote_launch`` will return new error codes
after read or write error on the pipe, instead of calling ``rte_panic``.
+* eal: the ``lcore_config`` struct and global symbol will be made private to
+ remove it from the externally visible ABI and allow it to be updated in the
+ future.
+
* eal: both declaring and identifying devices will be streamlined in v18.11.
New functions will appear to query a specific port from buses, classes of
device and device drivers. Device declaration will be made coherent with the
--
1.8.3.1
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [dpdk-dev] [PATCH] doc: announce lcore_config symbol removal
2019-07-31 11:06 [dpdk-dev] [PATCH] doc: announce lcore_config symbol removal David Marchand
@ 2019-07-31 13:48 ` Stephen Hemminger
2019-07-31 14:23 ` Bruce Richardson
` (2 subsequent siblings)
3 siblings, 0 replies; 7+ messages in thread
From: Stephen Hemminger @ 2019-07-31 13:48 UTC (permalink / raw)
To: David Marchand; +Cc: dev, thomas, bruce.richardson
On Wed, 31 Jul 2019 13:06:17 +0200
David Marchand <david.marchand@redhat.com> wrote:
> New accessors have been introduced to provide the hidden information.
> This symbol can now be kept internal.
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
> doc/guides/rel_notes/deprecation.rst | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
> index 37b8592..b18de70 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -23,6 +23,10 @@ Deprecation Notices
> * eal: The function ``rte_eal_remote_launch`` will return new error codes
> after read or write error on the pipe, instead of calling ``rte_panic``.
>
> +* eal: the ``lcore_config`` struct and global symbol will be made private to
> + remove it from the externally visible ABI and allow it to be updated in the
> + future.
> +
> * eal: both declaring and identifying devices will be streamlined in v18.11.
> New functions will appear to query a specific port from buses, classes of
> device and device drivers. Device declaration will be made coherent with the
Acked-by: Stephen Hemminger <stephen@networkplumber.org>
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [dpdk-dev] [PATCH] doc: announce lcore_config symbol removal
2019-07-31 11:06 [dpdk-dev] [PATCH] doc: announce lcore_config symbol removal David Marchand
2019-07-31 13:48 ` Stephen Hemminger
@ 2019-07-31 14:23 ` Bruce Richardson
2019-07-31 14:27 ` Jerin Jacob Kollanukkaran
2019-08-06 13:52 ` Andrew Rybchenko
2019-08-08 9:31 ` [dpdk-dev] [PATCH v2] " David Marchand
3 siblings, 1 reply; 7+ messages in thread
From: Bruce Richardson @ 2019-07-31 14:23 UTC (permalink / raw)
To: David Marchand; +Cc: dev, thomas, stephen
On Wed, Jul 31, 2019 at 01:06:17PM +0200, David Marchand wrote:
> New accessors have been introduced to provide the hidden information.
> This symbol can now be kept internal.
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [dpdk-dev] [PATCH] doc: announce lcore_config symbol removal
2019-07-31 14:23 ` Bruce Richardson
@ 2019-07-31 14:27 ` Jerin Jacob Kollanukkaran
0 siblings, 0 replies; 7+ messages in thread
From: Jerin Jacob Kollanukkaran @ 2019-07-31 14:27 UTC (permalink / raw)
To: Bruce Richardson, David Marchand; +Cc: dev, thomas, stephen
> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Bruce Richardson
> Sent: Wednesday, July 31, 2019 7:53 PM
> To: David Marchand <david.marchand@redhat.com>
> Cc: dev@dpdk.org; thomas@monjalon.net; stephen@networkplumber.org
> Subject: Re: [dpdk-dev] [PATCH] doc: announce lcore_config symbol removal
>
> On Wed, Jul 31, 2019 at 01:06:17PM +0200, David Marchand wrote:
> > New accessors have been introduced to provide the hidden information.
> > This symbol can now be kept internal.
> >
> > Signed-off-by: David Marchand <david.marchand@redhat.com>
> > ---
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>
Acked-by: Jerin Jacob <jerinj@marvell.com>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [dpdk-dev] [PATCH] doc: announce lcore_config symbol removal
2019-07-31 11:06 [dpdk-dev] [PATCH] doc: announce lcore_config symbol removal David Marchand
2019-07-31 13:48 ` Stephen Hemminger
2019-07-31 14:23 ` Bruce Richardson
@ 2019-08-06 13:52 ` Andrew Rybchenko
2019-08-08 9:31 ` [dpdk-dev] [PATCH v2] " David Marchand
3 siblings, 0 replies; 7+ messages in thread
From: Andrew Rybchenko @ 2019-08-06 13:52 UTC (permalink / raw)
To: David Marchand, dev; +Cc: thomas, stephen, bruce.richardson
On 7/31/19 2:06 PM, David Marchand wrote:
> New accessors have been introduced to provide the hidden information.
> This symbol can now be kept internal.
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
Acked-by: Andrew Rybchenko <arybchenko@solarflare.com>
^ permalink raw reply [flat|nested] 7+ messages in thread
* [dpdk-dev] [PATCH v2] doc: announce lcore_config symbol removal
2019-07-31 11:06 [dpdk-dev] [PATCH] doc: announce lcore_config symbol removal David Marchand
` (2 preceding siblings ...)
2019-08-06 13:52 ` Andrew Rybchenko
@ 2019-08-08 9:31 ` David Marchand
2019-08-08 15:47 ` Thomas Monjalon
3 siblings, 1 reply; 7+ messages in thread
From: David Marchand @ 2019-08-08 9:31 UTC (permalink / raw)
To: dev; +Cc: thomas, stephen, bruce.richardson, jerinj, arybchenko
New accessors have been introduced to provide the hidden information.
This symbol can now be kept internal.
Signed-off-by: David Marchand <david.marchand@redhat.com>
Acked-by: Stephen Hemminger <stephen@networkplumber.org>
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
Acked-by: Jerin Jacob <jerinj@marvell.com>
Acked-by: Andrew Rybchenko <arybchenko@solarflare.com>
---
Changelog since v1:
- added acks,
- fixed little typo,
---
doc/guides/rel_notes/deprecation.rst | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
index 70fef52..ee15ab6 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -23,6 +23,10 @@ Deprecation Notices
* eal: The function ``rte_eal_remote_launch`` will return new error codes
after read or write error on the pipe, instead of calling ``rte_panic``.
+* eal: The ``lcore_config`` struct and global symbol will be made private to
+ remove it from the externally visible ABI and allow it to be updated in the
+ future.
+
* eal: both declaring and identifying devices will be streamlined in v18.11.
New functions will appear to query a specific port from buses, classes of
device and device drivers. Device declaration will be made coherent with the
--
1.8.3.1
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [dpdk-dev] [PATCH v2] doc: announce lcore_config symbol removal
2019-08-08 9:31 ` [dpdk-dev] [PATCH v2] " David Marchand
@ 2019-08-08 15:47 ` Thomas Monjalon
0 siblings, 0 replies; 7+ messages in thread
From: Thomas Monjalon @ 2019-08-08 15:47 UTC (permalink / raw)
To: David Marchand; +Cc: dev, stephen, bruce.richardson, jerinj, arybchenko
08/08/2019 11:31, David Marchand:
> New accessors have been introduced to provide the hidden information.
> This symbol can now be kept internal.
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> Acked-by: Stephen Hemminger <stephen@networkplumber.org>
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>
> Acked-by: Jerin Jacob <jerinj@marvell.com>
> Acked-by: Andrew Rybchenko <arybchenko@solarflare.com>
Acked-by: Thomas Monjalon <thomas@monjalon.net>
Applied, thanks
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2019-08-08 15:47 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-31 11:06 [dpdk-dev] [PATCH] doc: announce lcore_config symbol removal David Marchand
2019-07-31 13:48 ` Stephen Hemminger
2019-07-31 14:23 ` Bruce Richardson
2019-07-31 14:27 ` Jerin Jacob Kollanukkaran
2019-08-06 13:52 ` Andrew Rybchenko
2019-08-08 9:31 ` [dpdk-dev] [PATCH v2] " David Marchand
2019-08-08 15:47 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).