DPDK patches and discussions
 help / color / mirror / Atom feed
From: Jerin Jacob Kollanukkaran <jerinj@marvell.com>
To: "Mattias Rönnblom" <mattias.ronnblom@ericsson.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
	"niclas.storm@ericsson.com" <niclas.storm@ericsson.com>,
	"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [EXT] [PATCH] event/dsw: immediately flush buffers on zero-sized enqueue
Date: Tue, 14 Jan 2020 17:24:55 +0000	[thread overview]
Message-ID: <BYAPR18MB2424ABAAD53A3D4E3974438BC8340@BYAPR18MB2424.namprd18.prod.outlook.com> (raw)
In-Reply-To: <20191217111344.27468-1-mattias.ronnblom@ericsson.com>



> -----Original Message-----
> From: Mattias Rönnblom <mattias.ronnblom@ericsson.com>
> Sent: Tuesday, December 17, 2019 4:44 PM
> To: Jerin Jacob Kollanukkaran <jerinj@marvell.com>
> Cc: dev@dpdk.org; niclas.storm@ericsson.com; Mattias Rönnblom
> <mattias.ronnblom@ericsson.com>; stable@dpdk.org
> Subject: [EXT] [PATCH] event/dsw: immediately flush buffers on zero-sized
> enqueue
> Fix DSW's rte_event_enqueue_burst(), so that a call with a zero-sized event
> array immediately flushes the port's output buffers. Prior to this patch, the
> flush operation would be deferred to the next enqueue or dequeue call, which
> is inconsistent with DSW documentation.
> 
> Fixes: 1c8e3caa3bfb ("event/dsw: add event scheduling and device start/stop")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Mattias Rönnblom <mattias.ronnblom@ericsson.com>

Applied to dpdk-next-eventdev/master. Thanks.


> ---
>  drivers/event/dsw/dsw_event.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/event/dsw/dsw_event.c b/drivers/event/dsw/dsw_event.c
> index 61a66fabf..1641c2d06 100644
> --- a/drivers/event/dsw/dsw_event.c
> +++ b/drivers/event/dsw/dsw_event.c
> @@ -1047,6 +1047,7 @@ dsw_event_enqueue_burst_generic(void *port,
> const struct rte_event events[],
>  	 */
>  	if (unlikely(events_len == 0)) {
>  		dsw_port_note_op(source_port,
> DSW_MAX_PORT_OPS_PER_BG_TASK);
> +		dsw_port_flush_out_buffers(dsw, port);
>  		return 0;
>  	}
> 
> --
> 2.17.1


      reply	other threads:[~2020-01-14 17:25 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-17 11:13 [dpdk-dev] " Mattias Rönnblom
2020-01-14 17:24 ` Jerin Jacob Kollanukkaran [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BYAPR18MB2424ABAAD53A3D4E3974438BC8340@BYAPR18MB2424.namprd18.prod.outlook.com \
    --to=jerinj@marvell.com \
    --cc=dev@dpdk.org \
    --cc=mattias.ronnblom@ericsson.com \
    --cc=niclas.storm@ericsson.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).