From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 9E872A05D3 for ; Wed, 22 May 2019 16:25:23 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 660582C39; Wed, 22 May 2019 16:25:21 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by dpdk.org (Postfix) with ESMTP id 2631FA49; Wed, 22 May 2019 16:25:19 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x4MEP4WP032643; Wed, 22 May 2019 07:25:18 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0818; bh=qna/z2hE9mn1/MbnlGtc1FndCdjodLQugmtcCxJaVuM=; b=h2UXLShcn/TIkwiT64jMkHoI/lpmHnLgEXCRYS2hg0IqXL58CFT8gxtGKc9Ih7calsuK 4XCwvT0sdwhVLhjpbeEKsMqBw/jTQe+/z5VvP9ePqwo0g6FYW1tIGED7CJvgTyzGYCdv 5xjR6zyEBo/CUJDvmNUCnZ9y6B1CwGpRDLAR2oRj3n8Tf3BKehVQVzNKKMDEaQCMLPg/ B3Ph8oJJrZcYjZzANrJ94q19svW6HuMyaTXTKh5HFtu/WyW5qbtR0r1pA3PFpHsVbyuF Hn5j9VQQElQCGMxUXtNooHV49AdIKgPCCn12m+AHT7Vdc/M/Vc61L5P19sACBnEGNzRi 4g== Received: from sc-exch04.marvell.com ([199.233.58.184]) by mx0b-0016f401.pphosted.com with ESMTP id 2smnwjvvsn-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Wed, 22 May 2019 07:25:17 -0700 Received: from SC-EXCH02.marvell.com (10.93.176.82) by SC-EXCH04.marvell.com (10.93.176.84) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Wed, 22 May 2019 07:25:15 -0700 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (104.47.36.51) by SC-EXCH02.marvell.com (10.93.176.82) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Wed, 22 May 2019 07:25:15 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector2-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qna/z2hE9mn1/MbnlGtc1FndCdjodLQugmtcCxJaVuM=; b=dx2ZD8Ap+lcbT2yzOpGV5VXf7Uc0IdroA9peiaCgOKT26hi+QTb38mIl20cHE0/viJfGiAiBfoKw9WPQz27acHQ8kSknccRl1+G5uLiFlalSPcGzBFPZK/Fpe6yyhDVM++kxV1omUWjHA6QQwUMCtneXYIcOzIyTxggeGavmmtY= Received: from BYAPR18MB2424.namprd18.prod.outlook.com (20.179.91.149) by BYAPR18MB2824.namprd18.prod.outlook.com (20.179.57.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1922.15; Wed, 22 May 2019 14:25:14 +0000 Received: from BYAPR18MB2424.namprd18.prod.outlook.com ([fe80::1ce4:557d:eeb8:843c]) by BYAPR18MB2424.namprd18.prod.outlook.com ([fe80::1ce4:557d:eeb8:843c%7]) with mapi id 15.20.1900.020; Wed, 22 May 2019 14:25:14 +0000 From: Jerin Jacob Kollanukkaran To: Neil Horman CC: Bruce Richardson , "dev@dpdk.org" , "thomas@monjalon.net" , "stable@dpdk.org" Thread-Topic: [EXT] Re: [dpdk-dev] Re: [PATCH] devtools: skip the symbol check when map file under drivers Thread-Index: AdUQoxX6c+w8Qg2aQN+DesCxp18kDgABSIsAAABNFlA= Date: Wed, 22 May 2019 14:25:14 +0000 Message-ID: References: <20190522141116.GD18629@hmswarspite.think-freely.org> In-Reply-To: <20190522141116.GD18629@hmswarspite.think-freely.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [106.201.57.97] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 24c95ddf-80d5-4dec-d64f-08d6dec14e4a x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(5600141)(711020)(4605104)(2017052603328)(7193020); SRVR:BYAPR18MB2824; x-ms-traffictypediagnostic: BYAPR18MB2824: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-forefront-prvs: 0045236D47 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(39860400002)(366004)(396003)(136003)(346002)(376002)(13464003)(189003)(199004)(33656002)(66066001)(81166006)(81156014)(316002)(2906002)(5660300002)(4326008)(25786009)(6246003)(52536014)(8676002)(8936002)(14454004)(305945005)(6916009)(53936002)(7736002)(6436002)(9686003)(478600001)(11346002)(76116006)(71200400001)(71190400001)(55016002)(446003)(476003)(68736007)(55236004)(74316002)(53546011)(66946007)(256004)(14444005)(6506007)(102836004)(229853002)(186003)(66556008)(486006)(7696005)(54906003)(73956011)(26005)(66446008)(66476007)(64756008)(99286004)(76176011)(86362001)(6116002)(3846002); DIR:OUT; SFP:1101; SCL:1; SRVR:BYAPR18MB2824; H:BYAPR18MB2424.namprd18.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: N/jSF4Nh/PwoD/0Cl2T7LkQ2bUe+4LNMfruTYvBMjhO0/nA681BAzT9pnfFwAwYS1L0tlBcZYagj9ncuNVa8f233VsqwjHCFxpvn4N2jNe8u7PLaLkbq2R2qI4fhFem1HB041enPj4/CIVntbk0R61cHmpjey3T+bxfmlilTmJ9iF8/8gyrLJ+b2NcVJXkfJKKt0VjCzHSbIZtmlaVTNOH15gnaCZMpNQH9TFJsWKp5T78JRQEZY8AC9AAfUt/cVjZoKwY/QIBfK7sOmAH9EvCg9gso4nni+gTat4mQv7i+ry2X5zig+Z0DokUhp8TG/vDil6o/UqD5czoVzCgKaK6jHpT51Oh1/gtqJOZGhqlimokEQJrBJwY32Nsr+jQDpP83TLtM8252RV1u/u1hfFBpOSIE5m0tcCvP99fnwxC8= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 24c95ddf-80d5-4dec-d64f-08d6dec14e4a X-MS-Exchange-CrossTenant-originalarrivaltime: 22 May 2019 14:25:14.1386 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR18MB2824 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2019-05-22_07:, , signatures=0 Subject: Re: [dpdk-dev] [EXT] Re: Re: [PATCH] devtools: skip the symbol check when map file under drivers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Neil Horman > Sent: Wednesday, May 22, 2019 7:41 PM > To: Jerin Jacob Kollanukkaran > Cc: Bruce Richardson ; dev@dpdk.org; > thomas@monjalon.net; stable@dpdk.org > Subject: [EXT] Re: [dpdk-dev] Re: [PATCH] devtools: skip the symbol check > when map file under drivers >=20 > External Email >=20 > ---------------------------------------------------------------------- > On Wed, May 22, 2019 at 01:41:03PM +0000, Jerin Jacob Kollanukkaran wrote= : > > > -----Original Message----- > > > From: Neil Horman > > > Sent: Wednesday, May 22, 2019 6:43 PM > > > To: Jerin Jacob Kollanukkaran > > > Cc: Bruce Richardson ; dev@dpdk.org; > > > thomas@monjalon.net; stable@dpdk.org > > > Subject: [EXT] Re: [dpdk-dev] Re: [PATCH] devtools: skip the symbol > > > check when map file under drivers > > > > > > External Email > > > > > > -------------------------------------------------------------------- > > > -- On Wed, May 22, 2019 at 11:54:13AM +0000, Jerin Jacob > > > Kollanukkaran > > > wrote: > > > > > -----Original Message----- > > > > > From: Bruce Richardson > > > > > Sent: Wednesday, May 22, 2019 4:21 PM > > > > > To: Jerin Jacob Kollanukkaran > > > > > Cc: Neil Horman ; dev@dpdk.org; > > > > > thomas@monjalon.net; stable@dpdk.org > > > > > Subject: Re: [dpdk-dev] [EXT] Re: [PATCH] devtools: skip the > > > > > symbol check when map file under drivers > > > > > > > > > > > > Sorry, but I'm not ok with this, because many of our DPDK > > > > > > > PMDs have functions that get exported which are meant to be > > > > > > > called by applications directly. The > > > > > > > > > > > > OK. Just to update my knowledge, Should those API needs to go > > > > > > through ABI/API depreciation process? > > > > > > > > > > > > Actually, I am concerned about the APIs, which is called > > > > > > between drviers not the application. For example, > > > > > > drivers/common/dpaax/rte_common_dpaax_version.map > > > > > > > > > > > > it is not interface to application rather it is for intra drive= r case. > > > > > > I think, I can change my logic to Skip the symbols which NOT > > > > > > starting with > > > > > rte_. > > > > > > Agree? > > > > > > > > > > > > Context: > > > > > > I am adding a new driver/common/octeontx2 directory and it has > > > > > > some API which Needs to shared between drivers not to the > > > > > > application. For me, it does not make sense to go through any > > > > > > ABI > > > process in such case. > > > > > > > > > > > > > > > > > Maybe not, but other drivers will have APIs designed for apps to > > > > > call directly - some NIC drivers have them, and I suspect that > > > > > rawdev drivers will need them a lot. Therefore, it's best to > > > > > have the drivers directory scanned by our tooling. > > > > > > > > Agreed. But all of those API which called directly called from > > > > application is starts with rte_ symbol. How about skipping the > > > > symbols which is NOT start with rte_* > > > > example: > > > > drivers/common/octeontx/rte_common_octeontx_version.map > > > > drivers/common/dpaax/rte_common_dpaax_version.map > > > > > > > > > > No, that won't work. If you export a function, it doesn't matter if > > > its named > > > rte_* or not. Its accessible from any library/application that > > > cares to call it, > > > > IMO, The name prefix matters. The rte_* should denote it a DPDK API > > and application suppose to use it. > > > It doesn't, its just a convention. We have no documentation that indicat= es > what the meaning of an rte_* prefix is specficially, above and beyond the > fact thats how we name functions in the DPDK. If you want to submit a pa= tch > to formalize the meaning of function prefixes, you're welcome too (though= I > won't support it, perhaps others will). But even if you do, it doesn't a= ddress > the underlying problem, which is that applications still have access to t= hose > symbols. > Maintaining an ABI by assertion of prefix is really a lousy way to commun= icate > what functions should be accessed by an application and which shouldn't. = If > a function is exported, and included in the header file, people will try = to use The current scheme in the driver/common is that, the header files are NOT m= ade It as public ie not installed make install. The consumer driver includes that using relative path wrt DPDK source direc= tory.=20 Anyway I will add experimental section to make tool happy.