From: Jerin Jacob Kollanukkaran <jerinj@marvell.com>
To: "Mattias Rönnblom" <mattias.ronnblom@ericsson.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2] event/dsw: avoid credit leak on oversized enqueue bursts
Date: Tue, 14 Jan 2020 19:46:04 +0000 [thread overview]
Message-ID: <BYAPR18MB2424E5EB4273F158A48A0748C8340@BYAPR18MB2424.namprd18.prod.outlook.com> (raw)
> -----Original Message-----
> From: Mattias Rönnblom <mattias.ronnblom@ericsson.com>
> Sent: Tuesday, January 14, 2020 11:34 PM
> To: Jerin Jacob Kollanukkaran <jerinj@marvell.com>
> Cc: dev@dpdk.org; Mattias Rönnblom <mattias.ronnblom@ericsson.com>;
> stable@dpdk.org
> Subject: [EXT] [PATCH v2] event/dsw: avoid credit leak on oversized enqueue
> bursts
>
> If an application issues rte_event_enqueue_new_burst() or
> rte_event_enqueue_forward_burst() call with a burst of events longer than the
> configured max enqueue burst size, DSW allocates credits not only for events
> actually enqueued, but for the complete burst. If this process is repeated,
> enough credits will have leaked to cause the event device to backpressure (i.e.
> disallow) any new enqueue operations.
>
> In addition, the port-level enqueue xstats will log the wrong number of events
> enqueued for oversized enqueues.
>
> This patch makes DSW gracefully handle oversized enqueue bursts.
>
> Fixes: 1c8e3caa3bfb ("event/dsw: add event scheduling and device start/stop")
> Cc: stable@dpdk.org
>
> Signed-off-by: Mattias Rönnblom <mattias.ronnblom@ericsson.com>
Please add the change log when sending the incremental versions.
v2:
# Fix the following reported compilation error.
http://mails.dpdk.org/archives/dev/2020-January/155161.html
Applied to dpdk-next-eventdev/master. Thanks.
next reply other threads:[~2020-01-14 19:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-14 19:46 Jerin Jacob Kollanukkaran [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-01-14 17:32 [dpdk-dev] [EXT] [PATCH] " Jerin Jacob Kollanukkaran
2020-01-14 18:03 ` [dpdk-dev] [PATCH v2] " Mattias Rönnblom
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BYAPR18MB2424E5EB4273F158A48A0748C8340@BYAPR18MB2424.namprd18.prod.outlook.com \
--to=jerinj@marvell.com \
--cc=dev@dpdk.org \
--cc=mattias.ronnblom@ericsson.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).