From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8030AA00E6 for ; Thu, 8 Aug 2019 10:54:22 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 503532C60; Thu, 8 Aug 2019 10:54:22 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by dpdk.org (Postfix) with ESMTP id 4D4782B87; Thu, 8 Aug 2019 10:54:21 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id x788o3rF006996; Thu, 8 Aug 2019 01:54:20 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0818; bh=bbpACNr/ndHk6uVITa3ae3wxC1JjcMJ9hUHCSQFcaTc=; b=lScEJpP0EtFaKGpFs2mhn2Qu7ApmD4jSFyAn0W79+oAIXq6J6LvwcQtFigW7kI+4nkgl TXfGjT1xnOiC0UR+kC6N0eBlDgHp0PdvCi357n7Wc70T3BKBKVQJKN7xdQfDpPPC+uJf 0AIUABzqOPfANM9vGbU+cWEkaUY4UfbHGtTniI4JXzoEGhIgwflYXv4pNlqyyv0RS5fb 2drnLNiVhDqnAgI2zVoRHuQCwABTS4WnbXjW/imd73PIC1B8kFAID+zH9XLfGSham1t8 hOIGZPeKfZFltRZoV62AHKfcJBWyX5+zrb3xawfbC5FlMYCwr+rX4w2XkXlkKoLnfEAW xA== Received: from sc-exch01.marvell.com ([199.233.58.181]) by mx0b-0016f401.pphosted.com with ESMTP id 2u59sm2v96-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Thu, 08 Aug 2019 01:54:20 -0700 Received: from SC-EXCH02.marvell.com (10.93.176.82) by SC-EXCH01.marvell.com (10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Thu, 8 Aug 2019 01:54:18 -0700 Received: from NAM02-CY1-obe.outbound.protection.outlook.com (104.47.37.50) by SC-EXCH02.marvell.com (10.93.176.82) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Thu, 8 Aug 2019 01:54:18 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YKM0y5kiZDKuEVxN1O+5ItZKi5g5d65f/0byp3tV+KBI3qP2MiJy8S0DIijMhvLC6Ttc0vQrac4RkaVHDRwnWO0zquhGHJZHrNFucDHSsxfwU3mp2h+eVzmonQntGPWbPR0k9HpP1IFmaORBN/f4MPW44ssNioNXl/8AMlh+tOq0ePsgdSdNM4Ylcm5MKS48rDF1h7Hhhnm/Gmz7g1Eo9jS3cP3H6lizXZ8DgfcRqozzVaJaKiyxkjR/MnYY9mTQVD8jdZEO6ahI3RJryUz/GCR8q9H+6FYGuHT5S+Sr9ryiYlHsR55z8HF4pMnAgPt5dR7pbKelFtNXnGzCg2p5nA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bbpACNr/ndHk6uVITa3ae3wxC1JjcMJ9hUHCSQFcaTc=; b=DNHKrS8LuV4tlGFm/HTC0X0LsFeUHEBGXb/Fjs8xVZHLMoQ8+8XUgOfIF9xFWJ2tmDkk3BJgI/hj+qzMK/mOKRFKAeVGDp/gUzJAx77CrEL518MiQYDNuGZJU2gfSiKTMFub+t6sHTKU/9O3aQvwz7Wxc15TPxKbTlll54UWsxIpXf4LaqI5ob4jI6v08w1wXRs3SuY/VFUYe1Fb6t3tfEn8lU71LGJigDt2f4Rf6ynEnUrpErf4KFJqXCyQuSXyvZENZPY/02srZMCsuFx7plakb/ZDg88/Ubd3dfzLhAKxl2gbuStWecrwMJfLx3sPYfRXYxxPe21MAWM8vIRHXA== ARC-Authentication-Results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=marvell.com;dmarc=pass action=none header.from=marvell.com;dkim=pass header.d=marvell.com;arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector2-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bbpACNr/ndHk6uVITa3ae3wxC1JjcMJ9hUHCSQFcaTc=; b=RxElmnIn0rzhbIUvxBpaqdv9dCC6U6SmXXkxB6DXH8eg6B2prZVAYpNlwcOWtG0pBp+GQQeHG/P3GzptHCMy36oLizFfVi1fT/79zcQfWaBX0EIXVvJmyIx35iXnvakbHIJqUEG0gPN3Ls067ULSd7NGDNA9MI+aMqKpPthClHA= Received: from BYAPR18MB2424.namprd18.prod.outlook.com (20.179.91.149) by BYAPR18MB2695.namprd18.prod.outlook.com (20.178.207.224) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2136.14; Thu, 8 Aug 2019 08:54:14 +0000 Received: from BYAPR18MB2424.namprd18.prod.outlook.com ([fe80::5877:72b7:40cf:2013]) by BYAPR18MB2424.namprd18.prod.outlook.com ([fe80::5877:72b7:40cf:2013%3]) with mapi id 15.20.2157.015; Thu, 8 Aug 2019 08:54:14 +0000 From: Jerin Jacob Kollanukkaran To: Amit Gupta , Wenzhuo Lu , Jingjing Wu , Bernard Iremonger CC: "dev@dpdk.org" , "stable@dpdk.org" , "Amit Gupta" Thread-Topic: [dpdk-dev] [PATCH] app/testpmd: fix latencystats deinit on signal Thread-Index: AQHVTSHUizraeFWbLk2wfJlkp4UVwKbw80yQ Date: Thu, 8 Aug 2019 08:54:14 +0000 Message-ID: References: <1565183529-641-1-git-send-email-agupta3@marvell.com> In-Reply-To: <1565183529-641-1-git-send-email-agupta3@marvell.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [171.61.87.186] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 44125cc8-54c9-4c9e-68ec-08d71bddfd13 x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(2017052603328)(7193020); SRVR:BYAPR18MB2695; x-ms-traffictypediagnostic: BYAPR18MB2695: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1227; x-forefront-prvs: 012349AD1C x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(136003)(366004)(346002)(396003)(376002)(39860400002)(13464003)(199004)(189003)(66556008)(66066001)(71190400001)(229853002)(71200400001)(14454004)(52536014)(102836004)(54906003)(316002)(74316002)(6506007)(110136005)(7696005)(5660300002)(53546011)(33656002)(99286004)(25786009)(186003)(486006)(256004)(7736002)(66476007)(3846002)(8936002)(64756008)(66946007)(2906002)(446003)(11346002)(55016002)(66446008)(107886003)(6246003)(305945005)(81156014)(81166006)(6116002)(8676002)(26005)(9686003)(14444005)(476003)(76116006)(6436002)(53936002)(76176011)(4326008)(86362001)(478600001); DIR:OUT; SFP:1101; SCL:1; SRVR:BYAPR18MB2695; H:BYAPR18MB2424.namprd18.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: wSApxwsrTS0zVRSFqwOcq/1ie6gpMMX5BHzObdEZQtq1F2WbunLrDLdoGPGLAX44bNnDCrPFCKlKnl6GNrD28Lx8ptIVaYKKFFZpn2IWiiTORbc0jIlZ9WCu2HtG+Id4Iy1Aj6v4KNS3kwPDvOxR6lGMJ3cud9kWM+3jxA0g7m/h2/vfVh5Z2kAmu1srdfI9c9/6zCqKm4krSwrFNur3MEc92Tn06muWJ/hq2kUDNQkkzCPcb0tR+g1aFrVNpxWsrGu6gDCPAVisMeZEhfGl7wM6TNAznjb/V5aGmNT/og1JKPKRS6DcEO7OgVtjbGTRWkT52Cyjd5uNiW44dvOaR8CfzCHJVZawub2PHKPvrPoJxSrTJzuKPw7vWQxJIWCHKZ9u+UMJkF133wmp5f5ukDNJljzRm7d4/tJWOBfXjwY= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 44125cc8-54c9-4c9e-68ec-08d71bddfd13 X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Aug 2019 08:54:14.1435 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: uarfWyGbdfiG6SS9x6fD7Mf1NxTPsyAzurYwczWb0UYeg7hTIxp3UtVkha/kAHW0qwxSmgo+4S1ts6FTL6NELg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR18MB2695 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:5.22.84,1.0.8 definitions=2019-08-08_04:2019-08-07,2019-08-08 signatures=0 Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix latencystats deinit on signal X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: dev On Behalf Of agupta3@marvell.com > Sent: Wednesday, August 7, 2019 6:42 PM > To: Wenzhuo Lu ; Jingjing Wu > ; Bernard Iremonger > Cc: dev@dpdk.org; stable@dpdk.org; Amit Gupta > Subject: [dpdk-dev] [PATCH] app/testpmd: fix latencystats deinit on signa= l >=20 > From: Amit Gupta >=20 > On receiving signal, testpmd showing warning as > "LATENCY_STATS: failed to remove Rx/Tx callback" > because rte_latencystats_uninit is called without checking if latencystat= s is > enabled or not. >=20 > After this fix, rte_latencystats_uninit will be called onlyif latencystat= s is enabled. >=20 > Fixes: 62d3216d6194 ("app/testpmd: add latency statistics calculation") > Cc: stable@dpdk.org >=20 > Signed-off-by: Amit Gupta Acked-by: Jerin Jacob Tested-by: Jerin Jacob > --- > app/test-pmd/testpmd.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) >=20 > diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index > a461cef..e8e2a39 100644 > --- a/app/test-pmd/testpmd.c > +++ b/app/test-pmd/testpmd.c > @@ -3212,7 +3212,8 @@ uint8_t port_is_bonding_slave(portid_t slave_pid) > rte_pdump_uninit(); > #endif > #ifdef RTE_LIBRTE_LATENCY_STATS > - rte_latencystats_uninit(); > + if (latencystats_enabled !=3D 0) > + rte_latencystats_uninit(); > #endif > force_quit(); > /* Set flag to indicate the force termination. */ > -- > 1.8.3.1