From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8B00FA046B for ; Mon, 22 Jul 2019 18:03:03 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 631521BEB3; Mon, 22 Jul 2019 18:03:03 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by dpdk.org (Postfix) with ESMTP id 006661BEB2 for ; Mon, 22 Jul 2019 18:03:01 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id x6MG0IaK021109; Mon, 22 Jul 2019 09:03:00 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0818; bh=s8U5zBFt4l/Fy2zqJGqZ0lGc8FmeldSMumQaKQh96xA=; b=ONAclPNdk0wEhGiKj/M33TrDAyptirm0hQP+FaXJQPQ5BKBUHX09x7Arfa2cTKIc9eFD gw4+0bZUBl3JMx17Z9ge+h1q61isrALq0MmK5/M131aId+LEPRy+uLEWt95rFwFcDQIP K/B7smH483+YyJ1t19C5fhYLpUsWBrOW5HCrJpn4/FwZ4m6WfKf4ChRX+bhMuGyJS7ut 7CVA0YOYCVmDl5XEhSOP2JhByYzfCPb6+ZCj8L9xVaxLpGEAgAWLfiLz2j+wDZ6fDO9C kcD4uyza535R1wvGvji0IGaKpoKSz1QzF+UK7vP3ntMA0DK3yEdSADnwXBqJpLT1sS2A 2g== Received: from sc-exch02.marvell.com ([199.233.58.182]) by mx0a-0016f401.pphosted.com with ESMTP id 2tv0anyr7h-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Mon, 22 Jul 2019 09:03:00 -0700 Received: from SC-EXCH03.marvell.com (10.93.176.83) by SC-EXCH02.marvell.com (10.93.176.82) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Mon, 22 Jul 2019 09:02:59 -0700 Received: from NAM04-CO1-obe.outbound.protection.outlook.com (104.47.45.54) by SC-EXCH03.marvell.com (10.93.176.83) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Mon, 22 Jul 2019 09:02:59 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=K8t2u9Bt14Z2bDd3p7G3v+WTNisWAwGyuOT99R4oLVQUjwVpfjpVIeoF8Rua6R4T5cAsMhKejQitHzB9qNh31T1tl6Q3nAbPhxy0m1Stil918BFRdQdEngarQpJaKdwWmZwrr67H0TzVE3LjSqCg34RWiqLB1Jb4oxDOJohrNH7ELgY8YJDXOjpC07Nd+AeLHL9coNmGvozmWmYYYVuhWt82gM5GN9umYoixD25211+eC2AnFZCQvJrRVSKilIQr+3UJSfR7Udo0Gft/73ARjZ3kV2X6xKwAsTsmFDBgOwZWHr2b0TbNPghgSLlrvhikKVaei3MdI2jQ6PGLBIQ2WQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=s8U5zBFt4l/Fy2zqJGqZ0lGc8FmeldSMumQaKQh96xA=; b=lOqPj+GPo5T/b9WcJDjfrqftFiw64wicyrGexVsI0/ydUOhNTZiPSPIBnRK+2VdtJDXKYSFT42KmeMfEpss2AzKQz7gHbj6ghr63KBZxZEqhwKlhN/pPFo2YSe4B4avGob4IESaUjbZiqrow6gwJq/poKUn6mZLElcHApgILfpNmnD1rZGU4rFX3vIiwlyokmIN5HlRvzMfP0LDHFaOzlD9KXeuja99+idBVmbh9ElkBmJeEdTHmnDLyc8txT0Nd1e8AIDtb0CVtZsQJ8/zRtqGlc/rU1ItKsO9Je6pDRQZWDI5LRVoOUuAV/Jqte/fUzVrKHRK7564wPWF2w1G1Dg== ARC-Authentication-Results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=marvell.com;dmarc=pass action=none header.from=marvell.com;dkim=pass header.d=marvell.com;arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector2-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=s8U5zBFt4l/Fy2zqJGqZ0lGc8FmeldSMumQaKQh96xA=; b=ZCPfaz6SfAlMbBeWE7KfCdUDaNKNcA9UvlT41WlThsg6BNIA8S+/l3c8OiJMaOmCl1QWSQUjvWjfyKbJh6To+jFF2PSWu+qFOs7D0nEyOkzACCN0/sHNq17jvNAf0t4Zp2zzJgcxCUTbkeEyWK0mEx/t9SOWdPJtvmpbu/zpryU= Received: from BYAPR18MB2424.namprd18.prod.outlook.com (20.179.91.149) by BYASPR01MB0075.namprd18.prod.outlook.com (20.179.89.223) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2094.16; Mon, 22 Jul 2019 16:02:54 +0000 Received: from BYAPR18MB2424.namprd18.prod.outlook.com ([fe80::2d42:12b6:aa2e:2862]) by BYAPR18MB2424.namprd18.prod.outlook.com ([fe80::2d42:12b6:aa2e:2862%4]) with mapi id 15.20.2094.013; Mon, 22 Jul 2019 16:02:54 +0000 From: Jerin Jacob Kollanukkaran To: Krzysztof Kanas , "dev@dpdk.org" , Nithin Kumar Dabilpuram , Kiran Kumar Kokkilagadda CC: Krzysztof Kanas , Ferruh Yigit Thread-Topic: [dpdk-dev] [PATCH v2] net/octeontx2: fix driver reconfiguration Thread-Index: AQHVQJ4VK9borDZVtkK1Vzy2dPdMDabWzEiQ Date: Mon, 22 Jul 2019 16:02:54 +0000 Message-ID: References: <20190722145851.14886-1-kkanas@marvell.com> In-Reply-To: <20190722145851.14886-1-kkanas@marvell.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [106.200.248.176] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 1011cee5-6b7f-4cca-15de-08d70ebe0e96 x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(2017052603328)(7193020); SRVR:BYASPR01MB0075; x-ms-traffictypediagnostic: BYASPR01MB0075: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-forefront-prvs: 01068D0A20 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(136003)(396003)(366004)(346002)(39860400002)(376002)(199004)(189003)(13464003)(7736002)(478600001)(76116006)(66946007)(6636002)(256004)(25786009)(76176011)(54906003)(66476007)(66556008)(64756008)(66446008)(476003)(11346002)(316002)(446003)(305945005)(486006)(53546011)(6506007)(8676002)(7696005)(99286004)(74316002)(186003)(26005)(102836004)(2501003)(110136005)(52536014)(4326008)(6436002)(6116002)(55016002)(2906002)(33656002)(81156014)(81166006)(6246003)(9686003)(86362001)(66066001)(229853002)(5660300002)(71190400001)(71200400001)(68736007)(53936002)(3846002)(14454004)(8936002); DIR:OUT; SFP:1101; SCL:1; SRVR:BYASPR01MB0075; H:BYAPR18MB2424.namprd18.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: 5MZpRLG6CWELRGxVtmE7qZGN9yZhHsJjTPNPDFe3TFaico6WBrpSvx5r/I9JtcCgvcNHqdB/jShYw7zBOHr3l23itf5QxKyXXskFcNC6Ti/pgCMIBGLFrnpHASAoG+66LPsqp3L24inEwUB4iB2kY/PW34hhg/qkVtdl/JM45TXZeyuAsc9DqDtzbaDR9BUTBSaXf5pA/eGRkL8ckvnM5rGo5k1GoCyQ4m+pK+nFnk6bl61XWilP1p++pqUCXZKZ1mdfN4KFNtrrqgNLFcqNcJ2d6FjYG/227vOsy3S2QBNyEZNGjFFd5BkLzS9wPQqO5KupebuNXX2uDPH2THnlsZsQpEolHe//VCrxpNlblL/dmUdVqtaCsPG/rPBxFbnuWnxJJhOfMFTsMSOUw1YvBPaz94IhErSFN77kVFGbhjE= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 1011cee5-6b7f-4cca-15de-08d70ebe0e96 X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Jul 2019 16:02:54.5697 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: jerinj@marvell.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYASPR01MB0075 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:5.22.84,1.0.8 definitions=2019-07-22_12:2019-07-22,2019-07-22 signatures=0 Subject: Re: [dpdk-dev] [PATCH v2] net/octeontx2: fix driver reconfiguration X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: kkanas@marvell.com > Sent: Monday, July 22, 2019 8:29 PM > To: dev@dpdk.org; Jerin Jacob Kollanukkaran ; Nithin > Kumar Dabilpuram ; Kiran Kumar Kokkilagadda > > Cc: Krzysztof Kanas > Subject: [dpdk-dev] [PATCH v2] net/octeontx2: fix driver reconfiguration >=20 > From: Krzysztof Kanas >=20 > When configure returns error, e.g. in case not supported offloads (outer = ip > and sctp) driver released Rx,Tx queues. Then in case of correct configura= tion > the driver could not start due to queues already released but the driver > thought it was configured correctly. >=20 > Secondly if driver returns error from configuration librte_ethdev will re= lease, > rx queues and tx queues, without chaining driver configured state. >=20 > Fix that by 'releasing' configuration and changing driver state when erro= r is > returned from otx2_nix_configure. >=20 > Fixes: 548b5839a32b ("net/octeontx2: add device configure operation") >=20 > Signed-off-by: Krzysztof Kanas > Reviewed-by: Nithin Kumar Dabilpuram Acked-by: Jerin Jacob Applied to dpdk-next-net-mrvl/master. Thanks