From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id DEAEFA0096 for ; Wed, 5 Jun 2019 15:34:47 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2CFC81BA65; Wed, 5 Jun 2019 15:34:47 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by dpdk.org (Postfix) with ESMTP id C75741B997 for ; Wed, 5 Jun 2019 15:34:45 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x55DVMRN017162; Wed, 5 Jun 2019 06:34:42 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0818; bh=hmPhMWWaDH2zufotg535mW5057d9wA8BVdcxl56ZsJw=; b=GpKa8+NInGp2OFqetFaSO6/dP++CWiortYxkz8RgeKr64aDa31/tbi3dIVXbFnXKcUR2 XMYzjQTUaUtpRxpZPKf2V1AhR34L/hpvrepCw9ngIS28ooItgoFNP4xLDBxKJzsnu/OO VQcYz50XoYoIL51ZAYN9P3uKw2kbvn2HJrUtbKTPPDTkzp7GE+xbvULAUjHmSmYP3O+S /J2GlXvGR1bJckGFSb8of/ORQeWvmSt+VAEX+qXbWAd3GVdkZyddGFfRkmg1PkdLi6Vp 1rRYWg/jXZj6mfAqKvr9bBokaWOrQ6kKlQ4eK4VYaTrlSv77dHMsScIEfsPqxgEy+dFS IQ== Received: from sc-exch02.marvell.com ([199.233.58.182]) by mx0b-0016f401.pphosted.com with ESMTP id 2sx3kfaawb-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Wed, 05 Jun 2019 06:34:42 -0700 Received: from SC-EXCH01.marvell.com (10.93.176.81) by SC-EXCH02.marvell.com (10.93.176.82) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Wed, 5 Jun 2019 06:34:40 -0700 Received: from NAM02-BL2-obe.outbound.protection.outlook.com (104.47.38.59) by SC-EXCH01.marvell.com (10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Wed, 5 Jun 2019 06:34:39 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector2-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hmPhMWWaDH2zufotg535mW5057d9wA8BVdcxl56ZsJw=; b=Pxakm8ZoBpJlY4uRSMXL1QYKJ+1WKOMP6XfliyiyJgyJqIewd1+5/Vi4H+TiRyXBymASULA0JgkxPGlRWbS0HtzeRCNIorhFlBofZag8//4mtN6abydLZyPEzUuTrr1DCDgrEDT4toa1bl5Sr/XySnP3ZZUj1YjJ0RssTEhUiU0= Received: from BYAPR18MB2424.namprd18.prod.outlook.com (20.179.91.149) by BYAPR18MB2823.namprd18.prod.outlook.com (20.179.57.215) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1943.22; Wed, 5 Jun 2019 13:34:38 +0000 Received: from BYAPR18MB2424.namprd18.prod.outlook.com ([fe80::1ce4:557d:eeb8:843c]) by BYAPR18MB2424.namprd18.prod.outlook.com ([fe80::1ce4:557d:eeb8:843c%7]) with mapi id 15.20.1965.011; Wed, 5 Jun 2019 13:34:37 +0000 From: Jerin Jacob Kollanukkaran To: "Carrillo, Erik G" , Honnappa Nagarahalli , Jerin Jacob Kollanukkaran CC: "mattias.ronnblom@ericsson.com" , "pbhagavatula@caviumnetworks.com" , "dev@dpdk.org" , nd , nd Thread-Topic: [dpdk-dev] [PATCH v6 1/1] eventdev: add new software event timer adapter Thread-Index: AQHU/GEM2QkxTg1o+UOTlpZ9qEK5hqZOy1EAgD6BmVA= Date: Wed, 5 Jun 2019 13:34:37 +0000 Message-ID: References: <1555945059-14808-1-git-send-email-erik.g.carrillo@intel.com> <1556291660-12373-1-git-send-email-erik.g.carrillo@intel.com> <1556291660-12373-2-git-send-email-erik.g.carrillo@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [122.178.234.223] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: bc4fcac5-2672-4dd7-dc29-08d6e9ba8e44 x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(2017052603328)(7193020); SRVR:BYAPR18MB2823; x-ms-traffictypediagnostic: BYAPR18MB2823: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:288; x-forefront-prvs: 00594E8DBA x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(366004)(136003)(39860400002)(396003)(346002)(376002)(13464003)(189003)(199004)(74316002)(305945005)(5660300002)(2906002)(76176011)(6116002)(7736002)(3846002)(6506007)(53546011)(102836004)(81156014)(14444005)(256004)(99286004)(54906003)(25786009)(7696005)(4326008)(76116006)(110136005)(66946007)(66446008)(73956011)(64756008)(66556008)(66476007)(6436002)(316002)(71200400001)(71190400001)(478600001)(33656002)(6246003)(476003)(26005)(81166006)(68736007)(14454004)(55016002)(186003)(486006)(86362001)(8936002)(66066001)(52536014)(446003)(11346002)(9686003)(229853002)(53936002); DIR:OUT; SFP:1101; SCL:1; SRVR:BYAPR18MB2823; H:BYAPR18MB2424.namprd18.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: bTzUNI/SQTVj06Usi/hZz2X9y/ZZ+LqpKpn27uGBLsB8cYXsJFAsyJJ0/R5uHbYNtVdrUl3TUEi5CJKIfdo6qMhgdRNBpOsBHU5M62uGizmkKCYxLNhbXR6tStvsqLJhVhvsUsrkbfO4cnW0kpXt2uFYV0bD12uNLLca/qHIqc7bRmJUzIlvUepgspkcwHqKWKK4Ku4JRMIhQfTJjJuDxIjUdcSvReKI6DM91taGAoN2rGsh6RAdvtgATOKNZRwPBulMb87IPRdua+PhANTdj+RgqCzzu3ErMiEyW+aq5ujm0uKsNZHC+AVN71v3KY4fA8Pg8jRTCn8KYxUymRiP+o96q7n7Vx35MhQxKPRIkVIkacUce6uqhSa8ZlyTzW+SXfWPJLN5MBx7QbIc4poOsMkOFOQn0yUFkywnr7B5Exw= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: bc4fcac5-2672-4dd7-dc29-08d6e9ba8e44 X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Jun 2019 13:34:37.7761 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: jerinj@marvell.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR18MB2823 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2019-06-05_08:, , signatures=0 Subject: Re: [dpdk-dev] [PATCH v6 1/1] eventdev: add new software event timer adapter X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Carrillo, Erik G > Sent: Saturday, April 27, 2019 12:29 AM > To: Honnappa Nagarahalli ; > jerin.jacob@caviumnetworks.com > Cc: mattias.ronnblom@ericsson.com; pbhagavatula@caviumnetworks.com; > dev@dpdk.org; nd ; nd > Subject: RE: [dpdk-dev] [PATCH v6 1/1] eventdev: add new software event t= imer > adapter >=20 >=20 >=20 > > -----Original Message----- > > From: Honnappa Nagarahalli [mailto:Honnappa.Nagarahalli@arm.com] > > Sent: Friday, April 26, 2019 1:51 PM > > To: Carrillo, Erik G ; > > jerin.jacob@caviumnetworks.com > > Cc: mattias.ronnblom@ericsson.com; pbhagavatula@caviumnetworks.com; > > dev@dpdk.org; Honnappa Nagarahalli ; nd > > ; nd > > Subject: RE: [dpdk-dev] [PATCH v6 1/1] eventdev: add new software > > event timer adapter > > > > Hi Erik, > > A quick question. > > > > > -----Original Message----- > > > From: dev On Behalf Of Erik Gabriel Carrillo > > > Sent: Friday, April 26, 2019 10:14 AM > > > To: jerin.jacob@caviumnetworks.com > > > Cc: mattias.ronnblom@ericsson.com; > > pbhagavatula@caviumnetworks.com; > > > dev@dpdk.org > > > Subject: [dpdk-dev] [PATCH v6 1/1] eventdev: add new software event > > > timer adapter > > > > > > This patch introduces a new version of the event timer adapter > > > software > > PMD. > > > In the original design, timer event producer lcores in the primary > > > and secondary processes enqueued event timers into a ring, and a > > > service core in the primary process dequeued them and processed them > further. > > > To improve performance, this version does away with the ring and In general idea and patch looks good to me. Could you update git commit log with=20 # Percentage of performance improvement seen with this method? # Means(test command etc) of measuring the performance improvement? > > > lets lcores in both primary and secondary processes insert timers > > > directly into timer skiplist data structures; the service core > > > directly accesses the lists as well, when looking for timers that hav= e expired. > > How do you ensure concurrent access to the timer skiplist? Are you > > using any locks or is it a lock-free data structure? > > > > >=20 > There are multiple timer skiplists, one for each lcore, and each has its= lock that > is acquired as necessary when adding or removing timers from the skiplist= s. This > locking occurs in the underlying timer library, in the timer reset and st= op > functions. >=20 > Regards, > Erik