From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5321EA00C5; Thu, 30 Apr 2020 11:27:21 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 334CC1DA6D; Thu, 30 Apr 2020 11:27:20 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by dpdk.org (Postfix) with ESMTP id E8B2B1DA61 for ; Thu, 30 Apr 2020 11:27:17 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 03U9HKM4020834; Thu, 30 Apr 2020 02:27:14 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0818; bh=16HQ8m0QL8z4EEvRw2926iirTex2wKW0C1LmxQs9hOg=; b=PhfV9EgtAd0ppx3dbmZdjwN7L/z1r4N+R/+JvfMgbkYuz6FSud03G3NmrSbWayG1OVLV 6bx1ul6dIpPgFdXWXtQ+aX7N3YRnfe0Qs6AZtNSljgq2whSWoqBSADjleP0eShmWGGgp f+E/k87jnQdndQYwuKcnT4JvaXFcfHR5G6NyKBjeI8df4qSyCpJl2kUmjTdEWDrrDAmF e3I+bXW1qDyjvCpDBQaGH4zTUL/CY/Bcwakqb0cQRPQ0vzYtKYGJklVa/1Ln3WzE9dtG id5t0wy7JQK1yscsjtN/+h5QuCQ/olqHyyQyRrc5OEoG0N77ke6g8Uwx7QKNIEZokAOA +w== Received: from sc-exch01.marvell.com ([199.233.58.181]) by mx0a-0016f401.pphosted.com with ESMTP id 30mjjqp2q6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Thu, 30 Apr 2020 02:27:14 -0700 Received: from SC-EXCH03.marvell.com (10.93.176.83) by SC-EXCH01.marvell.com (10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 30 Apr 2020 02:27:12 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.102) by SC-EXCH03.marvell.com (10.93.176.83) with Microsoft SMTP Server (TLS) id 15.0.1497.2 via Frontend Transport; Thu, 30 Apr 2020 02:27:12 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VbcXNO/rz3qN1OnmZOUq1uJx4pwgtnSFHvIwtwN/uEdihFZ8SiWMq2X263m1AF11pFXLW7RQnoRthGjbfWVODx1CU8SykHPzcWpciLf/urYCn+fV6OKc+eHPweD0MBzSP/T4kw/9MTOSpjvLr1g/ax/OzCOwmv1t6x+FN8C/QJlMOFUWnpHMrDB4uH3ksAIdLCnIfhgUghVl3LNaenO1tiqCyZ7Mgr5IdM+VHSTUHwiVz1SIv+qubNI7BJKB7qOpObRjnr1GysoZZtqZfeRJ38CIxa/KaQf1E6mP4kP/PaOaiw9nCLdvISBDEAssLaR8WsETqOzuN83k378la8cftg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=16HQ8m0QL8z4EEvRw2926iirTex2wKW0C1LmxQs9hOg=; b=VCbX4VcHG1ZpByM0BY31VpXKsXzrB0Xq4ntIWrT4/buYZWDUg2RA1iGQaJH88VB1PBjI03UsvXGhxTbJwNLt0zCqn7LKCK7v9UPdeCRyY0SRqBQ/k5Ui/2i9SddJC329EBt3xReMOCeWaixTDXTLaKc/MLyPfP3dvOeHOMZV4zLrpSn48ZvemliWq/NUCyNDoTmLHVb9pBUCVemY7qXDvFBQE8VvC/pikUp+WGRyen1u4PgphhTyInE9fOdIHJMpRkMPyqEZqffNvd8UlipKbhjGqcudpqliQb+cpAdpBOXwxH3TRCzztGkWVyIZyVGAuejZguD3zYGdkKHW17n+9g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=16HQ8m0QL8z4EEvRw2926iirTex2wKW0C1LmxQs9hOg=; b=Bfz4tJF6dx5rG3WLSisHQ0n1Ox0/NQZDX+4fwAngkb4/Jcp9rr2/qvfOziIXbVZ5+PXU/r79Cft5vSyJcY85G05gNeMtwBypzMQd/GBt662IUcAHAShup9bgaB3u9cHfg8m3QcgWLyPQb+1IIswsxgGl/kS0OdCibbeY2N/fRGI= Received: from BYAPR18MB2518.namprd18.prod.outlook.com (2603:10b6:a03:13b::18) by BYAPR18MB2693.namprd18.prod.outlook.com (2603:10b6:a03:101::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2937.13; Thu, 30 Apr 2020 09:27:11 +0000 Received: from BYAPR18MB2518.namprd18.prod.outlook.com ([fe80::fca4:5e00:46d9:a289]) by BYAPR18MB2518.namprd18.prod.outlook.com ([fe80::fca4:5e00:46d9:a289%3]) with mapi id 15.20.2937.028; Thu, 30 Apr 2020 09:27:11 +0000 From: Pavan Nikhilesh Bhagavatula To: "Van Haaren, Harry" , "Jerin Jacob Kollanukkaran" , "thomas@monjalon.net" , "Wang, Yipeng1" , "Gobriel, Sameh" , "Richardson, Bruce" , Ruifeng Wang CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] [RFC] hash: unify crc32 API header for x86 and ARM Thread-Index: AQHWHs/IMy0OedxHcEmZC8iQrotAGqiRZDYQ Date: Thu, 30 Apr 2020 09:27:11 +0000 Message-ID: References: <20200429180515.5704-1-pbhagavatula@marvell.com> In-Reply-To: Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=marvell.com; x-originating-ip: [223.226.86.58] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: a3d87d81-9039-48d6-4b44-08d7ece8a964 x-ms-traffictypediagnostic: BYAPR18MB2693: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-forefront-prvs: 0389EDA07F x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR18MB2518.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(366004)(396003)(346002)(376002)(39860400002)(136003)(33656002)(4326008)(55016002)(110136005)(55236004)(316002)(26005)(9686003)(52536014)(86362001)(71200400001)(2906002)(5660300002)(478600001)(76116006)(66446008)(64756008)(66556008)(7696005)(6506007)(186003)(8936002)(8676002)(66476007)(66946007)(53546011)(921003); DIR:OUT; SFP:1101; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: O7cI/nHlhfpOtiRgmsnRok3f4gKfW+XVVkFupFyUr0pivTIWzKdGKYUsaUKBf2PwGFu0/O1B1caGu8NcnqMf4ph7jzmiDvkeRSTyOv/nKEjJYlQBAOgG0i04bJIm74Z/SHrdf81IUf4ZrOYdibnV77QR47J4YBCZOlmHOA4QmQCtrNY9BTJ7Oz0RnjA85IscUfztqySTcfp5uOO10nQNB/2CLcvuI6dkQMCoW0DZBP1FMy4taC7RTNzO7iSAF6g806A5J3pUQcPuceJ2oV7IsV8/sT7rXGY2UJv8ud1reWWQABy+LjybsFI9aoEKWcB/xl/r0qe81OUdya+4XdeR8BbmFHM7cmMk3JCFNbb1GlQAS8pl7zJ6L/z2TXweW2iCLNo3UJRJ88V3GWGxCt4/W2B2oNY9IJCaXtNC4rBGuEgzecCMYqQ/Qxq3HgbjhFzjyI7PyRDF/SrMAd1JL8t54KXvSI6Iin4D6CrmDMNVJKs= x-ms-exchange-antispam-messagedata: XWgxOUaPr+5WFeBBfHYiUbI+5vL1gbjI4yBwXnPn4AxS+/nhouWZ716aN8L3O7kublTLEfAritJ4WHT0IZwujOdxHagjdRGsemHqgX1+8AvtkZ2EE1FBYg95US9YkvLx4gdTKqWSoAILbwCU6VOASPFtHeF83HTMV++vDRYRPOCSpdaUzFevT8nyesIup8viFQtacxh8j3+uK2VXVcDjKdUzLhMaWg93nkF0bWlqD1lg6evUut8iu1Nci4PBIpjNiwbrTtMJJuGKAqQE0QdCfqeAavzZdZhZ1D5Y/61KCBANwwY2wy14Mn9qwmwOeCTb6MIn4upWosvJR4/P6PaeuP68bPS4yyNW5MmX/kuPAqXe1knUYOAdPcHQOFNw91rrk2EnmM9knQBJFZcIB/UUMMj1E7N9sMkoGdmjTnw4vszZZyuTg2bDpfoUdfnDjfkjPeUuxvrSe94+sOGI1LaIPb/FTqsIp9JHHabXIs2+VuhBQoVur8SvOmO/8flLVbF+aJMkJt0bE3WPvoGIkrUw4bxMXn9Dwm3isduNAm8Iuq95j6qRF93a4yG8GZIyTsd+OV3AFHfDG6CCLyGT/r7HxJ/lUbT5HcORB7+NOuILb+1zgNk3EPGkhejiBoMeKJAuZ9fQTgsyNDRwx0eSJmbhgQE8+uyiSx9DJH59HFGY8OOBnqc4yxQDjSPuomV6cDda0ORnk0UiFc638czy0uux0XE7KJo9sPMl9Kj3zk6OmQwcTTBvl6ZoTLbnXJEox2ajpF5jBmslmDYdAtNwWSFd3JAX1nDi0U37JrYVoToviZE= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: a3d87d81-9039-48d6-4b44-08d7ece8a964 X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Apr 2020 09:27:11.3375 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: q0E8weCGq+E0Qfr8CSYVuNB/1l2MRsdUHFk05a1Dyzj6kTp+pK0XmSVismlwhgHAB848VO9DdvPimj4EjqKl2tTiMlHtU7E9A+7cohrT5O0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR18MB2693 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.138, 18.0.676 definitions=2020-04-30_03:2020-04-30, 2020-04-30 signatures=0 Subject: Re: [dpdk-dev] [RFC] hash: unify crc32 API header for x86 and ARM X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" >> -----Original Message----- >> From: dev On Behalf Of >pbhagavatula@marvell.com >> Sent: Wednesday, April 29, 2020 7:05 PM >> To: jerinj@marvell.com; thomas@monjalon.net; Wang, Yipeng1 >> ; Gobriel, Sameh >; >> Richardson, Bruce ; Ruifeng Wang >> >> Cc: dev@dpdk.org; Pavan Nikhilesh >> Subject: [dpdk-dev] [RFC] hash: unify crc32 API header for x86 and >ARM >> >> From: Pavan Nikhilesh >> >> Merge crc32 hash calculation public API headers for x86 and ARM, >> split implementations of x86 and ARM into their respective private >> headers. >> This reduces the ifdef code clutter while keeping current ABI intact. >> >> Although we install `rte_crc_arm64.h` it is not used in any of the lib o= r >> drivers layers. All the libs and drivers use `rte_hash_crc.h` which fall= s >> back to SW crc32 calculation for ARM platform. > > > >> diff --git a/lib/librte_hash/meson.build b/lib/librte_hash/meson.build >> index 6ab46ae9d..90a180bc8 100644 >> --- a/lib/librte_hash/meson.build >> +++ b/lib/librte_hash/meson.build >> @@ -1,8 +1,7 @@ >> # SPDX-License-Identifier: BSD-3-Clause >> # Copyright(c) 2017 Intel Corporation >> >> -headers =3D files('rte_crc_arm64.h', >> - 'rte_fbk_hash.h', >> +headers =3D files('rte_fbk_hash.h', >> 'rte_hash_crc.h', >> 'rte_hash.h', >> 'rte_jhash.h', > >Am I right in that previously an application could #include > and hence if we no >longer install that file, this will cause a compilation failure on that >application? Applications shouldn't >include arch specific headers... but we shouldn't knowingly remove >publicly accessible includes either. > >Perhaps consider just installing a dummy header file if the code cleanup >in the rest of the patch is desired? Sure we could either symlink `rte_hash_crc.h` as `rte_crc_arm64.h` or Just include rte_hash_crc.h in rte_crc_arm64.h for now and remove rte_crc_arm64.h later with a deprecation notice?=20