From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id DDB00A034E; Thu, 7 Nov 2019 12:58:35 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id AED161E9D6; Thu, 7 Nov 2019 12:58:35 +0100 (CET) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by dpdk.org (Postfix) with ESMTP id 6F8DE1E9D0 for ; Thu, 7 Nov 2019 12:58:34 +0100 (CET) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id xA7Buoc0005131; Thu, 7 Nov 2019 03:58:33 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0818; bh=d9gmApO0AJwW055RIpnUyCR4+8M1Gq2AZAaPcqJv3Uc=; b=VaVB+Pv4cNMMiWTzBinp7x5PSVeERVymW9/COw4aCh+1QkI9yfS7LdhxekhX9GSIlv6t Zt24bd4LkjDN0d9meO5qa9ggixFSdqCqGXXAWNcg5sL9kQfCpfF7MsZjUdphKOGtyqRJ MtXL++9YhAxfjqmi7jJk9Vaez17bXN9y6zUlP3esOufpIupznjy/A74RMcHW4ubBbIIr Ip2VZ5w9FlwPgfX/V1UUhsHcQGkEGrh79iY9n05711B9t9BQjlKEFxDYGkQW22f+lPx/ UvHZ+oDNwSd3nfSdYRKwRLijc8wt9hwdPn23sYufhXEFWVN6OZGbwbuCO7EiZffy9S8y AA== Received: from sc-exch01.marvell.com ([199.233.58.181]) by mx0b-0016f401.pphosted.com with ESMTP id 2w4fq6rnh4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Thu, 07 Nov 2019 03:58:33 -0800 Received: from SC-EXCH01.marvell.com (10.93.176.81) by SC-EXCH01.marvell.com (10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Thu, 7 Nov 2019 03:58:31 -0800 Received: from NAM02-CY1-obe.outbound.protection.outlook.com (104.47.37.52) by SC-EXCH01.marvell.com (10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Thu, 7 Nov 2019 03:58:31 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PL+I0HA1UTq+1M8gqO0ZEHMPQirqcVpCECnf062dgMjYNSabQVYYeXv4GbrH8aatYW+QbkPB9usW2bKg3mS67uCWWYWOujaRcBFLh5AJTKv09PIf6GNvuT2GZ92UazL8ZdE+u+3eOAM1uCBHwybBTgFPME9dSFCObGOLBl4wleyANYHwS+eLdHrOQZXPVrao6jSkirHzqxrzvMVAYwI8mqa7GXvfBrJJfdz9kdukpo+7FGUm9ha/va/5R752dZNQj5wJjiJQsWlCvQGM0x33SHfDMRgr3WRomQQ1ukUxhPaokPVzKoqhCDX3vO8WF6oqz/su/dHbI2msqJqZgb/eEA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=d9gmApO0AJwW055RIpnUyCR4+8M1Gq2AZAaPcqJv3Uc=; b=TCCZT6VOQakuzlttP5X+Q/IUjHWtAW9iIWaJZwv2faej5X4ulR2k7tSkACOy+Xy7MUNL1Nvp9GT3y87C3n36AS3Yi8NUORNsrKxonCN8a21bfV1oEkEMgBhIwW69URuao4r8fC7sVL3dGht1eStkfWlgIsdIfP/f8OfmVgbtdEnHt2BylFhfhhzNxLUZMoC0SHet4Hqee4aFuby683E9JdCL2nFAR2mwDbh/sdkjFxO0TjsXNA+X3UywK2OmxDYZUsoShBkUd2lsPT1Yrw6tx+B5Eep29Xw3LupsMZ++WBHlKtSmSHtAK4I0tahUzRHn7UFPB7LhYUSaH+8N3ndZyA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector2-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=d9gmApO0AJwW055RIpnUyCR4+8M1Gq2AZAaPcqJv3Uc=; b=XlOgsTXSvh8g4W4bIvbv41rS+6/k1db4UopVGmXmDGXkvvDVFi8lxtTWSXP5yom3TPNiMUOKz7uAvv6wATJd0wAd1ZFRZu50pk5ZWc9vsUItFL66i7YFwrFI1oyzkcf6YDEq0B4i31sZs0b8/neDL1s4yS9j9gF6J4AtwKSFV5U= Received: from BYAPR18MB2696.namprd18.prod.outlook.com (20.179.58.90) by BYAPR18MB3030.namprd18.prod.outlook.com (20.179.94.208) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2408.24; Thu, 7 Nov 2019 11:57:14 +0000 Received: from BYAPR18MB2696.namprd18.prod.outlook.com ([fe80::54f1:ecaa:8d9b:829c]) by BYAPR18MB2696.namprd18.prod.outlook.com ([fe80::54f1:ecaa:8d9b:829c%3]) with mapi id 15.20.2408.028; Thu, 7 Nov 2019 11:57:14 +0000 From: Shahed Shaikh To: Dekel Peled , "john.mcnamara@intel.com" , "marko.kovacevic@intel.com" , "nhorman@tuxdriver.com" , "ajit.khaparde@broadcom.com" , "somnath.kotur@broadcom.com" , "anatoly.burakov@intel.com" , "xuanziyang2@huawei.com" , "cloud.wangxiaoyun@huawei.com" , "zhouguoyang@huawei.com" , "wenzhuo.lu@intel.com" , "konstantin.ananyev@intel.com" , "matan@mellanox.com" , "shahafs@mellanox.com" , "viacheslavo@mellanox.com" , Rasesh Mody , "maxime.coquelin@redhat.com" , "tiwei.bie@intel.com" , "zhihong.wang@intel.com" , "yongwang@vmware.com" , "thomas@monjalon.net" , "ferruh.yigit@intel.com" , "arybchenko@solarflare.com" , "jingjing.wu@intel.com" , "bernard.iremonger@intel.com" CC: "dev@dpdk.org" Thread-Topic: [EXT] [PATCH v3 1/3] ethdev: support API to set max LRO packet size Thread-Index: AQHVlK6LiPapM6iayEa5XrRaXiVt3ad/mpsg Date: Thu, 7 Nov 2019 11:57:14 +0000 Message-ID: References: <87548a8a0d7d549bd7fb788be197c90712785ad3.1573050134.git.dekelp@mellanox.com> In-Reply-To: <87548a8a0d7d549bd7fb788be197c90712785ad3.1573050134.git.dekelp@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [123.201.54.174] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 8600d1f1-5c7a-4816-d6a1-08d76379a18f x-ms-traffictypediagnostic: BYAPR18MB3030: x-ms-exchange-purlcount: 1 x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:390; x-forefront-prvs: 0214EB3F68 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(366004)(13464003)(199004)(189003)(305945005)(7736002)(76176011)(55016002)(476003)(446003)(11346002)(2201001)(102836004)(8676002)(486006)(8936002)(7696005)(66556008)(66946007)(66066001)(76116006)(9686003)(14454004)(64756008)(66476007)(6306002)(7416002)(66446008)(186003)(6436002)(229853002)(26005)(5660300002)(6246003)(99286004)(86362001)(74316002)(498600001)(25786009)(19627235002)(110136005)(2906002)(71200400001)(71190400001)(2501003)(14444005)(256004)(966005)(4326008)(52536014)(81166006)(53546011)(6506007)(33656002)(3846002)(6116002)(81156014)(921003)(1121003); DIR:OUT; SFP:1101; SCL:1; SRVR:BYAPR18MB3030; H:BYAPR18MB2696.namprd18.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Rf0wM3z9zV5cC9SDbtZOXwlhcwh3ftbHKGUwanbAxbKnLVwn8b3W5H7HLolQa30X1haZRTUcaSh3ESkKg+jk8r4k5wYam5ZaEmnTeh2Vw+uD5BZ5WHolq5u2lE9a7eb4VJzbTUgAwVevcEQrA4dhbyksY02aV8mCHHIHKHXO6ZrBRV6rClJrFFUNjiG0v/lSX66o7wu4Uu8cil4Dne4bQ4+fRW9MT8YlH0AXVtrkT01AahDPl9pBpmTA11HRfMqSn93EhktJvbdE++W8Z1wDJnB7aXLjCv41f1pc0SlqCl5YFR2AOL/K3Or6t+c2331/ZIo1XYrwlBG+X/4WOzuBwqRn/oM7LA4ZFhqj5MsGDTsmqtOjtRP/+xKzvk3NI3z1pT1vCORfgrAKBIkdaiWBN/eugl6pYzdekL0qWrAQLEI9xFLUrq1rOnqjZApoO1rtBmPZZfZNNsLWkFOZLZZePAr/AimaFBc04MNW1527+m4= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 8600d1f1-5c7a-4816-d6a1-08d76379a18f X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Nov 2019 11:57:14.4478 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Cxi4WyNTTz8W0IdDpZyKNvvyi6XNgSKmJ6UGUyuR1StixWdxUxOGnqkTDx41mGU7ch3zCZWjPp4yU/Nzekmh9Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR18MB3030 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.95,18.0.572 definitions=2019-11-07_03:2019-11-07,2019-11-07 signatures=0 Subject: Re: [dpdk-dev] [EXT] [PATCH v3 1/3] ethdev: support API to set max LRO packet size X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Dekel Peled > Sent: Wednesday, November 6, 2019 7:58 PM > To: john.mcnamara@intel.com; marko.kovacevic@intel.com; > nhorman@tuxdriver.com; ajit.khaparde@broadcom.com; > somnath.kotur@broadcom.com; anatoly.burakov@intel.com; > xuanziyang2@huawei.com; cloud.wangxiaoyun@huawei.com; > zhouguoyang@huawei.com; wenzhuo.lu@intel.com; > konstantin.ananyev@intel.com; matan@mellanox.com; > shahafs@mellanox.com; viacheslavo@mellanox.com; Rasesh Mody > ; Shahed Shaikh ; > maxime.coquelin@redhat.com; tiwei.bie@intel.com; zhihong.wang@intel.com; > yongwang@vmware.com; thomas@monjalon.net; ferruh.yigit@intel.com; > arybchenko@solarflare.com; jingjing.wu@intel.com; > bernard.iremonger@intel.com > Cc: dev@dpdk.org > Subject: [EXT] [PATCH v3 1/3] ethdev: support API to set max LRO packet s= ize >=20 > External Email >=20 > ---------------------------------------------------------------------- > This patch implements [1], to support API for configuration and >=20 > validation of max size for LRO aggregated packet. >=20 > API change notice [2] is removed, and release notes for 19.11 >=20 > are updated accordingly. >=20 >=20 >=20 > Various PMDs using LRO offload are updated, the new data members are >=20 > initialized to ensure they don't fail validation. >=20 >=20 >=20 > [1] https://urldefense.proofpoint.com/v2/url?u=3Dhttp- > 3A__patches.dpdk.org_patch_58217_&d=3DDwIBAg&c=3DnKjWec2b6R0mOyPaz7xtf > Q&r=3DqeevDAWea4uZZbQhISypy6IVgD4EOfIP7D- > cw6N6nsI&m=3Dghr6KiUvwMCjBQ7KRJJ8BfoTOHlY9gICprAIn4yao9A&s=3DANfM9GH > SB9nUhm8O8YaoqcXO0eTBO7TmGhVmekbNO6U&e=3D >=20 > [2] https://urldefense.proofpoint.com/v2/url?u=3Dhttp- > 3A__patches.dpdk.org_patch_57492_&d=3DDwIBAg&c=3DnKjWec2b6R0mOyPaz7xtf > Q&r=3DqeevDAWea4uZZbQhISypy6IVgD4EOfIP7D- > cw6N6nsI&m=3Dghr6KiUvwMCjBQ7KRJJ8BfoTOHlY9gICprAIn4yao9A&s=3DppYVWXe > Jj3xhnvWCV2hIfNu6wy9N2r5lvJxgJnHKfSc&e=3D >=20 >=20 >=20 > Signed-off-by: Dekel Peled >=20 > Reviewed-by: Andrew Rybchenko >=20 > Acked-by: Thomas Monjalon >=20 > --- >=20 > doc/guides/nics/features.rst | 2 ++ >=20 > doc/guides/rel_notes/deprecation.rst | 4 --- >=20 > doc/guides/rel_notes/release_19_11.rst | 8 ++++++ >=20 > drivers/net/bnxt/bnxt_ethdev.c | 1 + >=20 > drivers/net/hinic/hinic_pmd_ethdev.c | 1 + >=20 > drivers/net/ixgbe/ixgbe_ethdev.c | 2 ++ >=20 > drivers/net/ixgbe/ixgbe_vf_representor.c | 1 + >=20 > drivers/net/mlx5/mlx5.h | 3 +++ >=20 > drivers/net/mlx5/mlx5_ethdev.c | 1 + >=20 > drivers/net/mlx5/mlx5_rxq.c | 1 - >=20 > drivers/net/qede/qede_ethdev.c | 1 + >=20 > drivers/net/virtio/virtio_ethdev.c | 1 + >=20 > drivers/net/vmxnet3/vmxnet3_ethdev.c | 1 + >=20 > lib/librte_ethdev/rte_ethdev.c | 44 > ++++++++++++++++++++++++++++++++ >=20 > lib/librte_ethdev/rte_ethdev.h | 4 +++ >=20 > 15 files changed, 70 insertions(+), 5 deletions(-) >=20 > @@ -1277,6 +1277,7 @@ static int qede_dev_configure(struct rte_eth_dev > *eth_dev) >=20 >=20 >=20 > dev_info->min_rx_bufsize =3D (uint32_t)QEDE_MIN_RX_BUFF_SIZE; >=20 > dev_info->max_rx_pktlen =3D > (uint32_t)ETH_TX_MAX_NON_LSO_PKT_LEN; >=20 > + dev_info->max_lro_pkt_size =3D > (uint32_t)ETH_TX_MAX_NON_LSO_PKT_LEN Please use 0x7FFF instead of ETH_TX_MAX_NON_LSO_PKT_LEN. We set the same limit in qede_ethdev.c: qede_update_sge_tpa_params() sge_tpa_params->tpa_max_size =3D 0x7FFF; Thanks, Shahed >=20 > dev_info->rx_desc_lim =3D qede_rx_desc_lim; >=20 > dev_info->tx_desc_lim =3D qede_tx_desc_lim; >=20 >=20