From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <prvs=8921f9585b=rmody@marvell.com>
Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com
[67.231.156.173]) by dpdk.org (Postfix) with ESMTP id 3D21FDE3;
Fri, 18 Jan 2019 17:58:58 +0100 (CET)
Received: from pps.filterd (m0045851.ppops.net [127.0.0.1])
by mx0b-0016f401.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id
x0IGtNma010896; Fri, 18 Jan 2019 08:58:57 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;
h=from : to : cc :
subject : date : message-id : references : in-reply-to : content-type :
content-transfer-encoding : mime-version; s=pfpt0818;
bh=//M0C8Xu5JXv0l1Hjwy6YyTmDZ4yLRRxxqZ1FiyXFzQ=;
b=gZgMRLmiVDrdHTcvv+BLbbGLTpiDMwOOnKE0EBPxaKpDOEGnu2EjDJFbHBf00lMp7RSc
OfzS9Jn2JMMIcfayCikv0htIMnqnsg/iWP4rBX4Xx3tWr1ji0KXKGEP3rVu1IiQeJJ9s
e4QTRELs0Mzz6jRpSnDit/H62thQwvZ5+smyEIzZQ4TrGHZJ7omJgqVfcyIMKvJOKy8w
Vi2bJ7m0dgtMonZngjTb0nzLzM66QoHojUYUR9CHWOxb49KhshGdgYY4bQzsz8rG4+jF
jz7TjQNFbMHkTT+3CgpOEREnFTE+NiZ4yhfsxufLBSNUllromjpDBIiXiPBtla8xZ7bW vw==
Received: from sc-exch01.marvell.com ([199.233.58.181])
by mx0b-0016f401.pphosted.com with ESMTP id 2q2vubdm61-1
(version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT);
Fri, 18 Jan 2019 08:58:57 -0800
Received: from SC-EXCH04.marvell.com (10.93.176.84) by SC-EXCH01.marvell.com
(10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Fri, 18 Jan
2019 08:58:55 -0800
Received: from NAM05-CO1-obe.outbound.protection.outlook.com (104.47.48.59) by
SC-EXCH04.marvell.com (10.93.176.84) with Microsoft SMTP Server
(TLS) id
15.0.1367.3 via Frontend Transport; Fri, 18 Jan 2019 08:58:55 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=marvell.onmicrosoft.com; s=selector1-marvell-com;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
bh=//M0C8Xu5JXv0l1Hjwy6YyTmDZ4yLRRxxqZ1FiyXFzQ=;
b=W2KPRLrgArRmtnsAkjTTOOHWK1IQeBThrn+3tACTAxz5wsY2PlHMGuyRQMwzY4AR82KF2uKRNM02AXJXTu3OKFX9K3JZZF8+pVM479Tpo12ENlpmxCPJiKoilVY6H3zu2YRq1VGFjwNY5Ay2yLsJMnYli1EuL4Olob7VAK8eSh4=
Received: from BYAPR18MB2838.namprd18.prod.outlook.com (20.179.58.18) by
BYAPR18MB3045.namprd18.prod.outlook.com (20.179.60.29) with Microsoft SMTP
Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
15.20.1537.24; Fri, 18 Jan 2019 16:58:50 +0000
Received: from BYAPR18MB2838.namprd18.prod.outlook.com
([fe80::99e4:8d74:dab4:f5c5]) by BYAPR18MB2838.namprd18.prod.outlook.com
([fe80::99e4:8d74:dab4:f5c5%4]) with mapi id 15.20.1537.018; Fri, 18 Jan 2019
16:58:50 +0000
From: Rasesh Mody <rmody@marvell.com>
To: Shahed Shaikh <shshaikh@marvell.com>, "dev@dpdk.org" <dev@dpdk.org>
CC: "ferruh.yigit@intel.com" <ferruh.yigit@intel.com>, "stable@dpdk.org"
<stable@dpdk.org>, "thomas@monjalon.net" <thomas@monjalon.net>
Thread-Topic: [dpdk-dev] [PATCH 2/2] net/qede: fix prefetch from incorrect
place in Tx path
Thread-Index: AQHUrxjLW9yOj56RmUuxk7Xfye1LK6W1P7GQ
Date: Fri, 18 Jan 2019 16:58:50 +0000
Message-ID: <BYAPR18MB28380644175A310F51ABC279B59C0@BYAPR18MB2838.namprd18.prod.outlook.com>
References: <20190118102930.27487-1-shshaikh@marvell.com>
<20190118102930.27487-2-shshaikh@marvell.com>
In-Reply-To: <20190118102930.27487-2-shshaikh@marvell.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [198.186.1.5]
x-ms-publictraffictype: Email
x-microsoft-exchange-diagnostics: 1; BYAPR18MB3045;
20:SHaxBdch3+yE2voa0+qgREdA6wFfsn/It/sogA+Nz1ICZ6tQhx/9uefV5Logueyg3zOuwuToWdHJcNG3fxIiJ7FYZQ2eNhpPwNjUp/RuIVsagFpALPr1/I/b/DhyajCE+Nos4qNisUgTSExnOZEwgXbdJ1ERVMNeVdp5RRUSgRk=
x-ms-office365-filtering-correlation-id: 82c7bb45-29dc-43e5-00da-08d67d66387b
x-microsoft-antispam: BCL:0; PCL:0;
RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600109)(711020)(2017052603328)(7153060)(7193020);
SRVR:BYAPR18MB3045;
x-ms-traffictypediagnostic: BYAPR18MB3045:
x-microsoft-antispam-prvs: <BYAPR18MB3045AD9E4B939C987D34C043B59C0@BYAPR18MB3045.namprd18.prod.outlook.com>
x-forefront-prvs: 0921D55E4F
x-forefront-antispam-report: SFV:NSPM;
SFS:(10009020)(136003)(366004)(376002)(39860400002)(396003)(346002)(199004)(189003)(71200400001)(5660300001)(71190400001)(102836004)(256004)(110136005)(54906003)(55016002)(86362001)(316002)(3846002)(7736002)(106356001)(305945005)(6246003)(6116002)(4326008)(9686003)(14444005)(2906002)(229853002)(53936002)(99286004)(14454004)(4744005)(6436002)(105586002)(26005)(186003)(486006)(478600001)(7696005)(97736004)(66066001)(25786009)(81166006)(76176011)(2501003)(74316002)(476003)(446003)(8936002)(11346002)(6506007)(68736007)(33656002)(81156014);
DIR:OUT; SFP:1101; SCL:1; SRVR:BYAPR18MB3045;
H:BYAPR18MB2838.namprd18.prod.outlook.com; FPR:; SPF:None; LANG:en;
PTR:InfoNoRecords; A:1; MX:1;
received-spf: None (protection.outlook.com: marvell.com does not designate
permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam-message-info: nQP+HyjrQUeUJUV7EdPfux02K3CpEn+LLrCF260Ay8TxqLAhgaV8YoMh+mwVHLvjhOKHRU4Kowu2tPGvy+IZe3tVYbH20LsTI5nwZRIzUOMGBkEqGMTB6grvjuthjs+jYjUi5LhVkd2NyvAL96BnNdTAHuvHSpTYeLe0xIwUAlQv6aUTkv/xyCLWEUy04Kmw88z223WxU2ElGXJCFHysZInxq3Audv2vU90LT0xsYw0IFYsbsGXBsrRezxmVfVoHKFUXMwBEoyUd02YCiP//0HsbN18OX4GgBj4x713ss5C9obqrpRThSJ6oOXar0BXMTD5VgS4epOwf9WLqfenNKBvGjNd3LS2jsTCKAmCETPyGSVab0JGDuRLM2e7tVeDumJg74Mx+YBo8wP5kKIRVY1X/9uQ2iV29aP1VCFEB9UU=
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 82c7bb45-29dc-43e5-00da-08d67d66387b
X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Jan 2019 16:58:50.6144 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR18MB3045
X-OriginatorOrg: marvell.com
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, ,
definitions=2019-01-18_10:, , signatures=0
X-Proofpoint-Details: rule=outbound_notspam policy=outbound score=0
priorityscore=1501
malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0
clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0
mlxlogscore=975 adultscore=0 classifier=spam adjust=0 reason=mlx
scancount=1 engine=8.0.1-1810050000 definitions=main-1901180121
X-Mailman-Approved-At: Sat, 19 Jan 2019 00:14:28 +0100
Subject: Re: [dpdk-dev] [PATCH 2/2] net/qede: fix prefetch from incorrect
place in Tx path
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 18 Jan 2019 16:58:58 -0000
>From: dev <dev-bounces@dpdk.org> On Behalf Of Shahed Shaikh
>Sent: Friday, January 18, 2019 2:30 AM
>
>Incorrect placement of prefetch in Tx path is causing a performance drop o=
f
>around ~2% on AMD platform.
>
>Fixes: 2ea6f76aff40 ("qede: add core driver")
>Cc: stable@dpdk.org
>
>Signed-off-by: Shahed Shaikh <shshaikh@marvell.com>
>---
Acked-by: Rasesh Mody <rmody@marvell.com>
> drivers/net/qede/qede_rxtx.c | 1 -
> 1 file changed, 1 deletion(-)
>
>diff --git a/drivers/net/qede/qede_rxtx.c b/drivers/net/qede/qede_rxtx.c
>index 684c4ae..eda19b2 100644
>--- a/drivers/net/qede/qede_rxtx.c
>+++ b/drivers/net/qede/qede_rxtx.c
>@@ -2181,7 +2181,6 @@ qede_xmit_pkts(void *p_txq, struct rte_mbuf
>**tx_pkts, uint16_t nb_pkts)
>
> txq->nb_tx_avail -=3D bd1->data.nbds;
> txq->sw_tx_prod++;
>- rte_prefetch0(txq->sw_tx_ring[TX_PROD(txq)].mbuf);
> bd_prod =3D
> rte_cpu_to_le_16(ecore_chain_get_prod_idx(&txq->tx_pbl=
));
> #ifdef RTE_LIBRTE_QEDE_DEBUG_TX
>--
>2.7.4