From: Rasesh Mody <rmody@marvell.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"bruce.richardson@intel.com" <bruce.richardson@intel.com>,
"ferruh.yigit@intel.com" <ferruh.yigit@intel.com>,
Jerin Jacob Kollanukkaran <jerinj@marvell.com>,
GR-Everest-DPDK-Dev <GR-Everest-DPDK-Dev@marvell.com>
Subject: Re: [dpdk-dev] [PATCH] net/bnx2x: fix meson build failure
Date: Tue, 5 Nov 2019 20:34:07 +0000 [thread overview]
Message-ID: <BYAPR18MB28383F081EEB334DF8D8CC5DB57E0@BYAPR18MB2838.namprd18.prod.outlook.com> (raw)
>From: Thomas Monjalon <thomas@monjalon.net>
>Sent: Tuesday, November 05, 2019 10:15 AM
>
>01/11/2019 07:02, Rasesh Mody:
>> Use kernel headers for __le* types to avoid potential conflicts
>> resulting in redefinition errors during Linux builds. Add check for
>> BSD builds.
>
>I don't see the error with my test builds.
>Please could you describe a case where it happens?
>And please provide an error log.
>
Without this change, the aarch64 build failed with error [1] below.
[1]
In file included from ../drivers/net/bnx2x/bnx2x.h:22,
from ../drivers/net/bnx2x/bnx2x_ethdev.c:8:
../drivers/net/bnx2x/bnx2x_osal.h:27:17: error: conflicting types for ‘uint64_t’
#define __le64 uint64_t
^~~~~~~~
In file included from /usr/include/stdint.h:37,
from /usr/lib/gcc/aarch64-linux-gnu/8/include/stdint.h:9,
from ../lib/librte_eal/common/include/arch/arm/rte_byteorder.h:16,
from ../drivers/net/bnx2x/bnx2x.h:17,
from ../drivers/net/bnx2x/bnx2x_ethdev.c:8:
/usr/include/aarch64-linux-gnu/bits/stdint-uintn.h:27:20: note: previous declaration of ‘uint64_t’ was here
typedef __uint64_t uint64_t;
^~~~~~~~
The details of build environment and complete error log can be found at
https://bugs.dpdk.org/show_bug.cgi?id=355
>> Fixes: 38dff79ba736 ("net/bnx2x: update HSI")
>>
>> Signed-off-by: Rasesh Mody <rmody@marvell.com>
>> Tested-by: Dharmik Thakkar <dharmik.thakkar@arm.com>
>> Tested-by: Gavin Hu <gavin.hu@arm.com>
>> ---
>> +#ifdef __FreeBSD__
>
>Please prefer RTE_EXEC_ENV_FREEBSD
>
I'll send v2 replacing all __FreeBSD__ with RTE_EXEC_ENV_FREEBSD.
next reply other threads:[~2019-11-05 20:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-05 20:34 Rasesh Mody [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-11-01 6:02 Rasesh Mody
2019-11-05 18:14 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BYAPR18MB28383F081EEB334DF8D8CC5DB57E0@BYAPR18MB2838.namprd18.prod.outlook.com \
--to=rmody@marvell.com \
--cc=GR-Everest-DPDK-Dev@marvell.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=jerinj@marvell.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).