From: Rasesh Mody <rmody@marvell.com>
To: Jerin Jacob <jerinjacobk@gmail.com>
Cc: Igor Russkikh <irusskikh@marvell.com>,
Balazs Nemeth <bnemeth@redhat.com>,
"dev@dpdk.org" <dev@dpdk.org>,
Devendra Singh Rawat <dsinghrawat@marvell.com>
Subject: Re: [dpdk-dev] [EXT] Re: [PATCH v2] net/qede: fix regression introduced by b10231aed1ed
Date: Tue, 12 Jan 2021 05:55:43 +0000 [thread overview]
Message-ID: <BYAPR18MB2838BA3F849DC60470C2BD1BB5AA9@BYAPR18MB2838.namprd18.prod.outlook.com> (raw)
In-Reply-To: <CALBAE1NgSGVeY2SLEJdw-VkYsa+M+XFkEfOz29usKCbAFUGjJA@mail.gmail.com>
> From: Jerin Jacob <jerinjacobk@gmail.com>
> Sent: Tuesday, January 12, 2021 10:21 AM
>
> On Mon, Jan 4, 2021 at 7:47 PM Rasesh Mody <rmody@marvell.com> wrote:
> >
> > > From: dev <dev-bounces@dpdk.org> On Behalf Of Igor Russkikh
> > > Sent: Monday, January 4, 2021 6:15 PM
> > >
> > > > When calling rte_eth_promiscuous_enable(port_id) followed by
> > > > rte_eth_allmulticast_enable(port_id), the port is not in promisc
> > > > mode anymore. This patch ensures that promisc mode takes
> > > > precedence over allmulticast mode fixing the regression introduced by
> b10231aed1ed.
>
> Please add Fixes:
>
> > > >
> > > > Signed-off-by: Balazs Nemeth <bnemeth@redhat.com>
>
> Rasesh, Devendra,
>
> Waiting for your ack to merge this.
>
>
> > > > ---
> > > > drivers/net/qede/qede_ethdev.c | 2 ++
> > > > 1 file changed, 2 insertions(+)
> > > >
> > > > diff --git a/drivers/net/qede/qede_ethdev.c
> > > > b/drivers/net/qede/qede_ethdev.c index 549013557..3bec62d82
> 100644
> > > > --- a/drivers/net/qede/qede_ethdev.c
> > > > +++ b/drivers/net/qede/qede_ethdev.c
> > > > @@ -1885,6 +1885,8 @@ static int qede_allmulticast_enable(struct
> > > > rte_eth_dev *eth_dev)
> > > > QED_FILTER_RX_MODE_TYPE_MULTI_PROMISC;
> > > > enum _ecore_status_t ecore_status;
> > > >
> > > > + if (rte_eth_promiscuous_get(eth_dev->data->port_id) == 1)
> > > > + type = QED_FILTER_RX_MODE_TYPE_PROMISC;
> > > > ecore_status = qed_configure_filter_rx_mode(eth_dev, type);
> > > >
> > > > return ecore_status >= ECORE_SUCCESS ? 0 : -EAGAIN;
> > >
> > > Hi Balazs, thanks for posting!
> > >
> > > I think we need Fixes tag here.
> >
> > Please Cc: stable@dpdk.org so that all the stable releases also integrate this
> change.
> >
> > Thanks,
> > Rasesh
> >
> > >
> > > Devendra, could you please check if thats enough? May be we should
> > > consider more of internal states here? What if we'll do
> > > promisc_disable() after that?
> > > Will allmulti state persist?
> > >
Even if promiscuous mode is disabled after the change, allmulti mode setting will persist.
Fix looks good to me.
Acked-by: Rasesh Mody <rmody@marvell.com>
Thanks,
Rasesh
> > > Igor
next prev parent reply other threads:[~2021-01-12 5:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-23 14:15 [dpdk-dev] " Balazs Nemeth
2021-01-04 12:44 ` Igor Russkikh
2021-01-04 14:17 ` [dpdk-dev] [EXT] " Rasesh Mody
2021-01-12 4:50 ` Jerin Jacob
2021-01-12 5:55 ` Rasesh Mody [this message]
2021-01-14 13:29 ` Jerin Jacob
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BYAPR18MB2838BA3F849DC60470C2BD1BB5AA9@BYAPR18MB2838.namprd18.prod.outlook.com \
--to=rmody@marvell.com \
--cc=bnemeth@redhat.com \
--cc=dev@dpdk.org \
--cc=dsinghrawat@marvell.com \
--cc=irusskikh@marvell.com \
--cc=jerinjacobk@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).