From: Rasesh Mody <rmody@marvell.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>,
Shahed Shaikh <shshaikh@marvell.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [EXT] [PATCH 1/4] net/qede: fix build with gcc 11
Date: Fri, 25 Sep 2020 04:27:58 +0000 [thread overview]
Message-ID: <BYAPR18MB2838D61B2216C489466D2F42B5390@BYAPR18MB2838.namprd18.prod.outlook.com> (raw)
In-Reply-To: <20200921133830.1575872-1-ferruh.yigit@intel.com>
Hi Ferruh,
>From: Ferruh Yigit <ferruh.yigit@intel.com>
>Sent: Monday, September 21, 2020 6:38 AM
>
>Error observed with gcc 11 under development gcc (GCC) 11.0.0 20200920
>(experimental)
>
>build error:
>../drivers/net/qede/qede_main.c: In function ‘qed_get_current_link’:
>../drivers/net/qede/qede_main.c:587:17:
> warning: this ‘if’ clause does not guard...
> [-Wmisleading-indentation]
> 587 | if (!ptt)
> | ^~
>../drivers/net/qede/qede_main.c:590:25:
> note: ...this statement, but the latter is misleadingly indented
> as if it were guarded by the ‘if’
> 590 | qed_fill_link(hwfn, ptt, if_link);
> | ^~~~~~~~~~~~~
>
>Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
>---
>I am not clear what the exact intention of the original code is, compiler
>warning is about wrong indentation of 'qed_fill_link(..)', I have updated the
>code to keep the behavior same but fix the indentation.
>Please send a proper fix if the existing behavior needs to be updated.
The existing behavior needs to be fixed, I'll send a proper fix for 20.11.
Thanks!
-Rasesh
next prev parent reply other threads:[~2020-09-25 4:28 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-21 13:38 [dpdk-dev] " Ferruh Yigit
2020-09-21 13:38 ` [dpdk-dev] [PATCH 2/4] raw/dpaa2: " Ferruh Yigit
[not found] ` <CAJFAV8wAio=NF2eMMx9URkNinht2sPtBrE9k1c0uD+_GJcM4aw@mail.gmail.com>
[not found] ` <CAJFAV8y9zFUAKoqhQxobdQDVPAOny4ie+Cm1fHneEX6g6zdtjw@mail.gmail.com>
[not found] ` <AM5PR0401MB2593386BAB0C09ABE92F9D65E60B0@AM5PR0401MB2593.eurprd04.prod.outlook.com>
2020-10-08 10:40 ` David Marchand
2020-10-08 11:29 ` Ferruh Yigit
2020-09-21 13:38 ` [dpdk-dev] [PATCH 3/4] app/testpmd: " Ferruh Yigit
2020-09-24 9:31 ` David Marchand
2020-10-04 8:57 ` Asaf Penso
2020-09-24 11:01 ` Phil Yang
2020-10-08 10:48 ` David Marchand
2020-09-21 13:38 ` [dpdk-dev] [PATCH 4/4] pmdinfogen: " Ferruh Yigit
2020-09-24 9:32 ` David Marchand
2020-10-08 10:48 ` David Marchand
2020-09-25 4:27 ` Rasesh Mody [this message]
2020-10-06 12:38 ` [dpdk-dev] [EXT] [PATCH 1/4] net/qede: " David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BYAPR18MB2838D61B2216C489466D2F42B5390@BYAPR18MB2838.namprd18.prod.outlook.com \
--to=rmody@marvell.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=shshaikh@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).