* [dpdk-dev] [PATCH v2] net/qede: fix regression introduced by b10231aed1ed
@ 2020-12-23 14:15 Balazs Nemeth
2021-01-04 12:44 ` Igor Russkikh
0 siblings, 1 reply; 6+ messages in thread
From: Balazs Nemeth @ 2020-12-23 14:15 UTC (permalink / raw)
To: dev
When calling rte_eth_promiscuous_enable(port_id) followed by
rte_eth_allmulticast_enable(port_id), the port is not in promisc mode
anymore. This patch ensures that promisc mode takes precedence over
allmulticast mode fixing the regression introduced by b10231aed1ed.
Signed-off-by: Balazs Nemeth <bnemeth@redhat.com>
---
drivers/net/qede/qede_ethdev.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/qede/qede_ethdev.c b/drivers/net/qede/qede_ethdev.c
index 549013557..3bec62d82 100644
--- a/drivers/net/qede/qede_ethdev.c
+++ b/drivers/net/qede/qede_ethdev.c
@@ -1885,6 +1885,8 @@ static int qede_allmulticast_enable(struct rte_eth_dev *eth_dev)
QED_FILTER_RX_MODE_TYPE_MULTI_PROMISC;
enum _ecore_status_t ecore_status;
+ if (rte_eth_promiscuous_get(eth_dev->data->port_id) == 1)
+ type = QED_FILTER_RX_MODE_TYPE_PROMISC;
ecore_status = qed_configure_filter_rx_mode(eth_dev, type);
return ecore_status >= ECORE_SUCCESS ? 0 : -EAGAIN;
--
2.26.2
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH v2] net/qede: fix regression introduced by b10231aed1ed
2020-12-23 14:15 [dpdk-dev] [PATCH v2] net/qede: fix regression introduced by b10231aed1ed Balazs Nemeth
@ 2021-01-04 12:44 ` Igor Russkikh
2021-01-04 14:17 ` [dpdk-dev] [EXT] " Rasesh Mody
0 siblings, 1 reply; 6+ messages in thread
From: Igor Russkikh @ 2021-01-04 12:44 UTC (permalink / raw)
To: Balazs Nemeth, dev, Devendra Singh Rawat
> When calling rte_eth_promiscuous_enable(port_id) followed by
> rte_eth_allmulticast_enable(port_id), the port is not in promisc mode
> anymore. This patch ensures that promisc mode takes precedence over
> allmulticast mode fixing the regression introduced by b10231aed1ed.
>
> Signed-off-by: Balazs Nemeth <bnemeth@redhat.com>
> ---
> drivers/net/qede/qede_ethdev.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/net/qede/qede_ethdev.c
> b/drivers/net/qede/qede_ethdev.c
> index 549013557..3bec62d82 100644
> --- a/drivers/net/qede/qede_ethdev.c
> +++ b/drivers/net/qede/qede_ethdev.c
> @@ -1885,6 +1885,8 @@ static int qede_allmulticast_enable(struct
> rte_eth_dev *eth_dev)
> QED_FILTER_RX_MODE_TYPE_MULTI_PROMISC;
> enum _ecore_status_t ecore_status;
>
> + if (rte_eth_promiscuous_get(eth_dev->data->port_id) == 1)
> + type = QED_FILTER_RX_MODE_TYPE_PROMISC;
> ecore_status = qed_configure_filter_rx_mode(eth_dev, type);
>
> return ecore_status >= ECORE_SUCCESS ? 0 : -EAGAIN;
Hi Balazs, thanks for posting!
I think we need Fixes tag here.
Devendra, could you please check if thats enough? May be we should consider
more of internal states here? What if we'll do promisc_disable() after that?
Will allmulti state persist?
Igor
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [EXT] Re: [PATCH v2] net/qede: fix regression introduced by b10231aed1ed
2021-01-04 12:44 ` Igor Russkikh
@ 2021-01-04 14:17 ` Rasesh Mody
2021-01-12 4:50 ` Jerin Jacob
0 siblings, 1 reply; 6+ messages in thread
From: Rasesh Mody @ 2021-01-04 14:17 UTC (permalink / raw)
To: Igor Russkikh, Balazs Nemeth, dev, Devendra Singh Rawat
> From: dev <dev-bounces@dpdk.org> On Behalf Of Igor Russkikh
> Sent: Monday, January 4, 2021 6:15 PM
>
> > When calling rte_eth_promiscuous_enable(port_id) followed by
> > rte_eth_allmulticast_enable(port_id), the port is not in promisc mode
> > anymore. This patch ensures that promisc mode takes precedence over
> > allmulticast mode fixing the regression introduced by b10231aed1ed.
> >
> > Signed-off-by: Balazs Nemeth <bnemeth@redhat.com>
> > ---
> > drivers/net/qede/qede_ethdev.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/net/qede/qede_ethdev.c
> > b/drivers/net/qede/qede_ethdev.c index 549013557..3bec62d82 100644
> > --- a/drivers/net/qede/qede_ethdev.c
> > +++ b/drivers/net/qede/qede_ethdev.c
> > @@ -1885,6 +1885,8 @@ static int qede_allmulticast_enable(struct
> > rte_eth_dev *eth_dev)
> > QED_FILTER_RX_MODE_TYPE_MULTI_PROMISC;
> > enum _ecore_status_t ecore_status;
> >
> > + if (rte_eth_promiscuous_get(eth_dev->data->port_id) == 1)
> > + type = QED_FILTER_RX_MODE_TYPE_PROMISC;
> > ecore_status = qed_configure_filter_rx_mode(eth_dev, type);
> >
> > return ecore_status >= ECORE_SUCCESS ? 0 : -EAGAIN;
>
> Hi Balazs, thanks for posting!
>
> I think we need Fixes tag here.
Please Cc: stable@dpdk.org so that all the stable releases also integrate this change.
Thanks,
Rasesh
>
> Devendra, could you please check if thats enough? May be we should
> consider more of internal states here? What if we'll do promisc_disable()
> after that?
> Will allmulti state persist?
>
> Igor
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [EXT] Re: [PATCH v2] net/qede: fix regression introduced by b10231aed1ed
2021-01-04 14:17 ` [dpdk-dev] [EXT] " Rasesh Mody
@ 2021-01-12 4:50 ` Jerin Jacob
2021-01-12 5:55 ` Rasesh Mody
0 siblings, 1 reply; 6+ messages in thread
From: Jerin Jacob @ 2021-01-12 4:50 UTC (permalink / raw)
To: Rasesh Mody; +Cc: Igor Russkikh, Balazs Nemeth, dev, Devendra Singh Rawat
On Mon, Jan 4, 2021 at 7:47 PM Rasesh Mody <rmody@marvell.com> wrote:
>
> > From: dev <dev-bounces@dpdk.org> On Behalf Of Igor Russkikh
> > Sent: Monday, January 4, 2021 6:15 PM
> >
> > > When calling rte_eth_promiscuous_enable(port_id) followed by
> > > rte_eth_allmulticast_enable(port_id), the port is not in promisc mode
> > > anymore. This patch ensures that promisc mode takes precedence over
> > > allmulticast mode fixing the regression introduced by b10231aed1ed.
Please add Fixes:
> > >
> > > Signed-off-by: Balazs Nemeth <bnemeth@redhat.com>
Rasesh, Devendra,
Waiting for your ack to merge this.
> > > ---
> > > drivers/net/qede/qede_ethdev.c | 2 ++
> > > 1 file changed, 2 insertions(+)
> > >
> > > diff --git a/drivers/net/qede/qede_ethdev.c
> > > b/drivers/net/qede/qede_ethdev.c index 549013557..3bec62d82 100644
> > > --- a/drivers/net/qede/qede_ethdev.c
> > > +++ b/drivers/net/qede/qede_ethdev.c
> > > @@ -1885,6 +1885,8 @@ static int qede_allmulticast_enable(struct
> > > rte_eth_dev *eth_dev)
> > > QED_FILTER_RX_MODE_TYPE_MULTI_PROMISC;
> > > enum _ecore_status_t ecore_status;
> > >
> > > + if (rte_eth_promiscuous_get(eth_dev->data->port_id) == 1)
> > > + type = QED_FILTER_RX_MODE_TYPE_PROMISC;
> > > ecore_status = qed_configure_filter_rx_mode(eth_dev, type);
> > >
> > > return ecore_status >= ECORE_SUCCESS ? 0 : -EAGAIN;
> >
> > Hi Balazs, thanks for posting!
> >
> > I think we need Fixes tag here.
>
> Please Cc: stable@dpdk.org so that all the stable releases also integrate this change.
>
> Thanks,
> Rasesh
>
> >
> > Devendra, could you please check if thats enough? May be we should
> > consider more of internal states here? What if we'll do promisc_disable()
> > after that?
> > Will allmulti state persist?
> >
> > Igor
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [EXT] Re: [PATCH v2] net/qede: fix regression introduced by b10231aed1ed
2021-01-12 4:50 ` Jerin Jacob
@ 2021-01-12 5:55 ` Rasesh Mody
2021-01-14 13:29 ` Jerin Jacob
0 siblings, 1 reply; 6+ messages in thread
From: Rasesh Mody @ 2021-01-12 5:55 UTC (permalink / raw)
To: Jerin Jacob; +Cc: Igor Russkikh, Balazs Nemeth, dev, Devendra Singh Rawat
> From: Jerin Jacob <jerinjacobk@gmail.com>
> Sent: Tuesday, January 12, 2021 10:21 AM
>
> On Mon, Jan 4, 2021 at 7:47 PM Rasesh Mody <rmody@marvell.com> wrote:
> >
> > > From: dev <dev-bounces@dpdk.org> On Behalf Of Igor Russkikh
> > > Sent: Monday, January 4, 2021 6:15 PM
> > >
> > > > When calling rte_eth_promiscuous_enable(port_id) followed by
> > > > rte_eth_allmulticast_enable(port_id), the port is not in promisc
> > > > mode anymore. This patch ensures that promisc mode takes
> > > > precedence over allmulticast mode fixing the regression introduced by
> b10231aed1ed.
>
> Please add Fixes:
>
> > > >
> > > > Signed-off-by: Balazs Nemeth <bnemeth@redhat.com>
>
> Rasesh, Devendra,
>
> Waiting for your ack to merge this.
>
>
> > > > ---
> > > > drivers/net/qede/qede_ethdev.c | 2 ++
> > > > 1 file changed, 2 insertions(+)
> > > >
> > > > diff --git a/drivers/net/qede/qede_ethdev.c
> > > > b/drivers/net/qede/qede_ethdev.c index 549013557..3bec62d82
> 100644
> > > > --- a/drivers/net/qede/qede_ethdev.c
> > > > +++ b/drivers/net/qede/qede_ethdev.c
> > > > @@ -1885,6 +1885,8 @@ static int qede_allmulticast_enable(struct
> > > > rte_eth_dev *eth_dev)
> > > > QED_FILTER_RX_MODE_TYPE_MULTI_PROMISC;
> > > > enum _ecore_status_t ecore_status;
> > > >
> > > > + if (rte_eth_promiscuous_get(eth_dev->data->port_id) == 1)
> > > > + type = QED_FILTER_RX_MODE_TYPE_PROMISC;
> > > > ecore_status = qed_configure_filter_rx_mode(eth_dev, type);
> > > >
> > > > return ecore_status >= ECORE_SUCCESS ? 0 : -EAGAIN;
> > >
> > > Hi Balazs, thanks for posting!
> > >
> > > I think we need Fixes tag here.
> >
> > Please Cc: stable@dpdk.org so that all the stable releases also integrate this
> change.
> >
> > Thanks,
> > Rasesh
> >
> > >
> > > Devendra, could you please check if thats enough? May be we should
> > > consider more of internal states here? What if we'll do
> > > promisc_disable() after that?
> > > Will allmulti state persist?
> > >
Even if promiscuous mode is disabled after the change, allmulti mode setting will persist.
Fix looks good to me.
Acked-by: Rasesh Mody <rmody@marvell.com>
Thanks,
Rasesh
> > > Igor
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [EXT] Re: [PATCH v2] net/qede: fix regression introduced by b10231aed1ed
2021-01-12 5:55 ` Rasesh Mody
@ 2021-01-14 13:29 ` Jerin Jacob
0 siblings, 0 replies; 6+ messages in thread
From: Jerin Jacob @ 2021-01-14 13:29 UTC (permalink / raw)
To: Rasesh Mody, Ferruh Yigit
Cc: Igor Russkikh, Balazs Nemeth, dev, Devendra Singh Rawat
On Tue, Jan 12, 2021 at 11:25 AM Rasesh Mody <rmody@marvell.com> wrote:
>
> > From: Jerin Jacob <jerinjacobk@gmail.com>
> > Sent: Tuesday, January 12, 2021 10:21 AM
> >
> > On Mon, Jan 4, 2021 at 7:47 PM Rasesh Mody <rmody@marvell.com> wrote:
> > >
> > > > From: dev <dev-bounces@dpdk.org> On Behalf Of Igor Russkikh
> > > > Sent: Monday, January 4, 2021 6:15 PM
> > > >
> > > > > When calling rte_eth_promiscuous_enable(port_id) followed by
> > > > > rte_eth_allmulticast_enable(port_id), the port is not in promisc
> > > > > mode anymore. This patch ensures that promisc mode takes
> > > > > precedence over allmulticast mode fixing the regression introduced by
> > b10231aed1ed.
> >
> > Please add Fixes:
> >
> > > > >
> > > > > Signed-off-by: Balazs Nemeth <bnemeth@redhat.com>
> >
>
> Even if promiscuous mode is disabled after the change, allmulti mode setting will persist.
> Fix looks good to me.
>
> Acked-by: Rasesh Mody <rmody@marvell.com>
Fixed check-git-log.sh issues and applied to dpdk-next-net-mrvl/for-main. Thanks
>
> Thanks,
> Rasesh
>
> > > > Igor
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-01-14 13:29 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-23 14:15 [dpdk-dev] [PATCH v2] net/qede: fix regression introduced by b10231aed1ed Balazs Nemeth
2021-01-04 12:44 ` Igor Russkikh
2021-01-04 14:17 ` [dpdk-dev] [EXT] " Rasesh Mody
2021-01-12 4:50 ` Jerin Jacob
2021-01-12 5:55 ` Rasesh Mody
2021-01-14 13:29 ` Jerin Jacob
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).