From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id DA4DAA2F63 for ; Thu, 3 Oct 2019 20:29:21 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id EC2EC1C126; Thu, 3 Oct 2019 20:29:20 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by dpdk.org (Postfix) with ESMTP id 495761C123; Thu, 3 Oct 2019 20:29:19 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id x93IFKj7012789; Thu, 3 Oct 2019 11:29:14 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : content-type : content-transfer-encoding : mime-version; s=pfpt0818; bh=YGFKYNV0IbLgfF7HrKpu/ED92yWpcq38IB4JRWs/tHI=; b=E5eySx3S6rSUWiQhbS39q+k3Ull5uaInCRh32511iZ6eEdM0dg1RpL4ZszcohU7d0uJN ezM4AUVVYrEC1UNKiT3Tvbdqlr65i6zfmjh1Pfq7nQpA73q/C1YCJwvRsMdk4aHByEpC rzPfN1FTFHCwKYhvUdfTbk81umr6Q7uoiLCWF31wBCtfB64TV80NGwXA7uTK02eXP63k v2G33s66+DE3fTecR3rHIpFXhwaUByTnulFJ2wzBKAbaNWvwhCzumYK/hhIQoVXAETs3 OS6JM5i7CIqXaq4pK5nz68y74FLZr8B25C6+yv7E7E4j/tTyPkLfxMPtZJy3lM3ox1XK mQ== Received: from sc-exch01.marvell.com ([199.233.58.181]) by mx0b-0016f401.pphosted.com with ESMTP id 2vd0ya4r8r-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Thu, 03 Oct 2019 11:29:14 -0700 Received: from SC-EXCH02.marvell.com (10.93.176.82) by SC-EXCH01.marvell.com (10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Thu, 3 Oct 2019 11:29:13 -0700 Received: from NAM05-BY2-obe.outbound.protection.outlook.com (104.47.50.55) by SC-EXCH02.marvell.com (10.93.176.82) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Thu, 3 Oct 2019 11:29:13 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FuUSUpxRcM6Japfz2WQEfoUbkQ/Cv8lIaDQd/zzYIq4dKl7zVrbfkVn5pYfk3D7oV+FtvdCe6w7beVDp69kcKXBW/p9RB0hmOyYG9zu0nvI/d7Ps5gyxfQelCk8dvm5P4eq49pC3ByiVAM6L07i88eoEkp9U8PFDi8J81tlgW8Ve+EhWG/0Na+IfM3p0TgNBHuVF9YMYOJnaYBJNj5Oo8pGKpj6VcaFSXGo9RjKOmxxxTp+n41MnqSf190Hoxu7YeuBMakp0A5OACgZlgjPAC5QIjJHHN231mBMJDwKoK3OW7bIigXy6MAZX//zKqEpNXTR2CALiyOKXhIi2m2dk4g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YGFKYNV0IbLgfF7HrKpu/ED92yWpcq38IB4JRWs/tHI=; b=QhIeAWpq1rKdzejIatj1eFZNPQ6wfpsScJpGUrtQN9xE9FprCQquBDW1MFuDnlQ9mKQWf4vGoPCuv2knVj3xFJQkwJ3c2QM4POr8IdIU9GKZq9p4pMM3Wo1cv7P+C8vIfPk/wEVDyU5qj+8vxFKoPfrREQtMfKLoT6tnu5Ext0L6/+xnPm4Eo95k62UjYmsS91Pe2xgsff8J5HFJz7Eqi9xc0YMN3k5rNrS/FQagIYZJ2E4e5Yx36PWtAK5X3yvIMeLogm37vhR0DuZbJe8dFMTKytRBQ8Ico7M2RKpWhd08Wp5f4UYiqRjS0RP2lm50NP7rtGeAKGVBbLaTFvwnSg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector2-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YGFKYNV0IbLgfF7HrKpu/ED92yWpcq38IB4JRWs/tHI=; b=Bx+ctnd0yav0xuul0XWTF4s/FqZMM4poL8SyV34lfYFDrDBYa2kG8ZAX/CEnPxePWTmHyqO4tHUNXbcw5qaMNcbqLAlPmwYu0077dqIX+C+bBnM4wU7miwohHRykeTd7mzyho5D+e4T/BA1L3J74ZYEUcmlRYICfHiW8BXZ/41s= Received: from BYAPR18MB2838.namprd18.prod.outlook.com (20.179.58.18) by BYAPR18MB2438.namprd18.prod.outlook.com (20.179.91.207) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2305.20; Thu, 3 Oct 2019 18:29:12 +0000 Received: from BYAPR18MB2838.namprd18.prod.outlook.com ([fe80::6048:aae:77a3:4961]) by BYAPR18MB2838.namprd18.prod.outlook.com ([fe80::6048:aae:77a3:4961%3]) with mapi id 15.20.2305.023; Thu, 3 Oct 2019 18:29:12 +0000 From: Rasesh Mody To: David Marchand , "dev@dpdk.org" CC: "stable@dpdk.org" , Shahed Shaikh Thread-Topic: [PATCH] net/qede: only access sw rx ring index for debug Thread-Index: AdV6GGrZezeoUuZaQDWPBF5basloyQ== Date: Thu, 3 Oct 2019 18:29:12 +0000 Message-ID: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [198.186.1.5] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 88d4c3f9-e664-4bdb-55a6-08d7482f96a5 x-ms-traffictypediagnostic: BYAPR18MB2438: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1201; x-forefront-prvs: 01792087B6 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(396003)(366004)(346002)(136003)(376002)(39860400002)(199004)(189003)(186003)(9686003)(486006)(26005)(66066001)(6246003)(6436002)(316002)(2906002)(229853002)(55016002)(25786009)(52536014)(6506007)(478600001)(7696005)(102836004)(476003)(5660300002)(64756008)(66446008)(14444005)(74316002)(7736002)(2501003)(110136005)(71190400001)(76116006)(66476007)(71200400001)(66556008)(8936002)(66946007)(256004)(3846002)(6116002)(107886003)(99286004)(81156014)(33656002)(8676002)(81166006)(86362001)(14454004)(54906003)(305945005)(4326008); DIR:OUT; SFP:1101; SCL:1; SRVR:BYAPR18MB2438; H:BYAPR18MB2838.namprd18.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: OfjDXf3jfnLgrwpTzFWo/JB+sIjaYEB8bQqccctjyWgg9z8EBZFohx+2W3n0xtDusstRcgs7tqAMBwgAudoAy47zcTNDUlLkJVDKwmP9FvAOMkp/CCOTWLTiMYXq9w+Bzw8r4RcihUeBoZEJRagxfxvrjzqCJVENbz1pjnM/YB1kRENpaht2u8UXdP/g19+wgI9eABTZFHHbh4i3aiCgjlvHOcG4t1EdflqsIdYvurm6A/vf5TMBiHKdQ884xsEhEylxGXDiZsjENumEd+GMNpiDHTUtBj+zlgG36RwwUTvm9uqLk1hKcI96AnlIPU0Cb4l5S9fBLedZi7h3kXVqy5WcDgvLf+duJZQmKJePiIpKTzOjrE4RarthIPn/GG7yz0WCisiIr5RB4ee5WgHlbnxHLgffnFkuZhaweDIzOxY= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 88d4c3f9-e664-4bdb-55a6-08d7482f96a5 X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Oct 2019 18:29:12.2656 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: YvOqAVWGA6jEks+KmzYtca5/EVeeLwoDMDH2WAwsxThQUBZ5LBvv9ZK5cBuO6DBJ1WHb1im6Ea6AF4hHHaK61w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR18MB2438 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.95,1.0.8 definitions=2019-10-03_07:2019-10-03,2019-10-03 signatures=0 Subject: Re: [dpdk-dev] [PATCH] net/qede: only access sw rx ring index for debug X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" >From: David Marchand >Sent: Friday, September 27, 2019 4:29 AM > >---------------------------------------------------------------------- >Caught by clang, this idx value is only used for a debug message when the >mbufs allocation fails. >No need to use idx as a temporary storage. > >Fixes: 8f2312474529 ("net/qede: fix performance bottleneck in Rx path") >Cc: stable@dpdk.org > >Signed-off-by: David Marchand >--- Acked-by: Rasesh Mody Thanks! -Rasesh > drivers/net/qede/qede_rxtx.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > >diff --git a/drivers/net/qede/qede_rxtx.c b/drivers/net/qede/qede_rxtx.c >index c38cbb9..1fbeba2 100644 >--- a/drivers/net/qede/qede_rxtx.c >+++ b/drivers/net/qede/qede_rxtx.c >@@ -46,8 +46,6 @@ static inline int qede_alloc_rx_bulk_mbufs(struct >qede_rx_queue *rxq, int count) > int i, ret =3D 0; > uint16_t idx; > >- idx =3D rxq->sw_rx_prod & NUM_RX_BDS(rxq); >- > if (count > QEDE_MAX_BULK_ALLOC_COUNT) > count =3D QEDE_MAX_BULK_ALLOC_COUNT; > >@@ -56,7 +54,9 @@ static inline int qede_alloc_rx_bulk_mbufs(struct >qede_rx_queue *rxq, int count) > PMD_RX_LOG(ERR, rxq, > "Failed to allocate %d rx buffers " > "sw_rx_prod %u sw_rx_cons %u mp entries %u free >%u", >- count, idx, rxq->sw_rx_cons & NUM_RX_BDS(rxq), >+ count, >+ rxq->sw_rx_prod & NUM_RX_BDS(rxq), >+ rxq->sw_rx_cons & NUM_RX_BDS(rxq), > rte_mempool_avail_count(rxq->mb_pool), > rte_mempool_in_use_count(rxq->mb_pool)); > return -ENOMEM; >-- >1.8.3.1