From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4457CA0C45; Wed, 20 Oct 2021 04:33:59 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0086F40683; Wed, 20 Oct 2021 04:33:58 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by mails.dpdk.org (Postfix) with ESMTP id 4175A40142 for ; Wed, 20 Oct 2021 04:33:57 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 19K2OZFQ015153; Tue, 19 Oct 2021 19:33:56 -0700 Received: from nam10-bn7-obe.outbound.protection.outlook.com (mail-bn7nam10lp2103.outbound.protection.outlook.com [104.47.70.103]) by mx0a-0016f401.pphosted.com with ESMTP id 3btaa7812j-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 19 Oct 2021 19:33:56 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gFV783HsnAfSQ0D834gGVkp+F3lwJa6VO3SdzPLMltEEjoitcjxlsNk8IDxbitXBkrjpFgZouKBJyAsy76s7zA+VvWtXcdLaCxntcffZuvFBWOtFkeCfppTWBP+CzmlV5/JYlraMkYcsCSKtI7w4t55qq2wCc+o0LTeqmuVDkNITouFsmfvxZOUpl4PSvJA6+GDPTLIAN8OvgpN4vfRjY8Kl33jk/LInSIAGFs2Ggz41YtKFlEozSDvD3TkoWuSFE8THfaK0kC1jDyKc3vkZK0jxplnAgOlBpL7bS3y9s/MASj0JXScgJm0Dm0i4AUkeEgRC8JknZrA8PKrRUAxL4A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jeNnn3IrHuXeEGRx6i2rwh4uJNV8WmYtFPdOW6iosBg=; b=LKm74GmizJZPn0KhKY9lzrgXjw3wCdjaf/aSEO52PojcvV/VSzAr/L1qbUBMK8DRz8Zh9L6T4lJ8hNOv5sJOJMzsFwGUl5mL+CbBQgcsqQQitXlKpgSHW2jKPlYLUKDC25yPCohz4GHnQ6PHbs45TKmHy6XoEZJa91OBFh/vkS9XdglL0ZFdnnrVIA/g0DKJDeZ6JoLIgS/33l+2gF7XmolJhcYS+yRYXlE9RiUZBbkSlz6eZfkuta6HUlyhiI8Rb1eKkC/ec0Q5j8iIRabAL1kgQhJ4ZSPwE5kaw9uWBNuIcT/jaIA9/za7qFbsjlZa8b35iHRg4J2Z9W01BLUm9A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jeNnn3IrHuXeEGRx6i2rwh4uJNV8WmYtFPdOW6iosBg=; b=Hq8EXGzUgM1wYTDfnB6kpiP4AwYPumTh8yskJYl2JZphB2pfUnNsEtojoZhQ2G0Fsw+6d2wCNWCSJ2FAGatpN//7U6jRDGXD77GJx/vp3oE2QJD3omhkGBiAB9z8HCkD078mzawK2/K2mVnoFFj9iBcRmfZQyGNgbX8YcY9VCxE= Received: from BYAPR18MB2965.namprd18.prod.outlook.com (2603:10b6:a03:10c::30) by BYAPR18MB3064.namprd18.prod.outlook.com (2603:10b6:a03:10a::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.17; Wed, 20 Oct 2021 02:33:51 +0000 Received: from BYAPR18MB2965.namprd18.prod.outlook.com ([fe80::6813:f244:e9f4:2695]) by BYAPR18MB2965.namprd18.prod.outlook.com ([fe80::6813:f244:e9f4:2695%3]) with mapi id 15.20.4608.018; Wed, 20 Oct 2021 02:33:51 +0000 From: Kiran Kumar Kokkilagadda To: Ivan Malov , "dev@dpdk.org" CC: Ferruh Yigit , Thomas Monjalon , Ori Kam , Andrew Rybchenko , Jerin Jacob Kollanukkaran , Nithin Kumar Dabilpuram Thread-Topic: [EXT] [PATCH v7 11/12] net/octeontx2: support port representor flow action Thread-Index: AQHXwFiu7uj/mg/H402GyzDc7CYhRqvbNQ1g Date: Wed, 20 Oct 2021 02:33:51 +0000 Message-ID: References: <20211001134716.1608857-1-andrew.rybchenko@oktetlabs.ru> <20211013173448.28621-1-ivan.malov@oktetlabs.ru> <20211013173448.28621-12-ivan.malov@oktetlabs.ru> In-Reply-To: <20211013173448.28621-12-ivan.malov@oktetlabs.ru> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 04889b04-dcec-4081-0658-08d993720d86 x-ms-traffictypediagnostic: BYAPR18MB3064: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:3276; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: SFx+jk1zonsHEl7FFL2+2bKPUa9gvxHshFlbGM0X9/KEfdLFxgqLGK2QX6Pr8IC5SaM6L219Iq0DQfyVk2TholbhV8lRRe+Cxm+8CS42aRjiLueCEh/Qrd67TUxx/lSrE3Q/agWk/bvCoQtc/ucnpmvRaTtMJ2OJ7TFbsiHnvScfQn0+AEG6OWJI4QbYBFZMGOqKUf9Lw8/fLuHExh8MqREXD3DJije2vxYM4Dnh/BLQ5JEJNRyi2MYI3vjdcO3ebUldNIe7LIZy2LEwzP1N7jKEPTxaVOqmImSLbDh69DiyxL8IsrWrgQqcQ31hRj+2NWYZhXWRic3xsEw55SVv0B6gTaUmwOjrZ7P8/1QKH1zHb2ewu2vT/rq8kYHfI/8vcqZpPdMRzGh9PMWLe14tZxbPRQUbA10gYmrnGh2OiGMGfY5IvxuQgrvuL8MQM8NMVI6pZ6D208IkRowC0A5qhVOUh3YgP+0etjmruiIOi1/9UHY+GTvS6y3bhkZ3TmkZoF4qG1+YtjeGQYHGqcBpqrSqkRYqJulmiFGG4SvsG2LzEflFUTXf/Qzfi+2TLtceNfzZ9ldr1Xvy4BMfcqbVVoAtoMpxlylPQoFh9urErskt6scn/jig0VoEMUFLCJJXTvfQkB4NZPUdE8msX/bkDIxAqP/11dybk8/C4x0tHtNIYNXTaFMe9uLnEzEgyrKjl48KlVrH/03ZZvGlalZqUA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR18MB2965.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(83380400001)(6506007)(76116006)(66556008)(107886003)(122000001)(38100700002)(71200400001)(53546011)(55016002)(186003)(33656002)(52536014)(110136005)(64756008)(86362001)(7696005)(4326008)(2906002)(5660300002)(54906003)(8676002)(26005)(66446008)(66476007)(8936002)(38070700005)(9686003)(66946007)(508600001)(316002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?4oWv9SdjCeF0neACHCq1wwzDA4V4dgOjVDKim7UPD6CamtFSs2RwijrNiNVY?= =?us-ascii?Q?knlPMbu8W7KiQQlHiPEtgcCpo215xY4VTzQWxK//yYqhWkSWYV/fUF7msihS?= =?us-ascii?Q?91JI2+Fzh+QCeRRT8xLjfpKNoi8VRjA5gZevBHktN4+CrsjejQ3VfmNOiW5A?= =?us-ascii?Q?7povXJba3upBkqya+9z495QjFcOgcxLowx9wslSo4mq0q4afL8pt6rWaZHZi?= =?us-ascii?Q?OYO1DQ4Fv8MrSLpfxmEJcQsDD3MSiXCYWmHqLCqVXXS9RfSTDnF5a/7/pFjs?= =?us-ascii?Q?n3ghe/35pwjRdsqB1eO2zlWf6R74mGC2JHyi/WN6ocUmL0XVH8w4ShSmjz7E?= =?us-ascii?Q?dLz5+4BR7i6aL0BJ8fN4PixZO3g+ZrqZwquD42017yT0+XMeOjaGwfG1vzl4?= =?us-ascii?Q?OXUkoE4lrgkE73voVr95tR25a6VHZg9k3GzsKfH7+0avEbZR+658k9pEdTk7?= =?us-ascii?Q?9N5Td5Drn++Yrp2zLBnKJc5iGYWbPu6RweegwBIscCDWZ7sGuZl+DXRZqRC/?= =?us-ascii?Q?XNNIgtC9KKw4qVWJrHNhpdkI2R43XPp59u/hf7SMlu/XXHTtn77A9XKqsqRB?= =?us-ascii?Q?c4FOuwMZOsDF39+kwgDEV2b5aBQm2xL6RHtpZFctVlI8BKl2NnHI7aei1s28?= =?us-ascii?Q?S2ZMxTO04jMYFTbZyPsJWx3ZINYj3pCry89/Ad9o8i90oIkdR8fY9SZBJKFE?= =?us-ascii?Q?lSi5zbOwaDN4y51Wl05W2ioPKaqjuvnT7FIGdlomLfKz/VmtrIMm8ufLkZR1?= =?us-ascii?Q?hcLr1ob3vs76H9xAq/RgTe6py8eimQQnD8JPX9tyof5xwrkBWkyCc0q1l+4+?= =?us-ascii?Q?RSUd1mzG74yX+AA+I/gxqE5W/7pXt2kzLcj1HOqbmHMZW5zx1wv2mhTIEOjv?= =?us-ascii?Q?UFv8ZYK0KaWMQnH4gWSzH9WALQfBKV/IjjBVALneI8/o5h7+ibWFa9DP/JDO?= =?us-ascii?Q?sHVLbDrMwYC4hS2Zh5PDzZEbclHFJdq24x5R+XqVX8chN5pzmw+SpiEBZa2y?= =?us-ascii?Q?JlmS1TA7nXbyUp1v2Ulfw4uTqvwo0Z7mJAY0AEq+X5ZAIAEwPmVqDhgOt5jA?= =?us-ascii?Q?JFMP7LW4I2TIh8JGV9bZzi3HXvp05xGsBTf79UP+2lPSH3LsNaweNjyUG3FC?= =?us-ascii?Q?ut707wFIV0xeQD/aX/kY5dHo8Qjl0wNYUyYBIkJPB/OXoBATjcX0cWB61EtG?= =?us-ascii?Q?1hiHV7cDdg6snEDVQxyzU8DHMhJ5cYvL67T29boNcT60uB3E+Oel1Dmsm/Ks?= =?us-ascii?Q?YUUsK2uobnzd068cfK/pyRT8gpC9whArlsWx4d+zu3BbHlCFfzY5jJv7nudP?= =?us-ascii?Q?mFZEpMklqYyNnSLx+WR249a4?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR18MB2965.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 04889b04-dcec-4081-0658-08d993720d86 X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Oct 2021 02:33:51.0448 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: x8TeB+cMPGY+8TCsacKGDbbE8b647kMepu1VxkAnGKCr3UcTOoNQrcx/GJSJBl+gAhu9G6XeAkgKrCfjTmnPfA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR18MB3064 X-Proofpoint-ORIG-GUID: iTJ2WRDcdLrgWTh_Xv-yOgGwHEQVKfMc X-Proofpoint-GUID: iTJ2WRDcdLrgWTh_Xv-yOgGwHEQVKfMc X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.0.607.475 definitions=2021-10-19_02,2021-10-19_01,2020-04-07_01 Subject: Re: [dpdk-dev] [EXT] [PATCH v7 11/12] net/octeontx2: support port representor flow action X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Ivan Malov > Sent: Wednesday, October 13, 2021 11:05 PM > To: dev@dpdk.org > Cc: Ferruh Yigit ; Thomas Monjalon > ; Ori Kam ; Andrew Rybchenko > ; Jerin Jacob Kollanukkaran > ; Nithin Kumar Dabilpuram ; > Kiran Kumar Kokkilagadda > Subject: [EXT] [PATCH v7 11/12] net/octeontx2: support port representor f= low > action >=20 > External Email >=20 > ---------------------------------------------------------------------- > From: Andrew Rybchenko >=20 > Action PORT_ID implementation assumes ingress only. Its semantics suggest= s > that support for equal action PORT_REPRESENTOR be added. >=20 > Signed-off-by: Andrew Rybchenko Acked-by: Kiran Kumar Kokkilagadda > --- > doc/guides/nics/features/octeontx2.ini | 1 + > doc/guides/nics/octeontx2.rst | 5 ++++- > drivers/net/octeontx2/otx2_flow_parse.c | 16 ++++++++++++---- > 3 files changed, 17 insertions(+), 5 deletions(-) >=20 > diff --git a/doc/guides/nics/features/octeontx2.ini > b/doc/guides/nics/features/octeontx2.ini > index fa32bc7890..e0277988d4 100644 > --- a/doc/guides/nics/features/octeontx2.ini > +++ b/doc/guides/nics/features/octeontx2.ini > @@ -91,6 +91,7 @@ of_set_vlan_pcp =3D Y > of_set_vlan_vid =3D Y > pf =3D Y > port_id =3D Y > +port_representor =3D Y > queue =3D Y > rss =3D Y > security =3D Y > diff --git a/doc/guides/nics/octeontx2.rst b/doc/guides/nics/octeontx2.rs= t index > e35c8116f7..eae32f0afe 100644 > --- a/doc/guides/nics/octeontx2.rst > +++ b/doc/guides/nics/octeontx2.rst > @@ -403,10 +403,13 @@ Actions: > +----+-----------------------------------------+ > | 12 | RTE_FLOW_ACTION_TYPE_PORT_ID | > +----+-----------------------------------------+ > + | 13 | RTE_FLOW_ACTION_TYPE_PORT_REPRESENTOR | > + +----+-----------------------------------------+ >=20 > .. note:: >=20 > - ``RTE_FLOW_ACTION_TYPE_PORT_ID`` is only supported between PF and its > VFs. > + ``RTE_FLOW_ACTION_TYPE_PORT_ID``, > ``RTE_FLOW_ACTION_TYPE_PORT_REPRESENTOR`` > + are only supported between PF and its VFs. >=20 > .. _table_octeontx2_supported_egress_action_types: >=20 > diff --git a/drivers/net/octeontx2/otx2_flow_parse.c > b/drivers/net/octeontx2/otx2_flow_parse.c > index 30a232f033..79b92fda8a 100644 > --- a/drivers/net/octeontx2/otx2_flow_parse.c > +++ b/drivers/net/octeontx2/otx2_flow_parse.c > @@ -900,7 +900,6 @@ otx2_flow_parse_actions(struct rte_eth_dev *dev, { > struct otx2_eth_dev *hw =3D dev->data->dev_private; > struct otx2_npc_flow_info *npc =3D &hw->npc_flow; > - const struct rte_flow_action_port_id *port_act; > const struct rte_flow_action_mark *act_mark; > const struct rte_flow_action_queue *act_q; > const struct rte_flow_action_vf *vf_act; @@ -977,9 +976,18 @@ > otx2_flow_parse_actions(struct rte_eth_dev *dev, > break; >=20 > case RTE_FLOW_ACTION_TYPE_PORT_ID: > - port_act =3D (const struct rte_flow_action_port_id *) > - actions->conf; > - port_id =3D port_act->id; > + case RTE_FLOW_ACTION_TYPE_PORT_REPRESENTOR: > + if (actions->type =3D=3D > RTE_FLOW_ACTION_TYPE_PORT_ID) { > + const struct rte_flow_action_port_id > *port_act; > + > + port_act =3D actions->conf; > + port_id =3D port_act->id; > + } else { > + const struct rte_flow_action_ethdev > *ethdev_act; > + > + ethdev_act =3D actions->conf; > + port_id =3D ethdev_act->port_id; > + } > if (rte_eth_dev_get_name_by_port(port_id, if_name)) { > errmsg =3D "Name not found for output port id"; > errcode =3D EINVAL; > -- > 2.20.1