From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id D876DA0096 for ; Fri, 7 Jun 2019 23:59:41 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C17B51BC09; Fri, 7 Jun 2019 23:59:40 +0200 (CEST) Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70041.outbound.protection.outlook.com [40.107.7.41]) by dpdk.org (Postfix) with ESMTP id ED5CB1BC02 for ; Fri, 7 Jun 2019 23:59:39 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=n8V29OWIGF2dZTKDB09Oz5r5NIUC9SXM7yn38/WdQ9s=; b=dP9daMdmA7uWE17PybSWQuE2HtbS0e3XpD1EJSgUtMcXS9P2w6bIRvvbbhuUImmMwRZ8p9FSv9quOB9r8A+VTepAy2s5q2tH5weR7K4VchXTiYy2Ovil6WASWZKsiH97+Cfzi1sm8SSZja3+MJJfp6cI987xhmBTiGEpZ0P4utM= Received: from DB3PR0502MB3980.eurprd05.prod.outlook.com (52.134.72.27) by DB3PR0502MB3962.eurprd05.prod.outlook.com (52.134.67.161) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1965.16; Fri, 7 Jun 2019 21:59:33 +0000 Received: from DB3PR0502MB3980.eurprd05.prod.outlook.com ([fe80::24ee:49a5:d686:cbc4]) by DB3PR0502MB3980.eurprd05.prod.outlook.com ([fe80::24ee:49a5:d686:cbc4%3]) with mapi id 15.20.1965.017; Fri, 7 Jun 2019 21:59:33 +0000 From: Yongseok Koh To: Stephen Hemminger , Thomas Monjalon CC: Shahaf Shuler , dev , Olga Shern , Alaa Hleihel , Asaf Penso Thread-Topic: Please revert mlx IOVA VA mode patch Thread-Index: AQHVHV+B7XrFFAjntku/t7j6WuiHnqaQvdMA Date: Fri, 7 Jun 2019 21:59:33 +0000 Message-ID: References: <20190607113324.25248eba@hermes.lan> In-Reply-To: <20190607113324.25248eba@hermes.lan> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=yskoh@mellanox.com; x-originating-ip: [209.116.155.178] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 61801ddf-88b4-461e-3dec-08d6eb936cb4 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020); SRVR:DB3PR0502MB3962; x-ms-traffictypediagnostic: DB3PR0502MB3962: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-forefront-prvs: 0061C35778 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(366004)(39860400002)(396003)(136003)(346002)(376002)(199004)(189003)(53936002)(7736002)(305945005)(76116006)(91956017)(186003)(26005)(73956011)(476003)(66446008)(64756008)(66556008)(66476007)(66946007)(486006)(82746002)(6246003)(102836004)(107886003)(6506007)(53546011)(6116002)(3846002)(99286004)(4326008)(8936002)(8676002)(81156014)(81166006)(76176011)(2616005)(11346002)(446003)(6436002)(36756003)(478600001)(14454004)(316002)(33656002)(229853002)(54906003)(110136005)(66066001)(5660300002)(6486002)(86362001)(25786009)(6512007)(14444005)(256004)(2906002)(71200400001)(71190400001)(83716004)(68736007); DIR:OUT; SFP:1101; SCL:1; SRVR:DB3PR0502MB3962; H:DB3PR0502MB3980.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: HgDie5kWZ53Ufle+22BU0/0teVMLdoFmVpzcnnr2h7rv2BIfPdaoDCkq7HoWel3KlRemjwb7Eb/fqO2t4vjjxbPceR4oQf3dKNIHXp6mr7RXaKXoIvwTAE1d625EZeAGTGrR3ZiiQ9BbQ/Wi7sB+UW0Hde6uremxlIvlFId3ZlieTPGyPdTked+cpiUY4KVxQimYNm6s1YIYE9UGl92Wd2kmXxJoPY3UGy2noIkNsY/QYSmhR/F1FSzI/VJl6xGR+OsBBs1UGaFub5jccVcz/vFf9Z5BfqFhizVKE8gIxmzwBuhVs70E20xyfcpNedyetspoMbL1t24OKOB2d6hsLMJoVmfVYn3YihmvcXujUlbKadnHHNfwrKDl6fd+e6cNRw5t61kk4pzPVNqNWnH9EZgmiDPm5+n6/8stgEP2jWA= Content-Type: text/plain; charset="us-ascii" Content-ID: <1EE3990A46DD1B4D89916723480890F4@eurprd05.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 61801ddf-88b4-461e-3dec-08d6eb936cb4 X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Jun 2019 21:59:33.0958 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: yskoh@mellanox.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR0502MB3962 Subject: Re: [dpdk-dev] Please revert mlx IOVA VA mode patch X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" We'll have to look into the issue. It doesn't seem simple though. Thomas, can you please revert the patch from the master? Thanks, Yongseok > On Jun 7, 2019, at 11:33 AM, Stephen Hemminger wrote: >=20 > The Netvsc PMD got broken on DPDK 19.08 by a bad patch in Mellanox driver= . > On a simple setup with SRIOV enabled and using netvsc PMD with the testpm= d. > It worked in 19.05 and does not work with current master. >=20 > The probe code gets stuck because netvsc PMD sends a request to host > and never sees a response. >=20 > # ./build/app/testpmd --log-level=3D'pmd.net.netvsc.*:debug' -l 0-3 -n 4 = -- --rxq=3D4 --txq=3D4 -i > EAL: Detected 4 lcore(s) > EAL: Detected 1 NUMA nodes > EAL: Multi-process socket /var/run/dpdk/rte/mp_socket > EAL: Probing VFIO support... > EAL: WARNING: cpu flags constant_tsc=3Dyes nonstop_tsc=3Dno -> using unre= liable clock cycles ! > EAL: PCI device 935f:00:02.0 on NUMA socket 0 > EAL: probe driver: 15b3:1014 net_mlx5 > net_mlx5: can not get IB device "mlx5_0" ports number > eth_hn_probe(): >> > eth_hn_dev_init(): >> > hn_nvs_init(): NVS version 0x60001, NDIS version 6.30 > hn_nvs_conn_rxbuf(): connect rxbuff va=3D0x2200402000 gpad=3D0xe1e2d > hn_nvs_conn_rxbuf(): receive buffer size 1728 count 18811 > hn_nvs_conn_chim(): connect send buf va=3D0x2202302000 gpad=3D0xe1e2e > hn_nvs_conn_chim(): send buffer 16777216 section size:6144, count:2730 > (hung) >=20 > The problem does not occur without SRIOV (or if MLX driver is not > compiled in). >=20 > Doing bisect the problem is caused by: >=20 > commit 69c06d0e357ed0064b498d510d169603cf7308cd > Author: Yongseok Koh > Date: Thu May 2 02:07:54 2019 -0700 >=20 > net/mlx: support IOVA VA mode >=20 > Set RTE_PCI_DRV_IOVA_AS_VA to driver's drv_flags as device's IOMMU tak= es > virtual address. >=20 > Cc: stable@dpdk.org >=20 > Signed-off-by: Yongseok Koh > Acked-by: Shahaf Shuler >=20 > Please either revert or fix this patch ASAP. >=20