DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Mussar, Gary" <gmussar@ciena.com>
To: "dev@dpdk.org" <dev@dpdk.org>
Subject: [dpdk-dev] [PKTGEN] rte_kni.ko with lo_mode=lo_mode_ring
Date: Fri, 2 Sep 2016 09:39:44 -0400	[thread overview]
Message-ID: <C281A17C31CFD745B242416D0E96EC63ABA5E06C@ONWVEXCHMB04.ciena.com> (raw)

The pktgen docs state that the rte_kni.ko should be loaded with lo_mode=lo_mode_ring however the source in dpdk master does not appear to understand this value. This wasn't an issue in the past since the kni code would simply disable lo_mode if you passed in an unknown value.

The Ubuntu 4.4.0-36-generic kernel no longer loads the module if the passed value is not in the table of known values (the 4.4.0-34-generic kernel would still load the module).

I have 2 questions:
1)
Why does pktgen specify using a value for lo_mode that the source does not support? Is lo_mode_ring something that is coming but not yet submitted?

2)
Is the Ubuntu kernel being over aggressive in parameter checking or is this a "good" thing? If it is good, then should the pktgen docs be indicating that an unsupported value be used for lo_mode?

Gary

             reply	other threads:[~2016-09-02 13:39 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-02 13:39 Mussar, Gary [this message]
2016-09-02 14:16 ` [dpdk-dev] " Wiles, Keith
2016-09-02 14:55   ` Ferruh Yigit
2016-09-02 15:54     ` Mussar, Gary

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=C281A17C31CFD745B242416D0E96EC63ABA5E06C@ONWVEXCHMB04.ciena.com \
    --to=gmussar@ciena.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).