From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <huawei.xie@intel.com>
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
by dpdk.org (Postfix) with ESMTP id 989CA5902
for <dev@dpdk.org>; Tue, 30 Sep 2014 16:31:55 +0200 (CEST)
Received: from azsmga001.ch.intel.com ([10.2.17.19])
by orsmga103.jf.intel.com with ESMTP; 30 Sep 2014 07:36:20 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.04,626,1406617200"; d="scan'208";a="481010463"
Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205])
by azsmga001.ch.intel.com with ESMTP; 30 Sep 2014 07:38:34 -0700
Received: from FMSMSX109.amr.corp.intel.com (10.18.116.9) by
fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS)
id 14.3.195.1; Tue, 30 Sep 2014 07:38:34 -0700
Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by
fmsmsx109.amr.corp.intel.com (10.18.116.9) with Microsoft SMTP Server (TLS)
id 14.3.195.1; Tue, 30 Sep 2014 07:38:34 -0700
Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.203]) by
shsmsx102.ccr.corp.intel.com ([169.254.2.192]) with mapi id 14.03.0195.001;
Tue, 30 Sep 2014 22:38:33 +0800
From: "Xie, Huawei" <huawei.xie@intel.com>
To: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>, "dev@dpdk.org"
<dev@dpdk.org>
Thread-Topic: [memnic PATCH v2 6/7] pmd: add branch hint in recv/xmit
Thread-Index: Ac/cn7cr+0i1sUkPRO2iopF1mOwIlQAHCO/Q
Date: Tue, 30 Sep 2014 14:38:32 +0000
Message-ID: <C37D651A908B024F974696C65296B57B0F2B03A9@SHSMSX101.ccr.corp.intel.com>
References: <7F861DC0615E0C47A872E6F3C5FCDDBD02AE26C5@BPXM14GP.gisp.nec.co.jp>
In-Reply-To: <7F861DC0615E0C47A872E6F3C5FCDDBD02AE26C5@BPXM14GP.gisp.nec.co.jp>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [10.239.127.40]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Cc: Hayato Momma <h-momma@ce.jp.nec.com>
Subject: Re: [dpdk-dev] [memnic PATCH v2 6/7] pmd: add branch hint in
recv/xmit
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 30 Sep 2014 14:31:56 -0000
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Hiroshi Shimamoto
> Sent: Tuesday, September 30, 2014 7:15 PM
> To: dev@dpdk.org
> Cc: Hayato Momma
> Subject: [dpdk-dev] [memnic PATCH v2 6/7] pmd: add branch hint in recv/xm=
it
>=20
> From: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
>=20
> To reduce instruction cache miss, add branch condition hints into
> recv/xmit functions. This improves a bit performance.
>=20
> We can see performance improvements with memnic-tester.
> Using Xeon E5-2697 v2 @ 2.70GHz, 4 vCPU.
> size | before | after
> 64 | 5.54Mpps | 5.55Mpps
> 128 | 5.46Mpps | 5.44Mpps
> 256 | 5.21Mpps | 5.22Mpps
> 512 | 4.50Mpps | 4.52Mpps
> 1024 | 3.71Mpps | 3.73Mpps
> 1280 | 3.21Mpps | 3.22Mpps
> 1518 | 2.92Mpps | 2.93Mpps
>=20
> Signed-off-by: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
> Reviewed-by: Hayato Momma <h-momma@ce.jp.nec.com>
> ---
> pmd/pmd_memnic.c | 18 +++++++++---------
> 1 file changed, 9 insertions(+), 9 deletions(-)
>=20
> diff --git a/pmd/pmd_memnic.c b/pmd/pmd_memnic.c
> index 7fc3093..875d3ea 100644
> --- a/pmd/pmd_memnic.c
> +++ b/pmd/pmd_memnic.c
> @@ -289,26 +289,26 @@ static uint16_t memnic_recv_pkts(void *rx_queue,
> int idx, next;
> struct rte_eth_stats *st =3D &adapter->stats[rte_lcore_id()];
>=20
> - if (!adapter->nic->hdr.valid)
> + if (unlikely(!adapter->nic->hdr.valid))
> return 0;
>=20
> pkts =3D bytes =3D errs =3D 0;
> idx =3D adapter->up_idx;
> for (nr =3D 0; nr < nb_pkts; nr++) {
> p =3D &data->packets[idx];
> - if (p->status !=3D MEMNIC_PKT_ST_FILLED)
> + if (unlikely(p->status !=3D MEMNIC_PKT_ST_FILLED))
> break;
> /* prefetch the next area */
> next =3D idx;
> - if (++next >=3D MEMNIC_NR_PACKET)
> + if (unlikely(++next >=3D MEMNIC_NR_PACKET))
On IA, compiler can use add, cmp and cmov to avoid branch.
But If MEMNIC_NR_PACKET is always power of 2,=20
it is better just next =3D (next + 1) & (MEMNIC_NR_PACKET - 1)
> next =3D 0;
> rte_prefetch0(&data->packets[next]);
> - if (p->len > framesz) {
> + if (unlikely(p->len > framesz)) {
> errs++;
> goto drop;
> }
> mb =3D rte_pktmbuf_alloc(adapter->mp);
> - if (!mb)
> + if (unlikely(!mb))
> break;
>=20
> rte_memcpy(rte_pktmbuf_mtod(mb, void *), p->data, p->len);
> @@ -350,7 +350,7 @@ static uint16_t memnic_xmit_pkts(void *tx_queue,
> uint64_t pkts, bytes, errs;
> uint32_t framesz =3D adapter->framesz;
>=20
> - if (!adapter->nic->hdr.valid)
> + if (unlikely(!adapter->nic->hdr.valid))
> return 0;
>=20
> pkts =3D bytes =3D errs =3D 0;
> @@ -360,7 +360,7 @@ static uint16_t memnic_xmit_pkts(void *tx_queue,
> struct rte_mbuf *sg;
> void *ptr;
>=20
> - if (pkt_len > framesz) {
> + if (unlikely(pkt_len > framesz)) {
> errs++;
> break;
> }
> @@ -379,7 +379,7 @@ retry:
> goto retry;
> }
>=20
> - if (idx !=3D ACCESS_ONCE(adapter->down_idx)) {
> + if (unlikely(idx !=3D ACCESS_ONCE(adapter->down_idx))) {
> /*
> * host freed this and got false positive,
> * need to recover the status and retry.
> @@ -388,7 +388,7 @@ retry:
> goto retry;
> }
>=20
> - if (++idx >=3D MEMNIC_NR_PACKET)
> + if (unlikely(++idx >=3D MEMNIC_NR_PACKET))
> idx =3D 0;
> adapter->down_idx =3D idx;
>=20
> --
> 1.8.3.1