From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 8BFF611F5 for ; Thu, 2 Jul 2015 11:38:09 +0200 (CEST) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga102.jf.intel.com with ESMTP; 02 Jul 2015 02:38:08 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.15,391,1432623600"; d="scan'208";a="721627615" Received: from pgsmsx107.gar.corp.intel.com ([10.221.44.105]) by orsmga001.jf.intel.com with ESMTP; 02 Jul 2015 02:38:08 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by PGSMSX107.gar.corp.intel.com (10.221.44.105) with Microsoft SMTP Server (TLS) id 14.3.224.2; Thu, 2 Jul 2015 17:38:06 +0800 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.246]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.168]) with mapi id 14.03.0224.002; Thu, 2 Jul 2015 17:38:05 +0800 From: "Xie, Huawei" To: "Ouyang, Changchun" , "dev@dpdk.org" Thread-Topic: [PATCH 3/3] vhost: call api to unregister vhost driver Thread-Index: AdC0qst/dqiDBgyIQUiz52lyO0XQNQ== Date: Thu, 2 Jul 2015 09:38:04 +0000 Message-ID: References: <1435807983-20383-1-git-send-email-changchun.ouyang@intel.com> <1435807983-20383-4-git-send-email-changchun.ouyang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 3/3] vhost: call api to unregister vhost driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Jul 2015 09:38:10 -0000 On 7/2/2015 11:33 AM, Ouyang, Changchun wrote:=0A= > =0A= > /* Start CUSE session. */=0A= > rte_vhost_driver_session_start();=0A= > +=0A= > + /* Unregister vhost driver. */=0A= > + ret =3D rte_vhost_driver_unregister((char *)&dev_basename);=0A= > + if (ret !=3D 0)=0A= > + rte_exit(EXIT_FAILURE,"vhost driver unregister failure.\n");=0A= > +=0A= Better remove the above code.=0A= It is duplicated with signal handler and actually=0A= rte_vhost_driver_session_start never returns.=0A= =0A= > return 0;=0A= > =0A= > }=0A= =0A=