From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 06229234 for ; Mon, 19 Oct 2015 18:56:11 +0200 (CEST) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga102.jf.intel.com with ESMTP; 19 Oct 2015 09:56:10 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.17,702,1437462000"; d="scan'208";a="667387112" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by orsmga003.jf.intel.com with ESMTP; 19 Oct 2015 09:56:11 -0700 Received: from fmsmsx157.amr.corp.intel.com (10.18.116.73) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.248.2; Mon, 19 Oct 2015 09:56:10 -0700 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by FMSMSX157.amr.corp.intel.com (10.18.116.73) with Microsoft SMTP Server (TLS) id 14.3.248.2; Mon, 19 Oct 2015 09:56:10 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.96]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.194]) with mapi id 14.03.0248.002; Tue, 20 Oct 2015 00:56:02 +0800 From: "Xie, Huawei" To: Stephen Hemminger Thread-Topic: [PATCH 4/5] virtio: use any layout on transmit Thread-Index: AdEKizC3PWOT1QzQTPaVD07Lg4SGOw== Date: Mon, 19 Oct 2015 16:56:02 +0000 Message-ID: References: <1445231772-17467-1-git-send-email-stephen@networkplumber.org> <1445231772-17467-5-git-send-email-stephen@networkplumber.org> <20151019094316.1fffd775@xeon-e3> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH 4/5] virtio: use any layout on transmit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Oct 2015 16:56:12 -0000 On 10/20/2015 12:43 AM, Stephen Hemminger wrote:=0A= > On Mon, 19 Oct 2015 16:28:30 +0000=0A= > "Xie, Huawei" wrote:=0A= >=0A= >> On 10/19/2015 1:16 PM, Stephen Hemminger wrote:=0A= >>> Virtio supports a feature that allows sender to put transmit=0A= >>> header prepended to data. It requires that the mbuf be writeable, corr= ect=0A= >>> alignment, and the feature has been negotiatied. If all this works out= ,=0A= >>> then it will be the optimum way to transmit a single segment packet. = =0A= >> "When using legacy interfaces, transitional drivers which have not=0A= >> negotiated VIRTIO_F_ANY_LAYOUT=0A= >> MUST use a single descriptor for the struct virtio_net_hdr on both=0A= >> transmit and receive, with the=0A= >> network data in the following descriptors."=0A= > The code checks for the any layout feature, what is the problem?=0A= My reply is removed. I said virtio RX is already implemented using this=0A= feature by default without negotiation(at the time of implementation, no=0A= idea of this feature), is the RX implementation wrong?=0A= =0A=