From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 7D61B8D9D for ; Tue, 20 Oct 2015 03:49:23 +0200 (CEST) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga101.jf.intel.com with ESMTP; 19 Oct 2015 18:49:20 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.17,705,1437462000"; d="scan'208";a="667678166" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga003.jf.intel.com with ESMTP; 19 Oct 2015 18:49:12 -0700 Received: from fmsmsx120.amr.corp.intel.com (10.18.124.208) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.248.2; Mon, 19 Oct 2015 18:48:53 -0700 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by fmsmsx120.amr.corp.intel.com (10.18.124.208) with Microsoft SMTP Server (TLS) id 14.3.248.2; Mon, 19 Oct 2015 18:48:51 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.96]) by shsmsx102.ccr.corp.intel.com ([169.254.2.253]) with mapi id 14.03.0248.002; Tue, 20 Oct 2015 09:48:42 +0800 From: "Xie, Huawei" To: Stephen Hemminger Thread-Topic: [PATCH 5/5] virtio: optimize transmit enqueue Thread-Index: AdEK2XIHLmzGLFPUS8mQOhDcYScdHw== Date: Tue, 20 Oct 2015 01:48:41 +0000 Message-ID: References: <1445231772-17467-1-git-send-email-stephen@networkplumber.org> <1445231772-17467-6-git-send-email-stephen@networkplumber.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH 5/5] virtio: optimize transmit enqueue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Oct 2015 01:49:23 -0000 On 10/19/2015 1:16 PM, Stephen Hemminger wrote:=0A= > All the error checks in virtqueue_enqueue_xmit are already done=0A= > by the caller. Therefore they can be removed to improve performance.=0A= >=0A= > Signed-off-by: Stephen Hemminger =0A= Exactly the same thought as i commented in previous patch. We should=0A= remove unnecessary checks as caller ensures they will pass.=0A= We need check whether we need recheck "need" again after=0A= virtio_xmit_cleanup for the previous indirect patch.=0A= =0A= Acked-by: Huawei Xie =0A= > ---=0A= > drivers/net/virtio/virtio_rxtx.c | 23 ++---------------------=0A= > 1 file changed, 2 insertions(+), 21 deletions(-)=0A= >=0A= >=0A= =0A=