From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 47BA6FE5 for ; Tue, 20 Oct 2015 11:52:53 +0200 (CEST) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga103.jf.intel.com with ESMTP; 20 Oct 2015 02:52:53 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.17,706,1437462000"; d="scan'208";a="584439442" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by FMSMGA003.fm.intel.com with ESMTP; 20 Oct 2015 02:52:52 -0700 Received: from fmsmsx154.amr.corp.intel.com (10.18.116.70) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.248.2; Tue, 20 Oct 2015 02:52:51 -0700 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by FMSMSX154.amr.corp.intel.com (10.18.116.70) with Microsoft SMTP Server (TLS) id 14.3.248.2; Tue, 20 Oct 2015 02:52:51 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.96]) by shsmsx102.ccr.corp.intel.com ([169.254.2.253]) with mapi id 14.03.0248.002; Tue, 20 Oct 2015 17:52:50 +0800 From: "Xie, Huawei" To: Pavel Boldin , "dev@dpdk.org" , "Long, Thomas" Thread-Topic: [PATCH v5 3/4] vhost: using EVENTFD_COPY2 Thread-Index: AdELHRRH4BJ5xeaFSaePY3NFxFWejA== Date: Tue, 20 Oct 2015 09:52:49 +0000 Message-ID: References: <1429184910-30186-2-git-send-email-pboldin@mirantis.com> <1440787880-7079-3-git-send-email-pboldin@mirantis.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v5 3/4] vhost: using EVENTFD_COPY2 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Oct 2015 09:52:53 -0000 Thanks Pavel for this work.=0A= This is what we think is the better implementation for eventfd proxy, in=0A= our last review.=0A= Could you add an additional patch to remove the old implementation?=0A= =0A= Again, please run checkpatch.pl against your patch.=0A= On 8/29/2015 2:51 AM, Pavel Boldin wrote:=0A= =0A= [...]=0A= > +=0A= > +int=0A= > +eventfd_init(void)=0A= > +{=0A= > + if (eventfd_link > 0)=0A= 0 could be valid fd. Change it to:=0A= if (eventfd_link >=3D 0)=0A= Change elsewhere if i miss it.=0A= > +int=0A= > +eventfd_free(void)=0A= > +{=0A= > + if (eventfd_link > 0)=0A= same as above:=0A= if (eventfd_link >=3D 0)=0A= =0A= [...]=0A=