From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id CEE8995CD for ; Thu, 22 Oct 2015 14:13:21 +0200 (CEST) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga101.jf.intel.com with ESMTP; 22 Oct 2015 05:13:20 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,182,1444719600"; d="scan'208";a="669492458" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga003.jf.intel.com with ESMTP; 22 Oct 2015 05:13:20 -0700 Received: from fmsmsx117.amr.corp.intel.com (10.18.116.17) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 22 Oct 2015 05:13:20 -0700 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by fmsmsx117.amr.corp.intel.com (10.18.116.17) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 22 Oct 2015 05:13:19 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.96]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.194]) with mapi id 14.03.0248.002; Thu, 22 Oct 2015 20:13:18 +0800 From: "Xie, Huawei" To: "dev@dpdk.org" , Stephen Hemminger Thread-Topic: [dpdk-dev] [PATCH v2 0/5] virtio: Tx performance improvements Thread-Index: AdEMtczKGoGnSN25SBqgZMNDMzsH2Q== Date: Thu, 22 Oct 2015 12:13:17 +0000 Message-ID: References: <1445231772-17467-1-git-send-email-stephen@networkplumber.org> <1536056.KWEakoJpBK@xps13> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 0/5] virtio: Tx performance improvements X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Oct 2015 12:13:22 -0000 On 10/22/2015 6:39 PM, Xie, Huawei wrote:=0A= > On 10/21/2015 9:20 PM, Thomas Monjalon wrote:=0A= >> 2015-10-18 22:16, Stephen Hemminger:=0A= >>> This is a tested version of the virtio Tx performance improvements=0A= >>> that I posted earlier on the list, and described at the DPDK Userspace= =0A= >>> meeting in Dublin. Together they get a 25% performance improvement for= =0A= >>> both small packet and large multi-segment packet case when testing=0A= >>> from DPDK guest application to Linux KVM host.=0A= >>>=0A= >>> Stephen Hemminger (5):=0A= >>> virtio: clean up space checks on xmit=0A= >>> virtio: don't use unlikely for normal tx stuff=0A= >>> virtio: use indirect ring elements=0A= >>> virtio: use any layout on transmit=0A= >>> virtio: optimize transmit enqueue=0A= >> Huawei, do you ack this series?=0A= >>=0A= > Okay with this patchset with two remained questions,=0A= Forget to cc Stephen.=0A= >=0A= > +/* Region reserved to allow for transmit header and indirect ring */=0A= > +#define VIRTIO_MAX_TX_INDIRECT 8=0A= > +struct virtio_tx_region {=0A= > + struct virtio_net_hdr_mrg_rxbuf tx_hdr;=0A= >=0A= > Why use merge-able rx header here in the tx region?=0A= >=0A= >> + struct vring_desc tx_indir[VIRTIO_MAX_TX_INDIRECT]=0A= >> + __attribute__((__aligned__(16)));=0A= > WARNING: __aligned(size) is preferred over __attribute__((aligned(size)))= =0A= > [...]=0A= >=0A= >=0A= >=0A= >=0A= =0A=