From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id D5D71567E for ; Wed, 9 Dec 2015 03:46:31 +0100 (CET) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga102.fm.intel.com with ESMTP; 08 Dec 2015 18:46:30 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,401,1444719600"; d="scan'208";a="614887465" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by FMSMGA003.fm.intel.com with ESMTP; 08 Dec 2015 18:46:29 -0800 Received: from fmsmsx152.amr.corp.intel.com (10.18.125.5) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.248.2; Tue, 8 Dec 2015 18:45:57 -0800 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by FMSMSX152.amr.corp.intel.com (10.18.125.5) with Microsoft SMTP Server (TLS) id 14.3.248.2; Tue, 8 Dec 2015 18:45:56 -0800 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.138]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.83]) with mapi id 14.03.0248.002; Wed, 9 Dec 2015 10:45:28 +0800 From: "Xie, Huawei" To: Victor Kaplansky , Yuanhan Liu Thread-Topic: [PATCH 3/4] vhost: log vring changes Thread-Index: AdEyK6kvuqDqFQ/1RaKlQvoZ1DHeiA== Date: Wed, 9 Dec 2015 02:45:28 +0000 Message-ID: References: <1449027793-30975-1-git-send-email-yuanhan.liu@linux.intel.com> <1449027793-30975-4-git-send-email-yuanhan.liu@linux.intel.com> <20151202155405-mutt-send-email-victork@redhat.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" , "Michael S. Tsirkin" Subject: Re: [dpdk-dev] [PATCH 3/4] vhost: log vring changes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Dec 2015 02:46:32 -0000 On 12/2/2015 10:09 PM, Victor Kaplansky wrote:=0A= > On Wed, Dec 02, 2015 at 11:43:12AM +0800, Yuanhan Liu wrote:=0A= >> Invoking vhost_log_write() to mark corresponding page as dirty while=0A= >> updating used vring.=0A= > Looks good, thanks!=0A= >=0A= > I didn't find where you log the dirty pages in result of data=0A= > written to the buffers pointed by the descriptors in RX vring.=0A= > AFAIU, the buffers of RX queue reside in guest's memory and have=0A= > to be marked as dirty if they are written. What do you say?=0A= Yes, that is actually the majority of the work.=0A= Besides, in the first version, we could temporarily ignore zero copy,=0A= which is much more complicated, as we have no idea when the page has=0A= been accessed.=0A= -- Huawei=0A= >=0A= > -- Victor=0A= >=0A= >=0A= =0A=