From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id B4FA15A8C for ; Fri, 18 Dec 2015 10:52:39 +0100 (CET) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga103.jf.intel.com with ESMTP; 18 Dec 2015 01:52:38 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,445,1444719600"; d="scan'208";a="876332520" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by fmsmga002.fm.intel.com with ESMTP; 18 Dec 2015 01:52:39 -0800 Received: from fmsmsx124.amr.corp.intel.com (10.18.125.39) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.248.2; Fri, 18 Dec 2015 01:52:38 -0800 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by fmsmsx124.amr.corp.intel.com (10.18.125.39) with Microsoft SMTP Server (TLS) id 14.3.248.2; Fri, 18 Dec 2015 01:52:38 -0800 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.190]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.28]) with mapi id 14.03.0248.002; Fri, 18 Dec 2015 17:52:29 +0800 From: "Xie, Huawei" To: Stephen Hemminger , Santosh Shukla Thread-Topic: [dpdk-dev] [ [PATCH v2] 01/13] virtio: Introduce config RTE_VIRTIO_INC_VECTOR Thread-Index: AdE5ec6M+YFELzzHQsOerT/oJOBVJg== Date: Fri, 18 Dec 2015 09:52:29 +0000 Message-ID: References: <1450098032-21198-1-git-send-email-sshukla@mvista.com> <1450098032-21198-2-git-send-email-sshukla@mvista.com> <20151217152435.3c733ac1@xeon-e3> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [ [PATCH v2] 01/13] virtio: Introduce config RTE_VIRTIO_INC_VECTOR X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Dec 2015 09:52:40 -0000 On 12/18/2015 7:25 AM, Stephen Hemminger wrote:=0A= > On Thu, 17 Dec 2015 17:32:38 +0530=0A= > Santosh Shukla wrote:=0A= >=0A= >> On Mon, Dec 14, 2015 at 6:30 PM, Santosh Shukla wro= te:=0A= >>> virtio_recv_pkts_vec and other virtio vector friend apis are written fo= r sse/avx=0A= >>> instructions. For arm64 in particular, virtio vector implementation doe= s not=0A= >>> exist(todo).=0A= >>>=0A= >>> So virtio pmd driver wont build for targets like i686, arm64. By makin= g=0A= >>> RTE_VIRTIO_INC_VECTOR=3Dn, Driver can build for non-sse/avx targets and= will work=0A= >>> in non-vectored virtio mode.=0A= >>>=0A= >>> Signed-off-by: Santosh Shukla =0A= >>> ---=0A= >> Ping?=0A= >>=0A= >> any review / comment on this patch much appreciated. Thanks=0A= > The patches I posted (and were ignored by Intel) to support indirect=0A= > and any layout should have much bigger performance gain than all this=0A= > low level SSE bit twiddling.=0A= Hi Stephen:=0A= We only did SSE twiddling to RX, which almost doubles the performance=0A= comparing to normal path in virtio/vhost performance test case. Indirect=0A= and any layout feature enabling are mostly for TX. We also did some=0A= optimization for single segment and non-offload case in TX, without=0A= using SSE, which also gives ~60% performance improvement, in Qian's=0A= result. My optimization is mostly for single segment and non-offload=0A= case, which i calls simple rx/tx.=0A= I plan to add virtio/vhost performance benchmark so that we could easily=0A= measure the performance difference for each patch.=0A= =0A= Indirect and any layout features are useful for multiple segment=0A= transmitted packet mbufs. I had acked your patch at the first time, and=0A= thought it is applied. I don't understand why you say it is ignored by=0A= Intel.=0A= =0A= >=0A= >=0A= =0A=