From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id DB6038DAF for ; Tue, 22 Dec 2015 07:56:20 +0100 (CET) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga103.jf.intel.com with ESMTP; 21 Dec 2015 22:56:21 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,463,1444719600"; d="scan'208";a="17401913" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga004.fm.intel.com with ESMTP; 21 Dec 2015 22:56:19 -0800 Received: from fmsmsx152.amr.corp.intel.com (10.18.125.5) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.248.2; Mon, 21 Dec 2015 22:56:19 -0800 Received: from shsmsx103.ccr.corp.intel.com (10.239.110.14) by FMSMSX152.amr.corp.intel.com (10.18.125.5) with Microsoft SMTP Server (TLS) id 14.3.248.2; Mon, 21 Dec 2015 22:56:19 -0800 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.190]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.28]) with mapi id 14.03.0248.002; Tue, 22 Dec 2015 14:56:17 +0800 From: "Xie, Huawei" To: Yuanhan Liu , "dev@dpdk.org" Thread-Topic: [PATCH 3/3] vhost: fix vq realloc at numa_realloc Thread-Index: AdE8hdpyOWaSzuEIQpSIqG5t55Udgg== Date: Tue, 22 Dec 2015 06:56:16 +0000 Message-ID: References: <1450422247-6814-1-git-send-email-yuanhan.liu@linux.intel.com> <1450422247-6814-3-git-send-email-yuanhan.liu@linux.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 3/3] vhost: fix vq realloc at numa_realloc X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Dec 2015 06:56:21 -0000 On 12/18/2015 3:03 PM, Yuanhan Liu wrote:=0A= > vq is allocated on pairs, hence we should do pair reallocation=0A= > at numa_realloc() as well, otherwise an error like following=0A= > occurs while do numa reallocation:=0A= >=0A= > VHOST_CONFIG: reallocate vq from 0 to 1 node=0A= > PANIC in rte_free():=0A= > Fatal error: Invalid memory=0A= >=0A= > The reason we don't catch it is because numa_realloc() will=0A= looks to me, but=0A= s /because/that/=0A= s /on pairs/in pairs/ ? :).=0A= > not take effect when RTE_LIBRTE_VHOST_NUMA is not enabled,=0A= > which is the default case.=0A= >=0A= > Fixes: e049ca6d10e0 ("vhost-user: prepare multiple queue setup")=0A= >=0A= > Signed-off-by: Yuanhan Liu =0A= =0A= Acked-by: Huawei Xie =0A= =0A= =0A=