From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 000428D8F for ; Tue, 22 Dec 2015 08:07:30 +0100 (CET) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga103.fm.intel.com with ESMTP; 21 Dec 2015 23:07:30 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,463,1444719600"; d="scan'208";a="867060922" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by fmsmga001.fm.intel.com with ESMTP; 21 Dec 2015 23:07:29 -0800 Received: from fmsmsx112.amr.corp.intel.com (10.18.116.6) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.248.2; Mon, 21 Dec 2015 23:07:29 -0800 Received: from shsmsx103.ccr.corp.intel.com (10.239.110.14) by FMSMSX112.amr.corp.intel.com (10.18.116.6) with Microsoft SMTP Server (TLS) id 14.3.248.2; Mon, 21 Dec 2015 23:07:28 -0800 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.190]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.28]) with mapi id 14.03.0248.002; Tue, 22 Dec 2015 15:07:26 +0800 From: "Xie, Huawei" To: Peter Xu , Yuanhan Liu Thread-Topic: [PATCH v2 3/6] vhost: log used vring changes Thread-Index: AQHRPIdp34WVfSzMjU6GIcS8nWniTg== Date: Tue, 22 Dec 2015 07:07:25 +0000 Message-ID: References: <1449027793-30975-1-git-send-email-yuanhan.liu@linux.intel.com> <1450321921-27799-1-git-send-email-yuanhan.liu@linux.intel.com> <1450321921-27799-4-git-send-email-yuanhan.liu@linux.intel.com> <20151222065552.GC7532@pxdev.xzpeter.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" , Victor Kaplansky , "Michael S. Tsirkin" Subject: Re: [dpdk-dev] [PATCH v2 3/6] vhost: log used vring changes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Dec 2015 07:07:31 -0000 On 12/22/2015 2:56 PM, Peter Xu wrote:=0A= > On Thu, Dec 17, 2015 at 11:11:58AM +0800, Yuanhan Liu wrote:=0A= >> +static inline void __attribute__((always_inline))=0A= >> +vhost_log_used_vring(struct virtio_net *dev, struct vhost_virtqueue *vq= ,=0A= >> + uint64_t offset, uint64_t len)=0A= >> +{=0A= [...]=0A= > Got a question here:=0A= >=0A= > I see that we are logging down changes when we are marking=0A= > used_vring. Do we need to log down buffer copy in rte_memcpy() too?=0A= > I am not sure whether I understand it correctly, it seems that this=0A= > is part of DPDK API ops to deliver data to the guest (from, e.g.,=0A= > OVS?), when we do rte_memcpy(), we seems to be modifying guest=0A= > memory too. Am I wrong?=0A= >=0A= > Peter=0A= =0A= desc buffer logging isn't included in v1, but in the patch 4 of this=0A= patch set, and actually it is the major work in vhost live migration.=0A= --huawei=0A= =0A= [...]=0A= =0A=