From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id C1C6E91C2 for ; Mon, 4 Jan 2016 18:57:00 +0100 (CET) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga101.jf.intel.com with ESMTP; 04 Jan 2016 09:57:00 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,521,1444719600"; d="scan'208";a="720028492" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga003.jf.intel.com with ESMTP; 04 Jan 2016 09:57:00 -0800 Received: from shsmsx103.ccr.corp.intel.com (10.239.110.14) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.248.2; Mon, 4 Jan 2016 09:56:59 -0800 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.111]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.220]) with mapi id 14.03.0248.002; Tue, 5 Jan 2016 01:56:50 +0800 From: "Xie, Huawei" To: Stephen Hemminger Thread-Topic: [PATCH v2 4/4] virtio: check if any kernel driver is manipulating the virtio device Thread-Index: AdFHGUja0pXGLN4EQ3KpR1IrvCFffg== Date: Mon, 4 Jan 2016 17:56:49 +0000 Message-ID: References: <20151222035041.GA7532@pxdev.xzpeter.org> <1451843773-103006-1-git-send-email-huawei.xie@intel.com> <1451843773-103006-5-git-send-email-huawei.xie@intel.com> <20160104092410.11311412@xeon-e3> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v2 4/4] virtio: check if any kernel driver is manipulating the virtio device X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Jan 2016 17:57:01 -0000 On 1/5/2016 1:24 AM, Stephen Hemminger wrote:=0A= > On Mon, 4 Jan 2016 01:56:13 +0800=0A= > Huawei Xie wrote:=0A= >=0A= >> + if (pci_dev->kdrv !=3D RTE_KDRV_NONE) {=0A= >> + PMD_INIT_LOG(INFO,=0A= >> + "kernel driver is manipulating this device." \=0A= >> + " Please unbind the kernel driver.");=0A= > Splitting strings in general is a bad idea since it makes it harder to fi= nd log messages.=0A= > Also the first clause is lower case and the second is captialized.=0A= Got it. This is to avoid 80 char warning. Will put it in one line to=0A= make it friendly for searching.=0A= The first clause is lower is because it actually follows "%s():".=0A= >=0A= > Lastly, the backslash continuation is unnecessary here and will cause che= ckpatch warning.=0A= >=0A= =0A=