From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 2357F91CB for ; Tue, 5 Jan 2016 03:44:01 +0100 (CET) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga101.jf.intel.com with ESMTP; 04 Jan 2016 18:44:00 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,523,1444719600"; d="scan'208";a="23662309" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by fmsmga004.fm.intel.com with ESMTP; 04 Jan 2016 18:44:00 -0800 Received: from fmsmsx156.amr.corp.intel.com (10.18.116.74) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.248.2; Mon, 4 Jan 2016 18:44:00 -0800 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by fmsmsx156.amr.corp.intel.com (10.18.116.74) with Microsoft SMTP Server (TLS) id 14.3.248.2; Mon, 4 Jan 2016 18:43:59 -0800 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.111]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.183]) with mapi id 14.03.0248.002; Tue, 5 Jan 2016 10:43:57 +0800 From: "Xie, Huawei" To: "Tan, Jianfeng" , "dev@dpdk.org" Thread-Topic: [PATCH] fix checkpatch errors Thread-Index: AdFHYuxjKN0q8yE3SjCuCescXpzehA== Date: Tue, 5 Jan 2016 02:43:57 +0000 Message-ID: References: <1451872319-30737-1-git-send-email-huawei.xie@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] fix checkpatch errors X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Jan 2016 02:44:02 -0000 On 1/5/2016 10:21 AM, Tan, Jianfeng wrote:=0A= >=0A= >> -----Original Message-----=0A= >> From: Xie, Huawei=0A= >> Sent: Monday, January 4, 2016 9:52 AM=0A= >> To: dev@dpdk.org=0A= >> Cc: Mcnamara, John; Tan, Jianfeng; Xie, Huawei=0A= >> Subject: [PATCH] fix checkpatch errors=0A= >>=0A= >> Signed-off-by: Huawei Xie =0A= > ...=0A= >> mbuf_poolname_build(sock_id, pool_name, sizeof(pool_name));=0A= >> - return (rte_mempool_lookup((const char *)pool_name));=0A= >> + return rte_mempool_lookup((const char *)pool_name);=0A= > Hi Huawei,=0A= >=0A= > Assume this patch is to solve below error (reported by checkpatch):=0A= > ERROR: return is not a function, parentheses are not required=0A= >=0A= > So maybe above fix is not necessary? Involve more people to discuss.=0A= Yes, Almost all of the 800 errors are check patch errors. The=0A= parentheses for some logic expressions, like return val =3D=3D 0, return=0A= function, are also removed. At least in this patch, they are not needed.=0A= >=0A= > And please include the error message in the commit message.=0A= >=0A= > Thanks,=0A= > Jianfeng=0A= >=0A= >=0A= =0A=