From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id CB7069382 for ; Tue, 5 Jan 2016 17:20:16 +0100 (CET) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga101.fm.intel.com with ESMTP; 05 Jan 2016 08:20:15 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,525,1444719600"; d="scan'208";a="886793531" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by fmsmga002.fm.intel.com with ESMTP; 05 Jan 2016 08:20:15 -0800 Received: from fmsmsx155.amr.corp.intel.com (10.18.116.71) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.248.2; Tue, 5 Jan 2016 08:20:15 -0800 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by FMSMSX155.amr.corp.intel.com (10.18.116.71) with Microsoft SMTP Server (TLS) id 14.3.248.2; Tue, 5 Jan 2016 08:20:15 -0800 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.111]) by shsmsx102.ccr.corp.intel.com ([169.254.2.133]) with mapi id 14.03.0248.002; Wed, 6 Jan 2016 00:20:13 +0800 From: "Xie, Huawei" To: "Mcnamara, John" , "Tan, Jianfeng" , "dev@dpdk.org" Thread-Topic: [PATCH] fix checkpatch errors Thread-Index: AdFH1PPrKN0q8yE3SjCuCescXpzehA== Date: Tue, 5 Jan 2016 16:20:12 +0000 Message-ID: References: <1451872319-30737-1-git-send-email-huawei.xie@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] fix checkpatch errors X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Jan 2016 16:20:17 -0000 On 1/5/2016 6:22 PM, Mcnamara, John wrote:=0A= >> -----Original Message-----=0A= >> From: Tan, Jianfeng=0A= >> Sent: Tuesday, January 5, 2016 2:21 AM=0A= >> To: Xie, Huawei; dev@dpdk.org=0A= >> Cc: Mcnamara, John; Stephen Hemminger; Yuanhan Liu=0A= >> Subject: RE: [PATCH] fix checkpatch errors=0A= >>=0A= >>=0A= >>=0A= >>> -----Original Message-----=0A= >>> From: Xie, Huawei=0A= >>> Sent: Monday, January 4, 2016 9:52 AM=0A= >>> To: dev@dpdk.org=0A= >>> Cc: Mcnamara, John; Tan, Jianfeng; Xie, Huawei=0A= >>> Subject: [PATCH] fix checkpatch errors=0A= >>>=0A= >>> Signed-off-by: Huawei Xie =0A= >> ...=0A= >>> mbuf_poolname_build(sock_id, pool_name, sizeof(pool_name));=0A= >>> - return (rte_mempool_lookup((const char *)pool_name));=0A= >>> + return rte_mempool_lookup((const char *)pool_name);=0A= >> Hi Huawei,=0A= >>=0A= >> Assume this patch is to solve below error (reported by checkpatch):=0A= >> ERROR: return is not a function, parentheses are not required=0A= >>=0A= >> So maybe above fix is not necessary? Involve more people to discuss.=0A= >>=0A= >> And please include the error message in the commit message.=0A= > Hi Huawei,=0A= >=0A= > The fix looks good and there was a similar patch applied previously for l= ib (from Ferruh):=0A= >=0A= > 6307b909b8e0 ("lib: remove extra parenthesis after return")=0A= Oh yes, but no idea why Ferruh Yigit missed so many. I have greped the=0A= pattern, so this patch should fix almost all of them.=0A= >=0A= > However, the commit message could be better. Maybe something like the abo= ve:=0A= > "remove extra parentheses".=0A= OK. Weird that my commit message gets lost again. Will send a new one.=0A= >=0A= > John=0A= =0A=