From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id B40D637A8 for ; Tue, 19 Jan 2016 09:55:41 +0100 (CET) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga103.fm.intel.com with ESMTP; 19 Jan 2016 00:55:40 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,316,1449561600"; d="scan'208";a="635955363" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by FMSMGA003.fm.intel.com with ESMTP; 19 Jan 2016 00:55:31 -0800 Received: from fmsmsx101.amr.corp.intel.com (10.18.124.199) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.248.2; Tue, 19 Jan 2016 00:55:31 -0800 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by fmsmsx101.amr.corp.intel.com (10.18.124.199) with Microsoft SMTP Server (TLS) id 14.3.248.2; Tue, 19 Jan 2016 00:55:30 -0800 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.215]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.231]) with mapi id 14.03.0248.002; Tue, 19 Jan 2016 16:55:29 +0800 From: "Xie, Huawei" To: Yuanhan Liu , "dev@dpdk.org" Thread-Topic: [PATCH v5 0/9] virtio 1.0 enabling for virtio pmd driver Thread-Index: AdFSlyUnovxMiVMOSqy3XuO3q6wRMw== Date: Tue, 19 Jan 2016 08:55:29 +0000 Message-ID: References: <1452832571-6156-1-git-send-email-yuanhan.liu@linux.intel.com> <1453191125-26335-1-git-send-email-yuanhan.liu@linux.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v5 0/9] virtio 1.0 enabling for virtio pmd driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Jan 2016 08:55:42 -0000 On 1/19/2016 4:10 PM, Yuanhan Liu wrote:=0A= > v5: minor fixes:=0A= >=0A= > - fix wrong type of arg "offset" of read/write_dev_config(): patch 2= =0A= > is newly added for that.=0A= >=0A= > - check "offset + length" overflow=0A= >=0A= > Almost all difference comes from virtio 1.0 are the PCI layout change:=0A= > the major configuration structures are stored at bar space, and their=0A= > location is stored at corresponding pci cap structure. Reading/parsing=0A= > them is one of the major work of patch 8.=0A= >=0A= > To make handling virtio v1.0 and v0.95 co-exist well, this patch set=0A= > introduces a virtio_pci_ops structure, to add another layer so that=0A= > we could keep those vtpci_foo_bar "APIs". With that, we could do the=0A= > minimum change to add virtio 1.0 support.=0A= >=0A= >=0A= > Rough test guide=0A= > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=0A= >=0A= > Firstly, you need get a virtio 1.0 supported QEMU (say, v2.5), then add= =0A= > option "disable-modern=3Dfalse" to qemu virtio-net-pci device to enable= =0A= > virtio 1.0 (which is disabled by default).=0A= >=0A= > And if you see something like following from 'lspci -v', it means virtio= =0A= > 1.0 is indeed enabled:=0A= >=0A= > 00:04.0 Ethernet controller: Red Hat, Inc Virtio network device=0A= > Subsystem: Red Hat, Inc Device 0001=0A= > Physical Slot: 4=0A= > Flags: bus master, fast devsel, latency 0, IRQ 11=0A= > I/O ports at c040 [size=3D64]=0A= > Memory at febf1000 (32-bit, non-prefetchable) [size=3D4K]=0A= > Memory at fe000000 (64-bit, prefetchable) [size=3D8M]=0A= > Expansion ROM at feb80000 [disabled] [size=3D256K]=0A= > Capabilities: [98] MSI-X: Enable+ Count=3D6 Masked-=0A= > =3D=3D> Capabilities: [84] Vendor Specific Information: Len=3D14 =0A= > =3D=3D> Capabilities: [70] Vendor Specific Information: Len=3D14 =0A= > =3D=3D> Capabilities: [60] Vendor Specific Information: Len=3D10 =0A= > =3D=3D> Capabilities: [50] Vendor Specific Information: Len=3D10 =0A= > =3D=3D> Capabilities: [40] Vendor Specific Information: Len=3D10 =0A= > Kernel driver in use: virtio-pci=0A= > Kernel modules: virtio_pci=0A= >=0A= > After that, there wasn't anything speical comparing to the old virtio=0A= > 0.95 pmd driver.=0A= >=0A= >=0A= >=0A= > ---=0A= > Yuanhan Liu (9):=0A= > virtio: don't set vring address again at queue startup=0A= > virtio: define offset as size_t type=0A= > virtio: introduce struct virtio_pci_ops=0A= > virtio: move left pci stuff to virtio_pci.c=0A= > viritio: switch to 64 bit features=0A= > virtio: retrieve hdr_size from hw->vtnet_hdr_size=0A= > eal: pci: export pci_[un]map_device=0A= > virtio: add 1.0 support=0A= > virtio: move VIRTIO_READ/WRITE_REG_X into virtio_pci.c=0A= >=0A= > doc/guides/rel_notes/release_2_3.rst | 3 +=0A= > drivers/net/virtio/virtio_ethdev.c | 302 +--------=0A= > drivers/net/virtio/virtio_ethdev.h | 3 +-=0A= > drivers/net/virtio/virtio_pci.c | 799 ++++++++++++++++++= +++++-=0A= > drivers/net/virtio/virtio_pci.h | 124 +++-=0A= > drivers/net/virtio/virtio_rxtx.c | 21 +-=0A= > drivers/net/virtio/virtio_rxtx_simple.c | 12 +-=0A= > drivers/net/virtio/virtqueue.h | 4 +-=0A= > lib/librte_eal/bsdapp/eal/eal_pci.c | 4 +-=0A= > lib/librte_eal/bsdapp/eal/rte_eal_version.map | 7 +=0A= > lib/librte_eal/common/eal_common_pci.c | 4 +-=0A= > lib/librte_eal/common/eal_private.h | 18 -=0A= > lib/librte_eal/common/include/rte_pci.h | 27 +=0A= > lib/librte_eal/linuxapp/eal/eal_pci.c | 4 +-=0A= > lib/librte_eal/linuxapp/eal/rte_eal_version.map | 7 +=0A= > 15 files changed, 957 insertions(+), 382 deletions(-)=0A= >=0A= Acked-by: Huawei Xie =0A= =0A= Next time, please include all the changes made in the change notice.=0A=