From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <huawei.xie@intel.com> Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id D61099410 for <dev@dpdk.org>; Wed, 27 Jan 2016 07:12:26 +0100 (CET) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga102.fm.intel.com with ESMTP; 26 Jan 2016 22:12:25 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,353,1449561600"; d="scan'208";a="899103866" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by orsmga002.jf.intel.com with ESMTP; 26 Jan 2016 22:12:25 -0800 Received: from fmsmsx152.amr.corp.intel.com (10.18.125.5) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.248.2; Tue, 26 Jan 2016 22:12:25 -0800 Received: from shsmsx104.ccr.corp.intel.com (10.239.110.15) by FMSMSX152.amr.corp.intel.com (10.18.125.5) with Microsoft SMTP Server (TLS) id 14.3.248.2; Tue, 26 Jan 2016 22:12:24 -0800 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.215]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.117]) with mapi id 14.03.0248.002; Wed, 27 Jan 2016 14:12:22 +0800 From: "Xie, Huawei" <huawei.xie@intel.com> To: Yuanhan Liu <yuanhan.liu@linux.intel.com> Thread-Topic: [PATCH 1/5] vhost: refactor rte_vhost_dequeue_burst Thread-Index: AdFYJImDBJn10DZHSWSeUuaChXqDBw== Date: Wed, 27 Jan 2016 06:12:22 +0000 Message-ID: <C37D651A908B024F974696C65296B57B4C5B0548@SHSMSX101.ccr.corp.intel.com> References: <1449122773-25510-1-git-send-email-yuanhan.liu@linux.intel.com> <1449122773-25510-2-git-send-email-yuanhan.liu@linux.intel.com> <C37D651A908B024F974696C65296B57B4C5AEB46@SHSMSX101.ccr.corp.intel.com> <20160127032615.GC4257@yliu-dev.sh.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.4.160] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "Michael S. Tsirkin" <mst@redhat.com>, "dev@dpdk.org" <dev@dpdk.org>, Victor Kaplansky <vkaplans@redhat.com> Subject: Re: [dpdk-dev] [PATCH 1/5] vhost: refactor rte_vhost_dequeue_burst X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Wed, 27 Jan 2016 06:12:27 -0000 On 1/27/2016 11:26 AM, Yuanhan Liu wrote:=0A= > On Tue, Jan 26, 2016 at 10:30:12AM +0000, Xie, Huawei wrote:=0A= >> On 12/3/2015 2:03 PM, Yuanhan Liu wrote:=0A= >>> Signed-off-by: Yuanhan Liu <yuanhan.liu@linux.intel.com>=0A= >>> ---=0A= >>> lib/librte_vhost/vhost_rxtx.c | 287 +++++++++++++++++-----------------= --------=0A= >>> 1 file changed, 113 insertions(+), 174 deletions(-)=0A= >> Prefer to unroll copy_mbuf_to_desc and your COPY macro. It prevents us= =0A= > I'm okay to unroll COPY macro. But for copy_mbuf_to_desc, I prefer not=0A= > to do that, unless it has a good reason.=0A= >=0A= >> processing descriptors in a burst way in future.=0A= > So, do you have a plan?=0A= =0A= I think it is OK. If we need unroll in future, we could do that then. I=0A= am open to this. Just my preference. I understand that wrapping makes=0A= code more readable.=0A= =0A= >=0A= > --yliu=0A= >=0A= =0A=