From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id E9ECA9434 for ; Wed, 27 Jan 2016 11:03:57 +0100 (CET) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga103.fm.intel.com with ESMTP; 27 Jan 2016 02:03:57 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,354,1449561600"; d="scan'208";a="902057389" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by fmsmga002.fm.intel.com with ESMTP; 27 Jan 2016 02:03:57 -0800 Received: from fmsmsx112.amr.corp.intel.com (10.18.116.6) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 27 Jan 2016 02:03:56 -0800 Received: from shsmsx103.ccr.corp.intel.com (10.239.110.14) by FMSMSX112.amr.corp.intel.com (10.18.116.6) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 27 Jan 2016 02:03:56 -0800 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.215]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.218]) with mapi id 14.03.0248.002; Wed, 27 Jan 2016 18:03:55 +0800 From: "Xie, Huawei" To: Tetsuya Mukawa , "dev@dpdk.org" , "yuanhan.liu@linux.intel.com" , "Tan, Jianfeng" Thread-Topic: [RFC PATCH 5/5] virtio: Extend virtio-net PMD to support container environment Thread-Index: AdFY6gezAunQ5LVPT++h9TW0MGQ/9A== Date: Wed, 27 Jan 2016 10:03:55 +0000 Message-ID: References: <1453108389-21006-2-git-send-email-mukawa@igel.co.jp> <1453374478-30996-6-git-send-email-mukawa@igel.co.jp> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.4.80] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [RFC PATCH 5/5] virtio: Extend virtio-net PMD to support container environment X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Jan 2016 10:03:58 -0000 On 1/21/2016 7:09 PM, Tetsuya Mukawa wrote:=0A= > + /* Set BAR region */=0A= > + for (i =3D 0; i < NB_BAR; i++) {=0A= > + switch (dev->bar[i].type) {=0A= > + case QTEST_PCI_BAR_IO:=0A= > + case QTEST_PCI_BAR_MEMORY_UNDER_1MB:=0A= > + case QTEST_PCI_BAR_MEMORY_32:=0A= > + qtest_pci_outl(s, bus, device, 0, dev->bar[i].addr,=0A= > + dev->bar[i].region_start);=0A= > + PMD_DRV_LOG(INFO, "Set BAR of %s device: 0x%lx - 0x%lx\n",=0A= > + dev->name, dev->bar[i].region_start,=0A= > + dev->bar[i].region_start + dev->bar[i].region_size);=0A= > + break;=0A= > + case QTEST_PCI_BAR_MEMORY_64:=0A= > + qtest_pci_outq(s, bus, device, 0, dev->bar[i].addr,=0A= > + dev->bar[i].region_start);=0A= > + PMD_DRV_LOG(INFO, "Set BAR of %s device: 0x%lx - 0x%lx\n",=0A= > + dev->name, dev->bar[i].region_start,=0A= > + dev->bar[i].region_start + dev->bar[i].region_size);=0A= > + break;=0A= =0A= Hasn't the bar resource already been allocated? Is it the app's=0A= responsibility to allocate the bar resource in qtest mode? The app=0A= couldn't have that knowledge.=0A= =0A= > + case QTEST_PCI_BAR_DISABLE:=0A= > + break;=0A= > + }=0A= > + }=0A= > +=0A= =0A=