From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id B6AEB2952 for ; Fri, 26 Feb 2016 07:09:57 +0100 (CET) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga101.jf.intel.com with ESMTP; 25 Feb 2016 22:09:56 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,498,1449561600"; d="scan'208";a="924272168" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga002.fm.intel.com with ESMTP; 25 Feb 2016 22:09:57 -0800 Received: from fmsmsx122.amr.corp.intel.com (10.18.125.37) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 25 Feb 2016 22:09:56 -0800 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by fmsmsx122.amr.corp.intel.com (10.18.125.37) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 25 Feb 2016 22:09:56 -0800 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.136]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.42]) with mapi id 14.03.0248.002; Fri, 26 Feb 2016 14:09:53 +0800 From: "Xie, Huawei" To: Thomas Monjalon Thread-Topic: [PATCH v3 0/4] fix the issue that DPDK takes over virtio device blindly Thread-Index: AdFwXE5LNSeP5izFRJ2yyI3Aew9WpQ== Date: Fri, 26 Feb 2016 06:09:52 +0000 Message-ID: References: <20151222035041.GA7532@pxdev.xzpeter.org> <1453908082-92036-1-git-send-email-huawei.xie@intel.com> <33109608.rF1RQkQoo2@xps13> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" , "Troitsky, Nikita" Subject: Re: [dpdk-dev] [PATCH v3 0/4] fix the issue that DPDK takes over virtio device blindly X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Feb 2016 06:09:58 -0000 On 2/24/2016 8:45 PM, Thomas Monjalon wrote:=0A= >> Huawei Xie (4):=0A= >> eal: make the comment more accurate=0A= >> eal: set kdrv to RTE_KDRV_NONE if kernel driver isn't manipulating the= device.=0A= >> virtio: return 1 to tell the kernel we don't take over this device=0A= >> virtio: check if kernel driver is manipulating the virtio device=0A= > The virtio PCI code has been refactored.=0A= > Please Huawei, would it be possible to rebase on master?=0A= =0A= OK. Since IO port map is moved to EAL layer, it is not straightforward=0A= like before for virtio PMD to distinguish the reason why port map fails.=0A= We have two choices. Return 1 to the upper layer to say that we don't=0A= take over the device for all the map failures or we check the driver=0A= type, return -1 for UIO/VFIO driver error, return 1 for kernel driver,=0A= which is a bit overelaborate.=0A= =0A= >=0A= =0A=